December 2010 - jboss-jira - Jboss List Archives

[JBoss JIRA] Created: (JBRULES-2792) Provide accessability of types and metadata for declare-d types

by Wolfgang Laun (JIRA)

Provide accessability of types and metadata for declare-d types --------------------------------------------------------------- Key: JBRULES-2792 URL: https://jira.jboss.org/browse/JBRULES-2792 Project: Drools Issue Type: Feature Request Security Level: Public (Everyone can see) Components: drools-api Affects Versions: 5.1.1.FINAL Reporter: Wolfgang Laun Assignee: Mark Proctor Fix For: FUTURE * All types created or enhanced by a DRL declare construct must be retrievable from the KnowledgeBase using Declare getDeclare( String pkg, String name ) * A Declare object must provide getters String getPackageName(), getName(), Map<String,Object> getMetaData() (same as Rule) * A Declare object must provide Class<?> getFactClass() returning the created or enhanced java-lang.Class. * A Declare object must provide long getInferredExpires() returning (for @role(event)) the inferred expiration offset or -1 if none. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

5
8
0 / 0

[JBoss JIRA] Created: (JBRULES-2779) Declaring events separately from rules breaks expires

by Samuli Saarinen (JIRA)

Declaring events separately from rules breaks expires ------------------------------------------------------ Key: JBRULES-2779 URL: https://jira.jboss.org/browse/JBRULES-2779 Project: Drools Issue Type: Bug Security Level: Public (Everyone can see) Affects Versions: 5.1.1.FINAL Reporter: Samuli Saarinen Assignee: Mark Proctor I have the following situation with Drools 5.1.1: 2 drl files where one contains an event declaration: declare Event1 @role(event) @expires(1s) end and other has a simple rule: rule "Evt1" when e: Event1(value == 10) then System.out.println(e); end And I have the following test which fails: ses.insert(new Event1(1)); ses.fireAllRules(); clock.advanceTime(2, TimeUnit.SECONDS); ses.fireAllRules(); assertEquals(ses.getFactCount(), 0L); The same test passes if the rule and event declaration are on the same drl file. More on the issue here: http://lists.jboss.org/pipermail/rules-users/2010-November/017172.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

7
14
0 / 0

[JBoss JIRA] Created: (JBRULES-2782) Potential memory leak when rules are often reloaded

by Konstantin Pentarakis (JIRA)

Potential memory leak when rules are often reloaded --------------------------------------------------- Key: JBRULES-2782 URL: https://jira.jboss.org/browse/JBRULES-2782 Project: Drools Issue Type: Bug Security Level: Public (Everyone can see) Components: drools-core Affects Versions: 5.1.1.FINAL Environment: Windows 7 x64; JVM: Hotspot; JRE build 1.6.0_22-b04 and JRE build 1.5.0_11-b03 Reporter: Konstantin Pentarakis Assignee: Mark Proctor Hi! There could be a small heapsize memory leak. I encountered the problem when I tried to reload rules very often. The heap-size is permanently growing, eventhough the number of rules is constant! Since the heapsize grows very slowly, this leads to an OutOfMemoryError only, if I have a very large number of rules or if I reload the rules very often. (code-example see below) What do I mean by "reloading rules"? I add rules to an existing KnowledgeBase which is hold in memory. The rules come from an external source. For example, I add 500 rules into a KnowledgeBase (first run). Now, I redo this and add the same 500 rules again to the KnowledgeBase (2nd run). And so on. If I try this using a reduced heapsize of 64 MB, this works fine 71 times! But the 72nd time leads to an OutOfMemoryError, because there is no free heapsize left! It doesn't metter whether I remove the previously added rules first and add them afterwords again, or I directly add them. Using a profiler, I can see, that the heap-consumption constandly increases! The more rules I use, the less interations are possible (closley linearly). The more max. heapsize I use, the more iterations are possible (of course). It seams like the Memory is hold by the RETE itself. The KnowledgeBase itself holds the references! If all references to the KnowledgeBase are deleted, the garbage collections frees the lost memory! I also tried to use sequential mode. But there was no difference at all! This happens with JRE 1.5 and JRE 1.6. This also happens with the Drools 5.1.1 KnowledgeBase-Implemantion and the still in Drools 5 existing RuleBase-Implemention. But I didn't tested it yet with previous versions of Drools. Why do I test this? We are building an application where rules will be created programmatically. There will be a large number of rules (some thousands) and rules can often change. The reload of rules which I tested here is something like a "simulation" of lots of rule changes. Here is my example. For this example I used a simple Class called "RuleRepository" which has a static String-Array holding the rules as DRL-Strings. I also tried it with files in filesystem - no difference. See the RuleRepository-Class below. I post only 3 dummy-rules here - but that makes no difference. If someone wants to test with more rules, you can simply copy and rename them - or use your own rules! MassivRuleChangeTest.java: import java.io.IOException; import java.util.Collection; import org.drools.KnowledgeBase; import org.drools.KnowledgeBaseFactory; import org.drools.builder.KnowledgeBuilder; import org.drools.builder.KnowledgeBuilderFactory; import org.drools.builder.ResourceType; import org.drools.compiler.DroolsParserException; import org.drools.definition.KnowledgePackage; import org.drools.io.ResourceFactory; public class MassivRuleChangeTest { public void run() throws Exception { KnowledgeBase kBase = createRuleBase(); Collection<KnowledgePackage> packages; long counter = 0; int delCounter = 0; int ruleCounter = 0; while (true) { System.out.println(++counter + ":"); for(int iLoop = 0; iLoop < RuleRepository.getSize(); iLoop++) { packages = this.getRulePackage(RuleRepository.getRule(iLoop)); delCounter = this.cleanKBase(kBase, packages, delCounter); kBase.addKnowledgePackages(packages); ruleCounter++; } System.out.println(" - Deleted rules: " + delCounter); System.out.println(" - Added rules: " + ruleCounter); delCounter = 0; ruleCounter = 0; } } private int cleanKBase(KnowledgeBase kBase, Collection<KnowledgePackage> packages, int delCounter) { if(kBase.getKnowledgePackages().size() > 0) { for(KnowledgePackage kPkg : packages) { if(kBase.getKnowledgePackage(kPkg.getName()) != null && kBase.getKnowledgePackage(kPkg.getName()).getRules().size() > 0) { for(org.drools.definition.rule.Rule rule : kPkg.getRules()) { if(kBase.getRule(kPkg.getName(), rule.getName()) != null) { kBase.removeRule(kPkg.getName(), rule.getName()); delCounter++; } } if(kPkg.getRules().size() == 0) kBase.removeKnowledgePackage(kPkg.getName()); } } } return delCounter; } private Collection<KnowledgePackage> getRulePackage(String rule) throws DroolsParserException, IOException { KnowledgeBuilder builder = KnowledgeBuilderFactory.newKnowledgeBuilder(); builder.add(ResourceFactory.newByteArrayResource(rule.getBytes()), ResourceType.DRL); if (builder.hasErrors()) { System.out.println(builder.getErrors().toString()); throw new RuntimeException("Unable to compile " + rule); } return builder.getKnowledgePackages(); } private KnowledgeBase createRuleBase() throws Exception { KnowledgeBase kBase = KnowledgeBaseFactory.newKnowledgeBase(); return kBase; } public static void main(String[] args) throws Exception { new MassivRuleChangeTest().run(); } } ---------------------------------------------------------------------------------------------------------------------------------- RuleRepository.java: public class RuleRepository { private static final String[] rules = { "rule \"Rule001\" when #conditions then #actions end", "rule \"Rule002\" when #conditions then #actions end", "rule \"Rule003\" when #conditions then #actions end", }; public static String getRule(int index) { return rules[index]; } public static int getSize() { return rules.length; } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

6
20
0 / 0

[JBoss JIRA] Created: (JBRULES-2777) rule with window:length/accumulate/not( before ) fires twice

by Wolfgang Laun (JIRA)

rule with window:length/accumulate/not( before ) fires twice ------------------------------------------------------------ Key: JBRULES-2777 URL: https://jira.jboss.org/browse/JBRULES-2777 Project: Drools Issue Type: Bug Security Level: Public (Everyone can see) Components: drools-core Affects Versions: 5.1.1.FINAL Reporter: Wolfgang Laun Assignee: Mark Proctor Fix For: 5.2.0.M1 STREAM, pseudo-clock, insert facts after advancing the clock to the timestamp in the event: for( Job job: jobs.getJobs() ){ Date jobTime = job.getTimestamp(); long newClock = jobTime.getTime(); if( newClock > oldClock ){ clock.advanceTime( newClock - oldClock, TimeUnit.MILLISECONDS ); oldClock = newClock; } System.out.println( "inserting " + job ); session.insert( job ); System.out.println( "advancing by 1ms" ); clock.advanceTime( 1, TimeUnit.MILLISECONDS ); oldClock++; System.out.println( "fireAllRules" ); session.fireAllRules(); } A single rule: declare Job @role( event ) @timestamp( timestamp ) @duration( duration ) end Part of output: inserting Job: 6 at Wed Nov 03 01:40:00 CET 2010 - 1000 advancing by 1ms clock: 1288744799999, ts of 1st: 1288742400000 - Average interval: 599 seconds clock: 1288744799999, ts of 1st: 1288743000000 - Average interval: 449 seconds fireAllRules inserting Job: 7 at Wed Nov 03 01:45:00 CET 2010 - 1000 advancing by 1ms clock: 1288745099999, ts of 1st: 1288743000000 - Average interval: 524 seconds clock: 1288745099999, ts of 1st: 1288743600000 - Average interval: 374 seconds fireAllRules Rule firing is erratic. There is no apparent reason why this should fire twice after advancing the clock. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

6
14
0 / 0

[JBoss JIRA] Created: (JBRULES-2819) DSL parsing/expansion: '\', '$', empty value, empty condition

by Wolfgang Laun (JIRA)

DSL parsing/expansion: '\', '$', empty value, empty condition --------------------------------------------------------------- Key: JBRULES-2819 URL: https://jira.jboss.org/browse/JBRULES-2819 Project: Drools Issue Type: Bug Security Level: Public (Everyone can see) Components: drools-compiler-DSL Affects Versions: 5.1.1.FINAL Reporter: Wolfgang Laun Assignee: Mark Proctor Fix For: 5.2.0.M1 DSL parser does not accept an empty "value" section, e.g. [when] a man loves a woman= Expansion of a rule with an empty condition results in "whenthen". The DSL parser escapes '$', but not '\' in value sections. It should not modify the value section except for "normalizing" variable references. Variable references should be restricted to a "clean" character sequence (e.g. Java identifier). The current expansion using replaceAll is too fragile. I have emailed three reworked source files AntlrDSLMappingEntry.java DefaultExpander.java DSLTokenizedMappingFile.java to Edson, but I didn't change the parser itself. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

6
13
0 / 0

[JBoss JIRA] Created: (JBRULES-2845) threading issues when using MultithreadEvaluationOption.YES with fusion

by Radai Rosenblatt (JIRA)

threading issues when using MultithreadEvaluationOption.YES with fusion ----------------------------------------------------------------------- Key: JBRULES-2845 URL: https://issues.jboss.org/browse/JBRULES-2845 Project: Drools Issue Type: Bug Security Level: Public (Everyone can see) Components: drools-compiler (fusion), drools-core (expert) Affects Versions: 5.1.1.FINAL Environment: dual core processor, jdk 6u21, windows xp Reporter: Radai Rosenblatt Assignee: Mark Proctor Attachments: threadingbug.zip i have 2 very simple rules and a test case (see attached maven project). trying to set MultithreadEvaluationOption.YES on the KB causes the test to fail sporadically (~10% of the times?). the attached project contains a testsuite that runs the same test 8 times (testsuite is defined in RunMe.java). attempting "mvn clean install" runs this suite and usually fails. commenting out the MultithreadEvaluationOption.YES line in the other testcase (the one referred-to from RunMe) causes the tests to behave as expected (pass). -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

6
11
0 / 0

[JBoss JIRA] Created: (JBRULES-2616) Process persistent timers

by Diego Lopez Leon (JIRA)

Process persistent timers ------------------------- Key: JBRULES-2616 URL: https://jira.jboss.org/browse/JBRULES-2616 Project: Drools Issue Type: Feature Request Security Level: Public (Everyone can see) Components: drools-process Affects Versions: 5.1.0.FINAL Reporter: Diego Lopez Leon Assignee: Mark Proctor Implement a mechanism to allow scheduled timers to be triggered beyond the scope of a disposed session. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

3
3
0 / 0

[JBoss JIRA] Created: (JGRP-1052) Ergonomics

by Bela Ban (JIRA)

Ergonomics ---------- Key: JGRP-1052 URL: https://jira.jboss.org/jira/browse/JGRP-1052 Project: JGroups Issue Type: Feature Request Reporter: Bela Ban Assignee: Bela Ban Fix For: 3.0 The goal is to (a) reduce the number of properties needed and (b) determine the values dynamically. Examples: - Determine the best min/max size of a thread pool - Find out what the best timeout values are for retransmission, e.g. based on average retransmission times - Determine the optimal number of credits in FC This is similar to the JVM setting where, starting with 1.5, the initial values can be set, but over time, the JVM dynamically changes them. In the best case, a config contains only a list of protocols without any properties, and JGroups will figure out the correct values. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

2
4
0 / 0

[JBoss JIRA] Created: (JBRULES-2438) loading multiple sheets of single Excel book by one change-set xml

by Toshiya Kobayashi (JIRA)

loading multiple sheets of single Excel book by one change-set xml ------------------------------------------------------------------ Key: JBRULES-2438 URL: https://jira.jboss.org/jira/browse/JBRULES-2438 Project: Drools Issue Type: Feature Request Security Level: Public (Everyone can see) Components: drools-core Affects Versions: 5.0.1.FINAL Reporter: Toshiya Kobayashi Assignee: Mark Proctor I'm trying to use rules via DecisionTable using change-set. I wrote rules in multiple sheets of single Excel book. Then I configured my change-set xml like: ... <add> <resource source='classpath:data/dtable.xls' type="DTABLE"> <decisiontable-conf input-type="XLS" worksheet-name="sheet1" /> </resource> <resource source='classpath:data/dtable.xls' type="DTABLE"> <decisiontable-conf input-type="XLS" worksheet-name="sheet2" /> </resource> </add> ... But only rules of sheet1 were loaded. As far as I observed source codes, KnowledgeAgentImpl.java puts resource into "Map<Resource, ResourceMapping> resources". But even if multiple resources are configured in change-set, it appears to me like those resources are considered as the same resource and eventually only one resource will be registered. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

4
22
0 / 0

[JBoss JIRA] Created: (JBMESSAGING-1287) SOA-P test suite failures

by Aleksandar Kostadinov (JIRA)

SOA-P test suite failures ------------------------- Key: JBMESSAGING-1287 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1287 Project: JBoss Messaging Issue Type: Bug Affects Versions: 1.4.0.SP3_CP01 Reporter: Aleksandar Kostadinov Assigned To: Tim Fox I'm running the JBM test suite against the binaries in the SOA-P Platform 4.2 CP01. I see 4 failures. * TEST-org.jboss.test.messaging.jms.bridge.BridgeTest-Remote-bisocket.xml. * org.jboss.test.messaging.jms.clustering.MultipleFailoverTest(Clustering).testFailoverFloodTwoServers * org.jboss.test.messaging.jms.clustering.NoFailoverTest(Clustering).testCrashNoFailover * org.jboss.test.messaging.jms.ManifestTest.testManifestEntries Failure details in here http://hudson.qa.jboss.com/hudson/job/jboss-soa-platform-JBM-testsuite/73... 3 of the failures are timeout (see console log for BridgeTest). We are running on a 2 CPU DualCore physical machine so system speed should not be an issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

6
30
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira December 2010