[JBoss JIRA] Created: (JASSIST-129) getRefClasses() fails for some of the inner classes defined in java.util
by Maciej Kokocinski (JIRA)
getRefClasses() fails for some of the inner classes defined in java.util
------------------------------------------------------------------------
Key: JASSIST-129
URL: https://jira.jboss.org/browse/JASSIST-129
Project: Javassist
Issue Type: Bug
Affects Versions: 3.13.0.GA
Reporter: Maciej Kokocinski
Assignee: Shigeru Chiba
CtClass.getRefClasses() reports not existing classes in some cases.
One out of many examples is "java.util.LinkedList$DescendingIterator". getRefClasses() for this class returns, as one of the resulting list elements, "istItr" which is obviously wrong as there is no such class.
There is a field inside this class named itr of type 'java.util.LinkedList$ListItr". If we get fieldInfo for this field its descriptor is "Ljava/util/LinkedList$ListItr;", however if we take its SignatureAttribute, then its signature is "Ljava/util/LinkedList<TE;>.ListItr;". When this string is parsed during AttributeInfo.renameClass(List, ClassMap) then a class named "istItr" is 'found'.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 8 months
[JBoss JIRA] Created: (EJBTHREE-2168) env-entry with an injection-target but without an explicit env-entry-type fails with java.lang.ClassNotFoundException: Null class name
by jaikiran pai (JIRA)
env-entry with an injection-target but without an explicit env-entry-type fails with java.lang.ClassNotFoundException: Null class name
--------------------------------------------------------------------------------------------------------------------------------------
Key: EJBTHREE-2168
URL: https://jira.jboss.org/browse/EJBTHREE-2168
Project: EJB 3.0
Issue Type: Bug
Components: core
Affects Versions: depchain-1.0.0-alpha-4
Reporter: jaikiran pai
Assignee: jaikiran pai
Consider the following content in ejb-jar.xml:
<session>
<ejb-name>Bean</ejb-name>
<env-entry>
<env-entry-name>someString</env-entry-name>
<env-entry-value>Hello world</env-entry-value>
<injection-target>
<injection-target-class>org.myapp.ejb.MyEJB</injection-target-class>
<injection-target-name>someString</injection-target-name>
</injection-target>
</env-entry>
Note that we haven't explicitly specified the env-entry-type element. This runs into:
Caused by: java.lang.ClassNotFoundException: Null class name
at org.jboss.classloader.plugins.ClassLoaderUtils.checkClassName(ClassLoaderUtils.java:53) [jboss-classloader.jar:2.2.0.Alpha8]
at org.jboss.classloader.spi.base.BaseClassLoader.loadClass(BaseClassLoader.java:425) [jboss-classloader.jar:2.2.0.Alpha8]
at java.lang.ClassLoader.loadClass(ClassLoader.java:252) [:1.6.0_16]
at org.jboss.injection.EnvEntryEncInjector.getEnvEntryValue(EnvEntryEncInjector.java:66) [:1.5.1]
at org.jboss.injection.EnvEntryEncInjector.inject(EnvEntryEncInjector.java:53) [:1.5.1]
... 82 more
As per the spec, in the absence of explicit env-entry-type, the type has to be inferred from the injection-target (if present).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 8 months
[JBoss JIRA] Created: (JBCOMMON-111) Graph#addEdge() micro optimization
by Ondrej Žižka (JIRA)
Graph#addEdge() micro optimization
----------------------------------
Key: JBCOMMON-111
URL: https://jira.jboss.org/browse/JBCOMMON-111
Project: JBoss Common
Issue Type: Quality Risk
Security Level: Public (Everyone can see)
Affects Versions: 2.2.16.GA
Reporter: Ondrej Žižka
Assignee: Dimitris Andreadis
Priority: Trivial
class Graph:
public boolean addEdge(Vertex<T> from, Vertex<T> to, int cost) {
...
from.addEdge(e);
to.addEdge(e);
edges.add(e);
}
class Vertex:
public boolean addEdge(Edge<T> e) {
if (e.getFrom() == this)
outgoingEdges.add(e);
else if (e.getTo() == this)
incomingEdges.add(e);
else
return false;
return true;
}
Since the method knows the direction of the edge, why not use this knowledge and avoid unnecessary vertex comparion in Vertex#addEdge() ?
public boolean addEdge(Vertex<T> from, Vertex<T> to, int cost) {
...
from.addOutgoingEdge(e, cost);
to.addIncomingEdge(e, cost);
edges.add(e);
}
addOutgoingEdge and addIncomingEdge do something else -- they create a new edge, which is a bit unintuitive, I'd call them createOutgoingEdge() -- but I hope it's clear what I mean.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 8 months