[JBoss JIRA] (WFLY-3277) Fix for JAVASERVERFACES-3189 causes memory leak
by Farah Juma (JIRA)
[ https://issues.jboss.org/browse/WFLY-3277?page=com.atlassian.jira.plugin.... ]
Farah Juma commented on WFLY-3277:
----------------------------------
Because the JSF implementation module dependency is added to every deployment, one ConfigureListener gets registered for every deployment even if it doesn't use JSF (the ConfigureListener is defined in the jsf_core.tld file in the jsf-impl.jar). For apps that use JSF, a second ConfigureListener ends up getting added by Mojarra if the app doesn't contain a mapping of FacesServlet in its web.xml file (this is because of a [workaround | https://issues.jboss.org/browse/WFLY-2594?focusedCommentId=12946617&page=...] for a GlassFish issue that was added to Mojarra 2.x).
I found that the memory leak only affects non-JSF apps though. As discussed with Tomaz, one way to work around the issue is to have the JSF subsystem remove the ConfigureListener from the TLD metadata unless the app has a mapping of FacesServlet in its web.xml. I tried this out (see [here| https://github.com/fjuma/wildfly/commit/fc9157ffc734960f20feb2262ea8c0509...]) and it does work. However, I think I just found a better way to fix this in ConfigureListener by making sure that appropriate clean up is done when ConfigureListener.contextInitialized() is called for an app that doesn't use JSF. I've created the following upstream issue and if my fix looks good to the Mojarra team, I can apply it to our fork:
https://java.net/jira/browse/JAVASERVERFACES-3260
> Fix for JAVASERVERFACES-3189 causes memory leak
> -----------------------------------------------
>
> Key: WFLY-3277
> URL: https://issues.jboss.org/browse/WFLY-3277
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: JSF
> Affects Versions: 8.1.0.CR1
> Reporter: Tomaz Cerar
> Assignee: Farah Juma
> Priority: Blocker
> Fix For: 8.1.0.Final
>
> Attachments: capedwarf-test.war
>
>
> Running capedwarf testsuite we found out that after upgrade to 8.1.0.CR1 testsuite does not complete as server dies with OOM.
> I traced problem down to this commit: https://github.com/jboss/mojarra/commit/d0f9f873dc0f99047a0a5031631d091fa...
> reverting it fixes the problem.
> For what is worth, I think original problem comes from fact that we somehow register two ConfigureListeners for every deployment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (WFLY-3295) AsyncContext#start runs in caller thread
by Stuart Douglas (JIRA)
[ https://issues.jboss.org/browse/WFLY-3295?page=com.atlassian.jira.plugin.... ]
Stuart Douglas resolved WFLY-3295.
----------------------------------
Fix Version/s: 8.1.0.Final
Resolution: Done
> AsyncContext#start runs in caller thread
> ----------------------------------------
>
> Key: WFLY-3295
> URL: https://issues.jboss.org/browse/WFLY-3295
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Web (Undertow)
> Affects Versions: 8.1.0.CR1
> Reporter: Philippe Marschall
> Assignee: Stuart Douglas
> Fix For: 8.1.0.Final
>
> Attachments: AsyncServlet.java
>
>
> {{javax.servlet.AsyncContext.start(Runnable)}} seems to run the runnable in the caller thread. In order for this method to be useful it should be run in a different thread.
> I'll attach a class to demonstrate the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (WFLY-3301) JPA subsystem should check explicitely for java:comp/DefaultDataSource
by Scott Marlow (JIRA)
[ https://issues.jboss.org/browse/WFLY-3301?page=com.atlassian.jira.plugin.... ]
Scott Marlow updated WFLY-3301:
-------------------------------
Attachment: msc.txt
hang.txt
msc.txt contains the services after waiting a few minutes for the " mvn clean install -Dtest=org.jboss.as.test.integration.jpa.datasourcedefinition.DataSourceDefinitionJPATestCase" test to complete deployment.
hang.txt contains a thread dump of the app server
> JPA subsystem should check explicitely for java:comp/DefaultDataSource
> ----------------------------------------------------------------------
>
> Key: WFLY-3301
> URL: https://issues.jboss.org/browse/WFLY-3301
> Project: WildFly
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: JPA / Hibernate
> Reporter: Scott Marlow
> Assignee: Scott Marlow
> Fix For: 8.1.0.Final
>
> Attachments: hang.txt, msc.txt
>
>
> Improve checking for default datasource. Workaround for this issue to set the persistence unit "wildfly.jpa.twophasebootstrap" hint to false.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months
[JBoss JIRA] (WFLY-3274) Expose connector metric values such as requestCount , maxTime, bytesReceived, etc
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-3274?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated WFLY-3274:
---------------------------------
Summary: Expose connector metric values such as requestCount , maxTime, bytesReceived, etc (was: connector values are not available like "requestCount , maxTime, bytesReceived etc " in wildfly (domain mode) 8.0.0.Final )
Issue Type: Feature Request (was: Enhancement)
> Expose connector metric values such as requestCount , maxTime, bytesReceived, etc
> ---------------------------------------------------------------------------------
>
> Key: WFLY-3274
> URL: https://issues.jboss.org/browse/WFLY-3274
> Project: WildFly
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Web (Undertow)
> Affects Versions: 8.0.0.Final
> Reporter: Rituraj Sinha
> Assignee: Tomaz Cerar
>
> while using jboss 7.2.0 we were able to fetch above values from the cli command as
> {noformat}
> [domain@test.com:9999 subsystem=web] ls
> configuration valve default-virtual-server=default-host native=false
> connector virtual-server instance-id=${jboss.node.name}
> [domain@test.com:9999 connector] ls
> ajp http
> [domain@test.com:9999 connector] cd http
> [domain@test.com:9999 connector] pwd
> /profile=ha/subsystem=web/connector=http
> [domain@test.com:9999 connector=http] ls
> configuration max-connections=undefined proxy-port=undefined
> ssl max-post-size=2097152 redirect-port=443
> bytesReceived= max-save-post-size=4096 requestCount=
> bytesSent= maxTime= scheme=http
> enable-lookups=false name=http secure=false
> enabled=true processingTime= socket-binding=http
> errorCount= protocol=HTTP/1.1 virtual-server=undefined
> executor=undefined proxy-name=undefined
> {noformat}
>
> Now we have moved to wildfly8 and trying to look for the same values in underetow( as there is no "web" subsystem in wildfly8)
> as below
> {noformat}
> [domain@test2.com:9990 subsystem=undertow] ls
> buffer-cache server default-servlet-container=default statistics-enabled=false (Here there is no connector attribute available as this was in jboss 7.2.0 )
> configuration servlet-container default-virtual-host=default-host
> error-page default-server=default-server instance-id=${jboss.node.name}
> {noformat}
>
> but the listners(HTTP, AJP and HTTPS ) are defined in the server attribute...hence going into server attribute we get the below as
> {noformat}
> [domain@test2.com:9990 server=default-server] ls
> ajp-listener host http-listener https-listener default-host=default-host servlet-container=default
> {noformat}
> after getting into http-listener we get the below
> {noformat}
> [domain@test2.com:9990 http-listener=default] ls
> allow-encoded-slash=false certificate-forwarding=false max-cookies=200 max-post-size=10485760 socket-binding=http
> always-set-keep-alive=true decode-url=true max-header-size=51200 proxy-address-forwarding=false url-charset=UTF-8
> buffer-pipelined-data=true enabled=true max-headers=200 record-request-start-time=false worker=default
> buffer-pool=default max-buffered-request-size=16384 max-parameters=1000 redirect-socket=https
> {noformat}
>
> Can someone please look into it ..?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 8 months