[JBoss JIRA] (WFLY-2789) Remote client transaction timeout values are overwrote by hardcoded values
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFLY-2789?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on WFLY-2789:
-----------------------------------------------
Ivo Studensky <istudens(a)redhat.com> changed the Status of [bug 1093128|https://bugzilla.redhat.com/show_bug.cgi?id=1093128] from NEW to ASSIGNED
> Remote client transaction timeout values are overwrote by hardcoded values
> --------------------------------------------------------------------------
>
> Key: WFLY-2789
> URL: https://issues.jboss.org/browse/WFLY-2789
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: EJB
> Reporter: Johnathon Lee
> Assignee: David Lloyd
> Fix For: 8.1.0.Final, 9.0.0.Alpha1
>
>
> The EJB3 interceptor is not using client values for timeouts, this is a problem for users trying to use EJB for transaction propagation.
> Refer to the code in https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jbo...:
> private void createOrResumeXidTransaction(final XidTransactionID xidTransactionID) throws Exception {
> final TransactionManager transactionManager = this.ejbRemoteTransactionsRepository.getTransactionManager();
> final Transaction alreadyCreatedTx = this.ejbRemoteTransactionsRepository.getImportedTransaction(xidTransactionID);
> if (alreadyCreatedTx != null) {
> // resume the already created tx
> transactionManager.resume(alreadyCreatedTx);
> } else {
> // begin a new tx and add it to the tx repository
> // TODO: Fix the tx timeout (which currently is passed as 300 seconds)
> final Transaction newSubOrdinateTx = this.ejbRemoteTransactionsRepository.importTransaction(xidTransactionID, 300);
> // associate this tx with the thread
> transactionManager.resume(newSubOrdinateTx);
> }
> }
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
12 years, 1 month
[JBoss JIRA] (WFLY-1513) remove operation on JMS queue/topic doesn't remove the destination but just unbinds from JNDI
by Jeff Mesnil (JIRA)
[ https://issues.jboss.org/browse/WFLY-1513?page=com.atlassian.jira.plugin.... ]
Jeff Mesnil updated WFLY-1513:
------------------------------
Fix Version/s: 9.0.0.Alpha1
> remove operation on JMS queue/topic doesn't remove the destination but just unbinds from JNDI
> ---------------------------------------------------------------------------------------------
>
> Key: WFLY-1513
> URL: https://issues.jboss.org/browse/WFLY-1513
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Domain Management, JMS
> Affects Versions: 8.0.0.Alpha1, 8.0.0.Alpha2
> Reporter: jaikiran pai
> Assignee: Jeff Mesnil
> Fix For: 9.0.0.Alpha1
>
>
> The remove (management) operation on a JMS queue merely unbinds the queue from JNDI instead of destroying the queue. It appears that the change was done as part of https://issues.jboss.org/browse/AS7-1899 (the PR is here https://github.com/wildfly/wildfly/pull/398). The change done in that PR to address the original issue reported in that other JIRA doesn't look right.
> So the original issue reported in that thread is that a server has a queue with messages and the server is stopped. Upon restart the messages have disappeared because upon stop, the JMSQueueService's stop() method used to destroy the queue. The real fix would have been to differentiate the "remove()" operation from a mere service stop. The explicit remove (handler) would then be responsible for destroying the queue (which even means a JNDI unbind) and not that service's stop method.
> All of this even applies to the JMS topic which has a similar problem.
> On a related note, the add() operation too seems suspicious because it ends up calling a createXXX on the JMSServer API which says:
> {code}
> /**
> * Creates a JMS Queue.
> *
> * @param queueName
> * The name of the queue to create
> * @param selectorString
> * @param durable
> * @return true if the queue is created or if it existed and was added to
> * JNDI
> * @throws Exception
> * if problems were encountered creating the queue.
> */
> boolean createQueue(boolean storeConfig, String queueName, String selectorString, boolean durable, String ...bindings) throws Exception;
> {code}
> Notice the "if the queue is created or if it existed and was added to JNDI" part. So it appears that the management "add" operation can end up behaving like an update (write-attribute) kind of operation in some cases. I'm not sure if that's good thing.
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
12 years, 1 month
[JBoss JIRA] (WFLY-2789) Remote client transaction timeout values are overwrote by hardcoded values
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFLY-2789?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on WFLY-2789:
-----------------------------------------------
Ivo Studensky <istudens(a)redhat.com> changed the Status of [bug 1093752|https://bugzilla.redhat.com/show_bug.cgi?id=1093752] from ASSIGNED to POST
> Remote client transaction timeout values are overwrote by hardcoded values
> --------------------------------------------------------------------------
>
> Key: WFLY-2789
> URL: https://issues.jboss.org/browse/WFLY-2789
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: EJB
> Reporter: Johnathon Lee
> Assignee: David Lloyd
> Fix For: 8.1.0.Final, 9.0.0.Alpha1
>
>
> The EJB3 interceptor is not using client values for timeouts, this is a problem for users trying to use EJB for transaction propagation.
> Refer to the code in https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jbo...:
> private void createOrResumeXidTransaction(final XidTransactionID xidTransactionID) throws Exception {
> final TransactionManager transactionManager = this.ejbRemoteTransactionsRepository.getTransactionManager();
> final Transaction alreadyCreatedTx = this.ejbRemoteTransactionsRepository.getImportedTransaction(xidTransactionID);
> if (alreadyCreatedTx != null) {
> // resume the already created tx
> transactionManager.resume(alreadyCreatedTx);
> } else {
> // begin a new tx and add it to the tx repository
> // TODO: Fix the tx timeout (which currently is passed as 300 seconds)
> final Transaction newSubOrdinateTx = this.ejbRemoteTransactionsRepository.importTransaction(xidTransactionID, 300);
> // associate this tx with the thread
> transactionManager.resume(newSubOrdinateTx);
> }
> }
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
12 years, 1 month
[JBoss JIRA] (DROOLS-506) Example project: massive number of code quality / correctness warnings
by Peter Horvath (JIRA)
[ https://issues.jboss.org/browse/DROOLS-506?page=com.atlassian.jira.plugin... ]
Peter Horvath updated DROOLS-506:
---------------------------------
Attachment: eclipse_warnings.png
Screenshot of Eclipse displaying warnings found in Drools example projects
> Example project: massive number of code quality / correctness warnings
> ----------------------------------------------------------------------
>
> Key: DROOLS-506
> URL: https://issues.jboss.org/browse/DROOLS-506
> Project: Drools
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Horvath
> Assignee: Mark Proctor
> Attachments: eclipse_warnings.png
>
>
> The Drools example project contains code snippets that yield warnings: *while I absolutely understand that resources are limited and examples might not be the priority and the core code of the engine is of good quality*, I do think it is important to display dedication to high quality products.
> Having an example project full of code quality issues just gives a very bad first impression of the whole Drools project...
> Examples:
> {code:title=org.drools.examples.cashflow.CashFlowMain|borderStyle=solid}
> public class CashFlowMain {
> public static void main(String[] args) throws Exception {
> SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
> {code}
> yields {color:red}WARNING: The value of the local variable sdf is not used {color}
> {code:title=org.drools.examples.sudoku.Sudoku.dumpGrid()|borderStyle=solid}
> /**
> * Nice printout of the grid.
> */
> public void dumpGrid() {
> Formatter fmt = new Formatter(System.out);
> {code}
> yields {color:red}WARNING: Resource leak: 'fmt' is never closed {color}
> {code:title=org.drools.games.pong.PongUI|borderStyle=solid}
> import java.awt.*;
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyListener;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.font.FontRenderContext;
> import java.awt.font.TextLayout;
> import java.awt.image.BufferedImage;
> import javax.swing.*;
> import org.drools.games.GameConfiguration;
> import org.drools.games.GameUI;
> import org.kie.api.runtime.KieSession;
> import org.kie.internal.runtime.StatefulKnowledgeSession;
> import org.kie.api.runtime.rule.FactHandle;
> import org.kie.api.runtime.rule.EntryPoint;
> public class PongUI extends GameUI {
> {code}
> yields {color:red}WARNING: The import java.awt.event.KeyEvent is never used {color} \\
> {color:red}WARNING: The import java.awt.event.KeyListener is never used {color} \\
> {color:red}WARNING: The import java.awt.event.MouseEvent is never used {color} \\
> {color:red}WARNING: The import java.awt.event.MouseListener is never used {color} \\
> {color:red}WARNING: The import java.awt.image.BufferedImage is never used {color} \\
> {color:red}WARNING: The import javax.swing.* is never used {color} \\
> {color:red}WARNING: The import org.kie.internal.runtime.StatefulKnowledgeSession is never used {color} \\
> {color:red}WARNING: The import org.kie.api.runtime.rule.FactHandle is never used {color} \\
> {color:red}WARNING: The import org.kie.api.runtime.rule.EntryPoint is never used {color} \\
> etc
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
12 years, 1 month
[JBoss JIRA] (DROOLS-506) Example project: massive number of code quality / correctness warnings
by Peter Horvath (JIRA)
[ https://issues.jboss.org/browse/DROOLS-506?page=com.atlassian.jira.plugin... ]
Peter Horvath updated DROOLS-506:
---------------------------------
Description:
The Drools example project contains code snippets that yield warnings: *while I absolutely understand that resources are limited and examples might not be the priority and the core code of the engine is of good quality*, I do think it is important to display dedication to high quality products.
Having an example project full of code quality issues just gives a very bad first impression of the whole Drools project...
Examples:
{code:title=org.drools.examples.cashflow.CashFlowMain|borderStyle=solid}
public class CashFlowMain {
public static void main(String[] args) throws Exception {
SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
{code}
yields {color:red}WARNING: The value of the local variable sdf is not used {color}
{code:title=org.drools.examples.sudoku.Sudoku.dumpGrid()|borderStyle=solid}
/**
* Nice printout of the grid.
*/
public void dumpGrid() {
Formatter fmt = new Formatter(System.out);
{code}
yields {color:red}WARNING: Resource leak: 'fmt' is never closed {color}
{code:title=org.drools.games.pong.PongUI|borderStyle=solid}
import java.awt.*;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.font.FontRenderContext;
import java.awt.font.TextLayout;
import java.awt.image.BufferedImage;
import javax.swing.*;
import org.drools.games.GameConfiguration;
import org.drools.games.GameUI;
import org.kie.api.runtime.KieSession;
import org.kie.internal.runtime.StatefulKnowledgeSession;
import org.kie.api.runtime.rule.FactHandle;
import org.kie.api.runtime.rule.EntryPoint;
public class PongUI extends GameUI {
{code}
yields {color:red}WARNING: The import java.awt.event.KeyEvent is never used {color} \\
{color:red}WARNING: The import java.awt.event.KeyListener is never used {color} \\
{color:red}WARNING: The import java.awt.event.MouseEvent is never used {color} \\
{color:red}WARNING: The import java.awt.event.MouseListener is never used {color} \\
{color:red}WARNING: The import java.awt.image.BufferedImage is never used {color} \\
{color:red}WARNING: The import javax.swing.* is never used {color} \\
{color:red}WARNING: The import org.kie.internal.runtime.StatefulKnowledgeSession is never used {color} \\
{color:red}WARNING: The import org.kie.api.runtime.rule.FactHandle is never used {color} \\
{color:red}WARNING: The import org.kie.api.runtime.rule.EntryPoint is never used {color} \\
etc
was:
The Drools example project contains code snippets that yield warnings:
Examples:
{code:title=org.drools.examples.cashflow.CashFlowMain|borderStyle=solid}
public class CashFlowMain {
public static void main(String[] args) throws Exception {
SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
{code}
yields {color:red}WARNING: The value of the local variable sdf is not used {color}
{code:title=org.drools.examples.sudoku.Sudoku.dumpGrid()|borderStyle=solid}
/**
* Nice printout of the grid.
*/
public void dumpGrid() {
Formatter fmt = new Formatter(System.out);
{code}
yields {color:red}WARNING: Resource leak: 'fmt' is never closed {color}
{code:title=org.drools.games.pong.PongUI|borderStyle=solid}
import java.awt.*;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.font.FontRenderContext;
import java.awt.font.TextLayout;
import java.awt.image.BufferedImage;
import javax.swing.*;
import org.drools.games.GameConfiguration;
import org.drools.games.GameUI;
import org.kie.api.runtime.KieSession;
import org.kie.internal.runtime.StatefulKnowledgeSession;
import org.kie.api.runtime.rule.FactHandle;
import org.kie.api.runtime.rule.EntryPoint;
public class PongUI extends GameUI {
{code}
yields {color:red}WARNING: The import java.awt.event.KeyEvent is never used {color} \\
{color:red}WARNING: The import java.awt.event.KeyListener is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
> Example project: massive number of code quality / correctness warnings
> ----------------------------------------------------------------------
>
> Key: DROOLS-506
> URL: https://issues.jboss.org/browse/DROOLS-506
> Project: Drools
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Peter Horvath
> Assignee: Mark Proctor
>
> The Drools example project contains code snippets that yield warnings: *while I absolutely understand that resources are limited and examples might not be the priority and the core code of the engine is of good quality*, I do think it is important to display dedication to high quality products.
> Having an example project full of code quality issues just gives a very bad first impression of the whole Drools project...
> Examples:
> {code:title=org.drools.examples.cashflow.CashFlowMain|borderStyle=solid}
> public class CashFlowMain {
> public static void main(String[] args) throws Exception {
> SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
> {code}
> yields {color:red}WARNING: The value of the local variable sdf is not used {color}
> {code:title=org.drools.examples.sudoku.Sudoku.dumpGrid()|borderStyle=solid}
> /**
> * Nice printout of the grid.
> */
> public void dumpGrid() {
> Formatter fmt = new Formatter(System.out);
> {code}
> yields {color:red}WARNING: Resource leak: 'fmt' is never closed {color}
> {code:title=org.drools.games.pong.PongUI|borderStyle=solid}
> import java.awt.*;
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyListener;
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseListener;
> import java.awt.font.FontRenderContext;
> import java.awt.font.TextLayout;
> import java.awt.image.BufferedImage;
> import javax.swing.*;
> import org.drools.games.GameConfiguration;
> import org.drools.games.GameUI;
> import org.kie.api.runtime.KieSession;
> import org.kie.internal.runtime.StatefulKnowledgeSession;
> import org.kie.api.runtime.rule.FactHandle;
> import org.kie.api.runtime.rule.EntryPoint;
> public class PongUI extends GameUI {
> {code}
> yields {color:red}WARNING: The import java.awt.event.KeyEvent is never used {color} \\
> {color:red}WARNING: The import java.awt.event.KeyListener is never used {color} \\
> {color:red}WARNING: The import java.awt.event.MouseEvent is never used {color} \\
> {color:red}WARNING: The import java.awt.event.MouseListener is never used {color} \\
> {color:red}WARNING: The import java.awt.image.BufferedImage is never used {color} \\
> {color:red}WARNING: The import javax.swing.* is never used {color} \\
> {color:red}WARNING: The import org.kie.internal.runtime.StatefulKnowledgeSession is never used {color} \\
> {color:red}WARNING: The import org.kie.api.runtime.rule.FactHandle is never used {color} \\
> {color:red}WARNING: The import org.kie.api.runtime.rule.EntryPoint is never used {color} \\
> etc
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
12 years, 1 month
[JBoss JIRA] (WFLY-2789) Remote client transaction timeout values are overwrote by hardcoded values
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/WFLY-2789?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on WFLY-2789:
-----------------------------------------------
Ivo Studensky <istudens(a)redhat.com> changed the Status of [bug 1093752|https://bugzilla.redhat.com/show_bug.cgi?id=1093752] from NEW to ASSIGNED
> Remote client transaction timeout values are overwrote by hardcoded values
> --------------------------------------------------------------------------
>
> Key: WFLY-2789
> URL: https://issues.jboss.org/browse/WFLY-2789
> Project: WildFly
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: EJB
> Reporter: Johnathon Lee
> Assignee: David Lloyd
> Fix For: 8.1.0.Final, 9.0.0.Alpha1
>
>
> The EJB3 interceptor is not using client values for timeouts, this is a problem for users trying to use EJB for transaction propagation.
> Refer to the code in https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jbo...:
> private void createOrResumeXidTransaction(final XidTransactionID xidTransactionID) throws Exception {
> final TransactionManager transactionManager = this.ejbRemoteTransactionsRepository.getTransactionManager();
> final Transaction alreadyCreatedTx = this.ejbRemoteTransactionsRepository.getImportedTransaction(xidTransactionID);
> if (alreadyCreatedTx != null) {
> // resume the already created tx
> transactionManager.resume(alreadyCreatedTx);
> } else {
> // begin a new tx and add it to the tx repository
> // TODO: Fix the tx timeout (which currently is passed as 300 seconds)
> final Transaction newSubOrdinateTx = this.ejbRemoteTransactionsRepository.importTransaction(xidTransactionID, 300);
> // associate this tx with the thread
> transactionManager.resume(newSubOrdinateTx);
> }
> }
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
12 years, 1 month
[JBoss JIRA] (DROOLS-506) Example project: massive number of code quality / correctness warnings
by Peter Horvath (JIRA)
Peter Horvath created DROOLS-506:
------------------------------------
Summary: Example project: massive number of code quality / correctness warnings
Key: DROOLS-506
URL: https://issues.jboss.org/browse/DROOLS-506
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Peter Horvath
Assignee: Mark Proctor
The Drools example project contains code snippets that yield warnings:
Examples:
{code:title=org.drools.examples.cashflow.CashFlowMain|borderStyle=solid}
public class CashFlowMain {
public static void main(String[] args) throws Exception {
SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
{code}
yields {color:red}WARNING: The value of the local variable sdf is not used {color}
{code:title=org.drools.examples.sudoku.Sudoku.dumpGrid()|borderStyle=solid}
/**
* Nice printout of the grid.
*/
public void dumpGrid() {
Formatter fmt = new Formatter(System.out);
{code}
yields {color:red}WARNING: Resource leak: 'fmt' is never closed {color}
{code:title=org.drools.games.pong.PongUI|borderStyle=solid}
import java.awt.*;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.font.FontRenderContext;
import java.awt.font.TextLayout;
import java.awt.image.BufferedImage;
import javax.swing.*;
import org.drools.games.GameConfiguration;
import org.drools.games.GameUI;
import org.kie.api.runtime.KieSession;
import org.kie.internal.runtime.StatefulKnowledgeSession;
import org.kie.api.runtime.rule.FactHandle;
import org.kie.api.runtime.rule.EntryPoint;
public class PongUI extends GameUI {
{code}
yields {color:red}WARNING: The import java.awt.event.KeyEvent is never used {color} \\
{color:red}WARNING: The import java.awt.event.KeyListener is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
{color:red}WARNING: The import XXXXXXXXX is never used {color} \\
--
This message was sent by Atlassian JIRA
(v6.2.3#6260)
12 years, 1 month