[JBoss JIRA] (WFLY-7717) Undefine operation fails for /subsystem=undertow statistics-enabled attribute
by Radim Hatlapatka (JIRA)
Radim Hatlapatka created WFLY-7717:
--------------------------------------
Summary: Undefine operation fails for /subsystem=undertow statistics-enabled attribute
Key: WFLY-7717
URL: https://issues.jboss.org/browse/WFLY-7717
Project: WildFly
Issue Type: Bug
Reporter: Radim Hatlapatka
Assignee: Jason Greene
statistics-enabled attribute is nillable but when calling undefine on it {{/subsystem=undertow:undefine-attribute(name=statistics-enabled)}}, it fails with IllegalArgumentException:
{noformat}
18:04:41,824 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 15) WFLYCTL0013: Operation ("undefine-attribute") failed - address: ([("subsystem" => "undertow")]): java.lang.IllegalArgumentException
at org.jboss.dmr.ModelValue.asBoolean(ModelValue.java:69)
at org.jboss.dmr.ModelNode.asBoolean(ModelNode.java:267)
at org.wildfly.extension.undertow.UndertowRootDefinition$1.applyUpdateToRuntime(UndertowRootDefinition.java:194)
at org.jboss.as.controller.AbstractWriteAttributeHandler$1.execute(AbstractWriteAttributeHandler.java:104)
at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:921)
at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:664)
at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:383)
at org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1364)
at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:416)
at org.jboss.as.controller.ModelControllerImpl.lambda$execute$1(ModelControllerImpl.java:237)
at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:193)
at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:237)
at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:217)
at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.access$400(ModelControllerClientOperationHandler.java:137)
at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:161)
at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:157)
at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:212)
at org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:185)
at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:157)
at org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$1.doExecute(ManagementRequestContextImpl.java:70)
at org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$AsyncTaskRunner.run(ManagementRequestContextImpl.java:160)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
at org.jboss.threads.JBossThread.run(JBossThread.java:320)
{noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months
[JBoss JIRA] (WFLY-7574) Elytron "expressions-allowed" => true attributes
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFLY-7574?page=com.atlassian.jira.plugin.... ]
Jan Kalina reassigned WFLY-7574:
--------------------------------
Assignee: Jan Kalina
> Elytron "expressions-allowed" => true attributes
> ------------------------------------------------
>
> Key: WFLY-7574
> URL: https://issues.jboss.org/browse/WFLY-7574
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Martin Choma
> Assignee: Jan Kalina
>
> Please review these usage of "expressions-allowed" => true
> * class names and module names
> {code}
> /custom-role-mapper/module
> /custom-role-mapper/class-name
> /constant-permission-mapper/module
> /constant-permission-mapper/class-name
> /simple-permission-mapper/permission-mappings/module
> /simple-permission-mapper/permission-mappings/class-name
> /custom-permission-mapper/module
> /custom-permission-mapper/class-name
> /custom-name-rewriter/module
> /custom-name-rewriter/class-name
> /custom-principal-decoder/module
> /custom-principal-decoder/class-name
> /custom-realm-mapper/module
> /custom-realm-mapper/class-name
> /service-loader-http-server-mechanism-factory/module
> /service-loader-sasl-server-factory/module
> /custom-modifiable-realm/module
> /custom-modifiable-realm/class-name
> /custom-credential-security-factory/module
> /custom-credential-security-factory/class-name
> /custom-role-decoder/module
> /custom-role-decoder/class-name
> /custom-realm/module
> /custom-realm/class-name
> {code}
> Brian: "Traditionally we also don't allow expressions on attributes whose values are classnames or module names
> TBH there is no great reason for that, beyond a feeling that it will allow greater flexibility for future changes at little practical cost
> but it's what we've done and we might as well stick to it"
> * referencing another services
> {code}
> /sasl-authentication-factory/mechanism-configurations/mechanism-realm-configurations
> /http-authentication-factory/mechanism-configurations/mechanism-realm-configurations
> /ldap-key-store/dir-context
> /server-ssl-context/provider-loader
> /client-ssl-context/provider-loader
> /filtering-key-store/key-store
> /dir-context/ssl-context
> /ldap-realm/dir-context
> /trust-managers/key-store
> /trust-managers/provider-loader
> /key-managers/key-store
> /key-managers/provider-loader
> /credential-store/relative-to
> /credential-store/provider-loader
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months
[JBoss JIRA] (ELY-751) Coverity static analysis: Explicit null dereferenced in LdapKeyStore (Elytron)
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-751?page=com.atlassian.jira.plugin.sy... ]
Jan Kalina updated ELY-751:
---------------------------
Comment: was deleted
(was: I think you can put anything into type - it is not used on any other place
maybe lets just put "new LdapKeyStore(spi, null, "LdapRealm");" instead (for example))
> Coverity static analysis: Explicit null dereferenced in LdapKeyStore (Elytron)
> ------------------------------------------------------------------------------
>
> Key: ELY-751
> URL: https://issues.jboss.org/browse/ELY-751
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Josef Cacek
> Assignee: Ilia Vassilev
> Priority: Critical
> Labels: static_analysis
>
> Coverity static-analysis scan found possible use of null object in {{LdapKeyStore}} constructor.
> https://scan7.coverity.com/reports.htm#v16159/p11778/fileInstanceId=57601...
> The {{LdapKeyStore.Builder.build()}} method constructs the {{LdapKeyStore}} instance this way:
> {code}
> return new LdapKeyStore(spi, null, null);
> {code}
> and the constructor just calls parent ctor:
> {code}
> protected LdapKeyStore(KeyStoreSpi keyStoreSpi, Provider provider, String type) {
> super(keyStoreSpi, provider, type);
> }
> {code}
> And it fails with NPE if debug for {{KeyStore}} is enabled as the constructor contains:
> {code}
> if (!skipDebug && pdebug != null) {
> pdebug.println("KeyStore." + type.toUpperCase() + " type from: " +
> this.provider.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months
[JBoss JIRA] (WFCORE-2077) OutOfMemoryError: Metaspace after several client calls
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2077?page=com.atlassian.jira.plugi... ]
Brian Stansberry moved JBEAP-7601 to WFCORE-2077:
-------------------------------------------------
Project: WildFly Core (was: JBoss Enterprise Application Platform)
Key: WFCORE-2077 (was: JBEAP-7601)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Domain Management
(was: Domain Management)
Affects Version/s: 3.0.0.Alpha13
(was: 7.1.0.DR9)
Affects Testing: (was: Regression)
> OutOfMemoryError: Metaspace after several client calls
> ------------------------------------------------------
>
> Key: WFCORE-2077
> URL: https://issues.jboss.org/browse/WFCORE-2077
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha13
> Reporter: Petr Kremensky
> Assignee: Brian Stansberry
> Priority: Blocker
>
> I saw some java.lang.OutOfMemoryError: Metaspace in our AS-Testsuite runs. Here is a really simple (and clumsy) reproducer for the leak.
> *repreduce*
> {noformat}
> # lower the metaspace size in jboss-eap-7.1/bin/standalone.conf to
> # -XX:MaxMetaspaceSize=64m
> # start standalone
> ./jboss-eap-7.1/bin/standalone.sh
> # run the following loop (any other mgmt operation should serve the same)
> for i in `seq 1 1000` ; do ./jboss-eap-7.1/bin/jboss-cli.sh -c :read-resource ; done
> # wait for OOM
> {noformat}
> {noformat}
> 14:24:29,629 WARN [org.jboss.modules] (MSC service thread 1-3) Failed to define class io.undertow.security.impl.SimpleNonceManager in Module "io.undertow.core:main" from local module loader @629f0666 (finder: local module finder @1bc6a36e (roots: /home/pkremens/workspace/jboss-eap-7.1/modules,/home/pkremens/workspace/jboss-eap-7.1/modules/system/layers/base)): java.lang.OutOfMemoryError: Metaspace
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at org.jboss.modules.ModuleClassLoader.doDefineOrLoadClass(ModuleClassLoader.java:359)
> at org.jboss.modules.ModuleClassLoader.defineClass(ModuleClassLoader.java:438)
> at org.jboss.modules.ModuleClassLoader.loadClassLocal(ModuleClassLoader.java:275)
> at org.jboss.modules.ModuleClassLoader$1.loadClassLocal(ModuleClassLoader.java:79)
> at org.jboss.modules.Module.loadModuleClass(Module.java:612)
> at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:191)
> at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:377)
> at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:365)
> at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:94)
> at org.jboss.as.domain.http.server.security.LogoutHandler.<init>(LogoutHandler.java:76)
> at org.jboss.as.domain.http.server.ManagementHttpServer.addLogoutHandler(ManagementHttpServer.java:316)
> at org.jboss.as.domain.http.server.ManagementHttpServer.setupOpenListener(ManagementHttpServer.java:395)
> at org.jboss.as.domain.http.server.ManagementHttpServer.create(ManagementHttpServer.java:271)
> at org.jboss.as.domain.http.server.ManagementHttpServer.access$2400(ManagementHttpServer.java:107)
> at org.jboss.as.domain.http.server.ManagementHttpServer$Builder.build(ManagementHttpServer.java:589)
> at org.jboss.as.server.mgmt.UndertowHttpManagementService.start(UndertowHttpManagementService.java:292)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1963)
> at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1896)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months
[JBoss JIRA] (ELY-751) Coverity static analysis: Explicit null dereferenced in LdapKeyStore (Elytron)
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-751?page=com.atlassian.jira.plugin.sy... ]
Jan Kalina commented on ELY-751:
--------------------------------
I think you can put anything into type - it is not used on any other place
maybe lets just put "new LdapKeyStore(spi, null, "LdapRealm");" instead (for example)
> Coverity static analysis: Explicit null dereferenced in LdapKeyStore (Elytron)
> ------------------------------------------------------------------------------
>
> Key: ELY-751
> URL: https://issues.jboss.org/browse/ELY-751
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Josef Cacek
> Assignee: Ilia Vassilev
> Priority: Critical
> Labels: static_analysis
>
> Coverity static-analysis scan found possible use of null object in {{LdapKeyStore}} constructor.
> https://scan7.coverity.com/reports.htm#v16159/p11778/fileInstanceId=57601...
> The {{LdapKeyStore.Builder.build()}} method constructs the {{LdapKeyStore}} instance this way:
> {code}
> return new LdapKeyStore(spi, null, null);
> {code}
> and the constructor just calls parent ctor:
> {code}
> protected LdapKeyStore(KeyStoreSpi keyStoreSpi, Provider provider, String type) {
> super(keyStoreSpi, provider, type);
> }
> {code}
> And it fails with NPE if debug for {{KeyStore}} is enabled as the constructor contains:
> {code}
> if (!skipDebug && pdebug != null) {
> pdebug.println("KeyStore." + type.toUpperCase() + " type from: " +
> this.provider.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months
[JBoss JIRA] (WFLY-7715) wildfly-service.exe and jbosspass wrong with # inside
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-7715?page=com.atlassian.jira.plugin.... ]
Brian Stansberry reassigned WFLY-7715:
--------------------------------------
Component/s: Scripts
Assignee: Tomaz Cerar (was: Jason Greene)
> wildfly-service.exe and jbosspass wrong with # inside
> -----------------------------------------------------
>
> Key: WFLY-7715
> URL: https://issues.jboss.org/browse/WFLY-7715
> Project: WildFly
> Issue Type: Bug
> Components: Scripts
> Reporter: Seb Dk
> Assignee: Tomaz Cerar
>
> Hi there,
>
> I am installing wildfy 10.1.0 as service on a win 20012 server.
> It is working but I cannot stop the service.
> I figured out where the problem is coming from.
>
> When I installe Wildly as a service, I run the following command:
> E:\Products\wildfly-10.1.0.Final\bin\service>service.bat install /serviceuser .\JBoss /servicepass my#pass /controller localhost:9991 /jbossuser myuser /jbosspass *my#pass*
>
> But I can see whe I am trying to stop the service, the command running is:
> E:\Products\wildfly-10.1.0.Final\bin\jboss-cli.bat --controller=localhost:9991 --connect --user=myuser --password=*my" "pass* --command=:shutdown
>
> Any workaround?
>
> Thanks,
>
> S.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months
[JBoss JIRA] (WFLY-7587) Complicated failure-description for referral-mode in Elytron dir-context
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFLY-7587?page=com.atlassian.jira.plugin.... ]
Darran Lofthouse updated WFLY-7587:
-----------------------------------
Fix Version/s: 11.0.0.Alpha1
> Complicated failure-description for referral-mode in Elytron dir-context
> ------------------------------------------------------------------------
>
> Key: WFLY-7587
> URL: https://issues.jboss.org/browse/WFLY-7587
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Labels: user_experience
> Fix For: 11.0.0.Alpha1
>
>
> In case when attribute {{referral-mode}} is added to {{dir-context}} with wrong value then failure-description includes IllegalArgumentException instead of some non-Java admin friendly description:
> {code}
> /subsystem=elytron/dir-context=dirContext:add(url=localhost,referral-mode=abc)
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.IllegalArgumentException: No enum constant org.wildfly.security.auth.realm.ldap.DirContextFactory.ReferralMode.abc",
> "rolled-back" => true
> }
> {code}
> Suggestion for improvement:
> Use the same type of failure-description as e.g. {{logical-role-mapper}}, see:
> {code}
> /subsystem=elytron/logical-role-mapper=logicalRoleMapper:add(logical-operation=abc)
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0248: Invalid value abc for logical-operation; legal values are [OR, AND, XOR, MINUS]",
> "rolled-back" => true
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months
[JBoss JIRA] (WFLY-7587) Complicated failure-description for referral-mode in Elytron dir-context
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFLY-7587?page=com.atlassian.jira.plugin.... ]
Darran Lofthouse updated WFLY-7587:
-----------------------------------
Affects Version/s: (was: 11.0.0.Alpha1)
> Complicated failure-description for referral-mode in Elytron dir-context
> ------------------------------------------------------------------------
>
> Key: WFLY-7587
> URL: https://issues.jboss.org/browse/WFLY-7587
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Labels: user_experience
>
> In case when attribute {{referral-mode}} is added to {{dir-context}} with wrong value then failure-description includes IllegalArgumentException instead of some non-Java admin friendly description:
> {code}
> /subsystem=elytron/dir-context=dirContext:add(url=localhost,referral-mode=abc)
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.IllegalArgumentException: No enum constant org.wildfly.security.auth.realm.ldap.DirContextFactory.ReferralMode.abc",
> "rolled-back" => true
> }
> {code}
> Suggestion for improvement:
> Use the same type of failure-description as e.g. {{logical-role-mapper}}, see:
> {code}
> /subsystem=elytron/logical-role-mapper=logicalRoleMapper:add(logical-operation=abc)
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0248: Invalid value abc for logical-operation; legal values are [OR, AND, XOR, MINUS]",
> "rolled-back" => true
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 4 months