May 2017 - jboss-jira - Jboss List Archives

[JBoss JIRA] (DROOLS-1531) Fix instanceof accordingly to FEEL spec table 49 and InstanceOfNode

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1531?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1531: ---------------------------------- Affects Version/s: 7.0.0.CR3 > Fix instanceof accordingly to FEEL spec table 49 and InstanceOfNode > ------------------------------------------------------------------- > > Key: DROOLS-1531 > URL: https://issues.jboss.org/browse/DROOLS-1531 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.CR3 > Reporter: Matteo Mortari > Assignee: Matteo Mortari > Priority: Minor > Fix For: 7.1.0.Final > > > From FEEL specification table 49: > bq. Type-checking is defined in Table 49. Note that type is not mapped to the domain, and null is not the name of a type, and null is not an instance of any type. > Also InstanceOfNode needs alignment to new interface methods available. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1531) Fix instanceof accordingly to FEEL spec table 49 and InstanceOfNode

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1531?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1531: ---------------------------------- Component/s: dmn engine > Fix instanceof accordingly to FEEL spec table 49 and InstanceOfNode > ------------------------------------------------------------------- > > Key: DROOLS-1531 > URL: https://issues.jboss.org/browse/DROOLS-1531 > Project: Drools > Issue Type: Bug > Components: dmn engine > Reporter: Matteo Mortari > Assignee: Matteo Mortari > Priority: Minor > > From FEEL specification table 49: > bq. Type-checking is defined in Table 49. Note that type is not mapped to the domain, and null is not the name of a type, and null is not an instance of any type. > Also InstanceOfNode needs alignment to new interface methods available. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1543) DMN ItemDefinition dependencies ordering

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1543?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1543: ---------------------------------- Component/s: dmn engine > DMN ItemDefinition dependencies ordering > ---------------------------------------- > > Key: DROOLS-1543 > URL: https://issues.jboss.org/browse/DROOLS-1543 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.CR3 > Reporter: Matteo Mortari > Assignee: Matteo Mortari > Fix For: 7.1.0.Final > > > Using Java-api Comparator is not easily suitable to address the problem of ordering the ItemDefinition by their dependencies. > If the Comparator is used to check purely for dependencies, returning 0 for indipendent elements, assume the following: > {code:java} > X > Y -> Z > {code} > where X is independent from Y, Z; and Y depends on Z. > {code:java} > compare(X, Y) == 0 // by definition above > compare(X, Z) == 0 // still, by definition above, X is independent also from Z > compare(Y, Z) == 1 // because Y depends on Z, Y is bigger than Z. > {code} > The above breaks the API contract in the Java-API Comparator where stating: > {quote}Finally, the implementor must ensure that compare(x, y)==0 implies that sgn(compare(x, z))==sgn(compare(y, z)) for all z.{quote} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1543) DMN ItemDefinition dependencies ordering

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1543?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1543: ---------------------------------- Fix Version/s: 7.1.0.Final > DMN ItemDefinition dependencies ordering > ---------------------------------------- > > Key: DROOLS-1543 > URL: https://issues.jboss.org/browse/DROOLS-1543 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.CR3 > Reporter: Matteo Mortari > Assignee: Matteo Mortari > Fix For: 7.1.0.Final > > > Using Java-api Comparator is not easily suitable to address the problem of ordering the ItemDefinition by their dependencies. > If the Comparator is used to check purely for dependencies, returning 0 for indipendent elements, assume the following: > {code:java} > X > Y -> Z > {code} > where X is independent from Y, Z; and Y depends on Z. > {code:java} > compare(X, Y) == 0 // by definition above > compare(X, Z) == 0 // still, by definition above, X is independent also from Z > compare(Y, Z) == 1 // because Y depends on Z, Y is bigger than Z. > {code} > The above breaks the API contract in the Java-API Comparator where stating: > {quote}Finally, the implementor must ensure that compare(x, y)==0 implies that sgn(compare(x, z))==sgn(compare(y, z)) for all z.{quote} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1543) DMN ItemDefinition dependencies ordering

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1543?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1543: ---------------------------------- Affects Version/s: 7.0.0.CR3 > DMN ItemDefinition dependencies ordering > ---------------------------------------- > > Key: DROOLS-1543 > URL: https://issues.jboss.org/browse/DROOLS-1543 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.CR3 > Reporter: Matteo Mortari > Assignee: Matteo Mortari > Fix For: 7.1.0.Final > > > Using Java-api Comparator is not easily suitable to address the problem of ordering the ItemDefinition by their dependencies. > If the Comparator is used to check purely for dependencies, returning 0 for indipendent elements, assume the following: > {code:java} > X > Y -> Z > {code} > where X is independent from Y, Z; and Y depends on Z. > {code:java} > compare(X, Y) == 0 // by definition above > compare(X, Z) == 0 // still, by definition above, X is independent also from Z > compare(Y, Z) == 1 // because Y depends on Z, Y is bigger than Z. > {code} > The above breaks the API contract in the Java-API Comparator where stating: > {quote}Finally, the implementor must ensure that compare(x, y)==0 implies that sgn(compare(x, z))==sgn(compare(y, z)) for all z.{quote} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1548) Fix bug with filter selection operator

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1548?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1548: ---------------------------------- Attachment: Ex_6_1.dmn > Fix bug with filter selection operator > -------------------------------------- > > Key: DROOLS-1548 > URL: https://issues.jboss.org/browse/DROOLS-1548 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.CR3 > Reporter: Edson Tirelli > Assignee: Edson Tirelli > Fix For: 7.1.0.Final > > Attachments: Ex_6_1.dmn > > > The attached model is not completely working. This is likely to the fact that the filter selection operator is not working. E.g.: > {code} > max( NBA Pacific.wins ) > {code} > Should return the team with the most wins in the {{NBA Pacific}} list of teams. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1548) Fix bug with filter selection operator

by Edson Tirelli (JIRA)

Edson Tirelli created DROOLS-1548: ------------------------------------- Summary: Fix bug with filter selection operator Key: DROOLS-1548 URL: https://issues.jboss.org/browse/DROOLS-1548 Project: Drools Issue Type: Bug Components: dmn engine Affects Versions: 7.0.0.CR3 Reporter: Edson Tirelli Assignee: Edson Tirelli Fix For: 7.1.0.Final Attachments: Ex_6_1.dmn The attached model is not completely working. This is likely to the fact that the filter selection operator is not working. E.g.: {code} max( NBA Pacific.wins ) {code} Should return the team with the most wins in the {{NBA Pacific}} list of teams. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1547) Add tests to confirm that singleton lists can be treated as the element itself in filter results

by Edson Tirelli (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1547?page=com.atlassian.jira.plugi... ] Edson Tirelli updated DROOLS-1547: ---------------------------------- Description: The specification has a provision that singleton lists should be treated as the element itself in some cases, like filter results. I.e., in some cases, {{[a] = a}}. This is not completely consistent, but we need to handle it for some cases, like filter results. In other words, the following assignment should work fine, assuming {{a flight}} is a flight variable and {{flight list}} is a list of flights, and the filter returns a single result. {code} { a flight : flight list[ number = "AC 531" ] } {code} We need to add tests to make sure it is working like that and fix it in case it is not. was: The specification has a provision that singleton lists should be treated as the element itself in some cases, like filter results. I.e., in some cases, {{[a] = a}}. This is not completely consistent, but we need to handle it for some cases, like filter results. In other words, the following assignment should work fine, assuming {{a flight}} is a flight variable and {{flight list}} is a list of flights, and the filter returns a single result. { a flight : flight list[ number = "AC 531" ] } We need to add tests to make sure it is working like that and fix it in case it is not. > Add tests to confirm that singleton lists can be treated as the element itself in filter results > ------------------------------------------------------------------------------------------------ > > Key: DROOLS-1547 > URL: https://issues.jboss.org/browse/DROOLS-1547 > Project: Drools > Issue Type: Bug > Components: dmn engine > Affects Versions: 7.0.0.CR3 > Reporter: Edson Tirelli > Assignee: Edson Tirelli > Fix For: 7.1.0.Final > > > The specification has a provision that singleton lists should be treated as the element itself in some cases, like filter results. I.e., in some cases, {{[a] = a}}. > This is not completely consistent, but we need to handle it for some cases, like filter results. In other words, the following assignment should work fine, assuming {{a flight}} is a flight variable and {{flight list}} is a list of flights, and the filter returns a single result. > {code} > { > a flight : flight list[ number = "AC 531" ] > } > {code} > We need to add tests to make sure it is working like that and fix it in case it is not. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1547) Add tests to confirm that singleton lists can be treated as the element itself in filter results

by Edson Tirelli (JIRA)

Edson Tirelli created DROOLS-1547: ------------------------------------- Summary: Add tests to confirm that singleton lists can be treated as the element itself in filter results Key: DROOLS-1547 URL: https://issues.jboss.org/browse/DROOLS-1547 Project: Drools Issue Type: Bug Components: dmn engine Affects Versions: 7.0.0.CR3 Reporter: Edson Tirelli Assignee: Edson Tirelli Fix For: 7.1.0.Final The specification has a provision that singleton lists should be treated as the element itself in some cases, like filter results. I.e., in some cases, {{[a] = a}}. This is not completely consistent, but we need to handle it for some cases, like filter results. In other words, the following assignment should work fine, assuming {{a flight}} is a flight variable and {{flight list}} is a list of flights, and the filter returns a single result. { a flight : flight list[ number = "AC 531" ] } We need to add tests to make sure it is working like that and fix it in case it is not. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

[JBoss JIRA] (DROOLS-1546) Improve FEEL tests to check for errors to prevent regressions

by Edson Tirelli (JIRA)

Edson Tirelli created DROOLS-1546: ------------------------------------- Summary: Improve FEEL tests to check for errors to prevent regressions Key: DROOLS-1546 URL: https://issues.jboss.org/browse/DROOLS-1546 Project: Drools Issue Type: Bug Components: dmn engine Affects Versions: 7.0.0.CR3 Reporter: Edson Tirelli Assignee: Edson Tirelli Fix For: 7.1.0.Final At the moment, FEEL tests ignore errors raised by the engine. We need to add proper checks for that to prevent future regressions. This task should be mostly about fixing the current tests, but we may uncover bugs while going through it. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

9 years

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira May 2017