[JBoss JIRA] (ELY-770) Review SASL mechanism handling of isComplete()
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-770?page=com.atlassian.jira.plugin.sy... ]
Darran Lofthouse resolved ELY-770.
----------------------------------
Resolution: Rejected
> Review SASL mechanism handling of isComplete()
> ----------------------------------------------
>
> Key: ELY-770
> URL: https://issues.jboss.org/browse/ELY-770
> Project: WildFly Elytron
> Issue Type: Task
> Components: SASL
> Reporter: Darran Lofthouse
> Priority: Critical
> Fix For: 1.1.0.CR2
>
>
> The javadoc of the isComplete() method states: -
> _Determines whether the authentication exchange has completed. This method is typically called after each invocation of evaluateResponse() to determine whether the authentication has completed successfully or should be continued._
> Also getAuthorizationID() states: -
> _Reports the authorization ID in effect for the client of this session. This method can only be called if isComplete() returns true.
> _
> Although the former is very vague there just seem to be a suggestion that complete means successfully complete, our mechs are setting complete very early and other wrappers such as AuthenticationCompleteCallbackSaslServerFactory are using complete as a flag to report failures.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (ELY-929) AuthenticationConfiguration uniqueness enhancements
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-929?page=com.atlassian.jira.plugin.sy... ]
Darran Lofthouse commented on ELY-929:
--------------------------------------
Is this one we need to keep around or can we close it?
> AuthenticationConfiguration uniqueness enhancements
> ---------------------------------------------------
>
> Key: ELY-929
> URL: https://issues.jboss.org/browse/ELY-929
> Project: WildFly Elytron
> Issue Type: Enhancement
> Components: Authentication Client
> Reporter: David Lloyd
> Assignee: David Lloyd
> Fix For: 1.1.0.CR2
>
>
> Apply some enhancements to AuthenticationConfiguration uniqueness.
> * Add admonishing JavaDoc to {{useCallbackHandler}} to point out the importance of per-identity uniqueness of the callback handler
> The following also may be possible and useful:
> * Modify the {{AuthenticationConfiguration}} process to capture instances for {{Supplier}}-driven components at the time the configuration is used via the {{AuthenticationContextConfigurationClient}}
> * Add a variation of {{useCallbackHandler}} which accepts a {{Supplier<CallbackHandler>}}, or a {{Function<T, CallbackHandler}} and a {{T}}, allowing constructor refs to be given
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (ELY-889) Add a filtering RoleMapper implementation.
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-889?page=com.atlassian.jira.plugin.sy... ]
Darran Lofthouse updated ELY-889:
---------------------------------
Fix Version/s: 1.2.0.Beta1
(was: 1.1.0.CR2)
> Add a filtering RoleMapper implementation.
> ------------------------------------------
>
> Key: ELY-889
> URL: https://issues.jboss.org/browse/ELY-889
> Project: WildFly Elytron
> Issue Type: Feature Request
> Components: Utils
> Reporter: Darran Lofthouse
> Fix For: 1.2.0.Beta1
>
>
> The RoleMapper APIs are built around querying one role at a time, however at times it may be desirable to obtain a set of roles an identity is a member of.
> To avoid iterating every role which depending on the configuration could be thousands backed by a remote store we should have a FilteringRoleMapper implementation that will allow any checks and iteration of the roles to be restricted to a finite set of acceptable roles.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months
[JBoss JIRA] (ELY-873) AuthenticationClient testing without jboss-modules
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-873?page=com.atlassian.jira.plugin.sy... ]
Darran Lofthouse updated ELY-873:
---------------------------------
Fix Version/s: 1.2.0.Beta1
(was: 1.1.0.CR2)
> AuthenticationClient testing without jboss-modules
> --------------------------------------------------
>
> Key: ELY-873
> URL: https://issues.jboss.org/browse/ELY-873
> Project: WildFly Elytron
> Issue Type: Enhancement
> Components: Authentication Client, Testsuite
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Fix For: 1.2.0.Beta1
>
>
> Keeping AuthenticationClient usable without a dependency on JBoss Modules is the kind of thing that will be easy to break.
> We should probably have a matrix of tests verifying AuthenticationClient anyway, we should then repeat the tests without JBoss Modules on the ClassPath.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 6 months