[JBoss JIRA] (DROOLS-2254) Automate .proto files rebuild in pom.xml
by Michael Biarnes Kiefer (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2254?page=com.atlassian.jira.plugi... ]
Michael Biarnes Kiefer updated DROOLS-2254:
-------------------------------------------
Fix Version/s: 7.9.0.Final
(was: 7.8.0.Final)
> Automate .proto files rebuild in pom.xml
> ----------------------------------------
>
> Key: DROOLS-2254
> URL: https://issues.jboss.org/browse/DROOLS-2254
> Project: Drools
> Issue Type: Task
> Components: tools
> Affects Versions: 7.5.0.Final
> Reporter: Dmitry Volodin
> Assignee: Dmitry Volodin
> Priority: Minor
> Fix For: 7.9.0.Final
>
>
> According to contribution guide, any .proto file or protobuf version changes it's necessary to download protoc utility and regenerate Java classes based on .proto files.
> This will add automation for downloading protoc utility and Java classes generation based on Maven Protocol Buffers Plugin. There is no timestamps and other build related info inside generated Java files and no changes will be added on each new build.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (DROOLS-2549) [DMN Designer] Add support for 'parent' to DMNModelInstrumentedBase
by Michael Biarnes Kiefer (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2549?page=com.atlassian.jira.plugi... ]
Michael Biarnes Kiefer updated DROOLS-2549:
-------------------------------------------
Fix Version/s: 7.9.0.Final
(was: 7.8.0.Final)
> [DMN Designer] Add support for 'parent' to DMNModelInstrumentedBase
> -------------------------------------------------------------------
>
> Key: DROOLS-2549
> URL: https://issues.jboss.org/browse/DROOLS-2549
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.7.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Fix For: 7.9.0.Final
>
>
> {{DMNModelInstrumentedBase}} needs to support {{parent}} (like {{org.kie.dmn.model.v1_1.DMNModelInstrumentedBase}}) in order to correctly implement {{getPrefixForNamespaceURI(..)}} that is needed to set the {{QName}} prefix when setting data-types on nodes.
> At the moment the {{QName}} for data-types in the UI is using the {{namespaceURI}} instead of the {{prefix}} as it is currently impossible to lookup a {{prefix}} from the {{namespaceURI}} (of the nodes' parents up to {{Definitions}}).
> Changes required for this JIRA (split into sub-tasks when work starts):-
> * Update XML->(kie)DMN->(ui)DMN model mapping in the marshaller
> * Update the UI to set {{parent}} when adding nodes to the {{DRGElement}} and children
> * Update code relating to "setting data-type" to lookup {{prefix}} for {{QName}} (/)
> * When creating a new Diagram we need to set up the basic default NameSpace contexts on the {{DMNDiagram}}'s {{Defintions}} (/)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (JGRP-2227) Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
by Robert Cernak (JIRA)
[ https://issues.jboss.org/browse/JGRP-2227?page=com.atlassian.jira.plugin.... ]
Robert Cernak commented on JGRP-2227:
-------------------------------------
Sorry, my fault. I sent you original version of AbstractInfinityAuthToken class which I was using before. For testing reasons I changed it now to following:
{code:java}
public boolean authenticate(final AuthToken token, final Message arg1) {
return false;
}
{code}
With this version of authenticate method I did not receive exception you are showing. I did not catch any exception at all. I observed, that jgroups communication channels are being started when I start infinispan cache, so my catch block was following:
{code:java}
Cache<Object, Object> cache;
try{
cache = cacheManager.getCache(cacheName);
} catch (Exception e) {
System.out.println("Here should I catch SecurityException");
}
//cacheManager is org.infinispan.manager.DefaultCacheManager
{code}
After executing this line in try block, I see that authenticate method is being called with only line "return false". But no exception is thrown and I get fully functional instance of cache.
> Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
> -----------------------------------------------------------------------------------------------------------------
>
> Key: JGRP-2227
> URL: https://issues.jboss.org/browse/JGRP-2227
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.0.6
> Reporter: Robert Cernak
> Assignee: Bela Ban
> Fix For: 4.0.12
>
> Attachments: jgroupsDoesNotThrowSecurityExceptionWithJgroups4012.zip, jgroupsLogs.zip
>
>
> I implemented method org.jgroups.auth.AuthToken#authenticate(AuthToken token, Message msg) in my class and its body contained only one line: return false;
> In this way authentication should be false and I should get SecurityException.
> When I started joining of nodes together to form a cluster, instead of getting SecurityException, nodes formed 2 different clusters with the same name.
> I am sure method was evaluated, since I tried to run it also with breakpoint, which was triggered during joining process.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (JGRP-2227) Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2227?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2227:
--------------------------------
I don't know about Infinispan; perhaps they catch the Exception and swallow (and/or log) it.
> Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
> -----------------------------------------------------------------------------------------------------------------
>
> Key: JGRP-2227
> URL: https://issues.jboss.org/browse/JGRP-2227
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.0.6
> Reporter: Robert Cernak
> Assignee: Bela Ban
> Fix For: 4.0.12
>
> Attachments: jgroupsDoesNotThrowSecurityExceptionWithJgroups4012.zip, jgroupsLogs.zip
>
>
> I implemented method org.jgroups.auth.AuthToken#authenticate(AuthToken token, Message msg) in my class and its body contained only one line: return false;
> In this way authentication should be false and I should get SecurityException.
> When I started joining of nodes together to form a cluster, instead of getting SecurityException, nodes formed 2 different clusters with the same name.
> I am sure method was evaluated, since I tried to run it also with breakpoint, which was triggered during joining process.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (JGRP-2227) Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2227?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2227:
--------------------------------
OK, I changed this and now rethrow the SecurityException (with the cause set):
{noformat}
java.lang.SecurityException: connecting to channel draw failed
at org.jgroups.JChannel._connect(JChannel.java:901)
at org.jgroups.JChannel.connect(JChannel.java:393)
at org.jgroups.JChannel.connect(JChannel.java:384)
at org.jgroups.demos.Draw.go(Draw.java:197)
at org.jgroups.demos.Draw.main(Draw.java:160)
Caused by: java.lang.SecurityException: authentication failed
at org.jgroups.protocols.pbcast.ClientGmsImpl.isJoinResponseValid(ClientGmsImpl.java:181)
at org.jgroups.protocols.pbcast.ClientGmsImpl.installViewIfValidJoinRsp(ClientGmsImpl.java:147)
at org.jgroups.protocols.pbcast.ClientGmsImpl.joinInternal(ClientGmsImpl.java:104)
at org.jgroups.protocols.pbcast.ClientGmsImpl.join(ClientGmsImpl.java:40)
at org.jgroups.protocols.pbcast.GMS.down(GMS.java:1066)
at org.jgroups.protocols.FlowControl.down(FlowControl.java:300)
at org.jgroups.protocols.FlowControl.down(FlowControl.java:300)
at org.jgroups.protocols.FRAG3.down(FRAG3.java:135)
at org.jgroups.stack.ProtocolStack.down(ProtocolStack.java:901)
at org.jgroups.JChannel.down(JChannel.java:668)
at org.jgroups.JChannel._connect(JChannel.java:897)
... 4 more
{noformat}
> Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
> -----------------------------------------------------------------------------------------------------------------
>
> Key: JGRP-2227
> URL: https://issues.jboss.org/browse/JGRP-2227
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.0.6
> Reporter: Robert Cernak
> Assignee: Bela Ban
> Fix For: 4.0.12
>
> Attachments: jgroupsDoesNotThrowSecurityExceptionWithJgroups4012.zip, jgroupsLogs.zip
>
>
> I implemented method org.jgroups.auth.AuthToken#authenticate(AuthToken token, Message msg) in my class and its body contained only one line: return false;
> In this way authentication should be false and I should get SecurityException.
> When I started joining of nodes together to form a cluster, instead of getting SecurityException, nodes formed 2 different clusters with the same name.
> I am sure method was evaluated, since I tried to run it also with breakpoint, which was triggered during joining process.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (JGRP-2227) Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2227?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2227:
--------------------------------
I don't see where you're returning false:
{code:java}
public boolean authenticate(final AuthToken token, final Message arg1) {
if (!(token instanceof AbstractInfinityAuthToken))
return false;
final AbstractInfinityAuthToken infinityToken = (AbstractInfinityAuthToken) token;
checkMD(infinityToken.getToken().getTokenValue(), this.getToken().getTokenValue());
return infinityToken.getToken().equals(this.getToken());
}
{code}
But if I change this method to return false, the SecurityException is thrown (see below). However, the SecurityException is wrapped in a regular Exception. hmm.. perhaps I should change this...
{noformat}
{noformat}
> Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
> -----------------------------------------------------------------------------------------------------------------
>
> Key: JGRP-2227
> URL: https://issues.jboss.org/browse/JGRP-2227
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.0.6
> Reporter: Robert Cernak
> Assignee: Bela Ban
> Fix For: 4.0.12
>
> Attachments: jgroupsDoesNotThrowSecurityExceptionWithJgroups4012.zip, jgroupsLogs.zip
>
>
> I implemented method org.jgroups.auth.AuthToken#authenticate(AuthToken token, Message msg) in my class and its body contained only one line: return false;
> In this way authentication should be false and I should get SecurityException.
> When I started joining of nodes together to form a cluster, instead of getting SecurityException, nodes formed 2 different clusters with the same name.
> I am sure method was evaluated, since I tried to run it also with breakpoint, which was triggered during joining process.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months
[JBoss JIRA] (JGRP-2227) Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2227?page=com.atlassian.jira.plugin.... ]
Bela Ban edited comment on JGRP-2227 at 7/2/18 3:35 AM:
--------------------------------------------------------
I don't see where you're returning false:
{code:java}
public boolean authenticate(final AuthToken token, final Message arg1) {
if (!(token instanceof AbstractInfinityAuthToken))
return false;
final AbstractInfinityAuthToken infinityToken = (AbstractInfinityAuthToken) token;
checkMD(infinityToken.getToken().getTokenValue(), this.getToken().getTokenValue());
return infinityToken.getToken().equals(this.getToken());
}
{code}
But if I change this method to return false, the SecurityException is thrown (see below). However, the SecurityException is wrapped in a regular Exception. hmm.. perhaps I should change this...
{noformat}
java.lang.Exception: connecting to channel draw failed
at org.jgroups.JChannel._connect(JChannel.java:904)
at org.jgroups.JChannel.connect(JChannel.java:393)
at org.jgroups.JChannel.connect(JChannel.java:384)
at org.jgroups.demos.Draw.go(Draw.java:197)
at org.jgroups.demos.Draw.main(Draw.java:160)
Caused by: java.lang.SecurityException: authentication failed
at org.jgroups.protocols.pbcast.ClientGmsImpl.isJoinResponseValid(ClientGmsImpl.java:181)
at org.jgroups.protocols.pbcast.ClientGmsImpl.installViewIfValidJoinRsp(ClientGmsImpl.java:147)
at org.jgroups.protocols.pbcast.ClientGmsImpl.joinInternal(ClientGmsImpl.java:104)
at org.jgroups.protocols.pbcast.ClientGmsImpl.join(ClientGmsImpl.java:40)
at org.jgroups.protocols.pbcast.GMS.down(GMS.java:1066)
at org.jgroups.protocols.FlowControl.down(FlowControl.java:300)
at org.jgroups.protocols.FlowControl.down(FlowControl.java:300)
at org.jgroups.protocols.FRAG3.down(FRAG3.java:135)
at org.jgroups.stack.ProtocolStack.down(ProtocolStack.java:901)
at org.jgroups.JChannel.down(JChannel.java:668)
at org.jgroups.JChannel._connect(JChannel.java:897)
{noformat}
was (Author: belaban):
I don't see where you're returning false:
{code:java}
public boolean authenticate(final AuthToken token, final Message arg1) {
if (!(token instanceof AbstractInfinityAuthToken))
return false;
final AbstractInfinityAuthToken infinityToken = (AbstractInfinityAuthToken) token;
checkMD(infinityToken.getToken().getTokenValue(), this.getToken().getTokenValue());
return infinityToken.getToken().equals(this.getToken());
}
{code}
But if I change this method to return false, the SecurityException is thrown (see below). However, the SecurityException is wrapped in a regular Exception. hmm.. perhaps I should change this...
{noformat}
{noformat}
> Use of AUTH does not result in a SecurityException, but instead nodes create separate clusters with the same name
> -----------------------------------------------------------------------------------------------------------------
>
> Key: JGRP-2227
> URL: https://issues.jboss.org/browse/JGRP-2227
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.0.6
> Reporter: Robert Cernak
> Assignee: Bela Ban
> Fix For: 4.0.12
>
> Attachments: jgroupsDoesNotThrowSecurityExceptionWithJgroups4012.zip, jgroupsLogs.zip
>
>
> I implemented method org.jgroups.auth.AuthToken#authenticate(AuthToken token, Message msg) in my class and its body contained only one line: return false;
> In this way authentication should be false and I should get SecurityException.
> When I started joining of nodes together to form a cluster, instead of getting SecurityException, nodes formed 2 different clusters with the same name.
> I am sure method was evaluated, since I tried to run it also with breakpoint, which was triggered during joining process.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 6 months