[JBoss JIRA] Created: (JGRP-457) Optimization: make threads return immediately if NAKACK has another active thread for the same sender
                                
                                
                                
                                    
                                        by Bela Ban (JIRA)
                                    
                                
                                
                                        Optimization: make threads return immediately if NAKACK has another active thread for the same sender
-----------------------------------------------------------------------------------------------------
                 Key: JGRP-457
                 URL: http://jira.jboss.com/jira/browse/JGRP-457
             Project: JGroups
          Issue Type: Feature Request
            Reporter: Bela Ban
         Assigned To: Bela Ban
            Priority: Minor
             Fix For: 2.5
In NAKACK, when a thread places a message for sender S into the NakReceiverWindow NRW, it subsequently acquires a lock on NRW (lock by sender) and removes as many messages as possible and passes them up.
If many threads do this at the same time, all threads but one are blocked, and - when finally unblocked - usually return. This causes context switches and possibly cache flushing, so a better way would be to have the threads check whether another thread is already removing messages using a CAS operation *before* acquiring the lock.
The effect should be that no threads will wait on the lock unnecessarily, and thus fewer context switches, and more threads available to the pool.
-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
        
                                
                         
                        
                                
                                2 weeks, 3 days
                        
                        
                 
         
 
        
            
        
        
        
                
                        
                                
                                
                                        
                                
                         
                        
                                
                                
                                        
                                                
                                        
                                        
                                        [JBoss JIRA] (WFLY-10796) Warning about JSF version 'NONE' is shown in logs
                                
                                
                                
                                    
                                        by Jan Kašík (JIRA)
                                    
                                
                                
                                        
     [ https://issues.jboss.org/browse/WFLY-10796?page=com.atlassian.jira.plugin... ]
Jan Kašík updated WFLY-10796:
-----------------------------
    Description: 
Following warning is shown in log upon server start:
{code}
2018-08-02 16:13:28,487 WARN  [org.jboss.as.jsf] (MSC service thread 1-3) WFLYJSF0005: Unknown JSF version 'NONE'.  Default version 'main' will be used instead.
{code}
Seems like, that 'NONE' constant from WildFly code is somehow used instead of default 'main' value. Version 'NONE' is not specified anywhere, so this warning should not be present. From my point of view, it seems like I am trying set slot 'NONE' to be the default. But nothing like that is happening.
  was:
Following warning is shown in log upon server start:
{code}
2018-08-02 16:13:28,487 WARN  [org.jboss.as.jsf] (MSC service thread 1-3) WFLYJSF0005: Unknown JSF version 'NONE'.  Default version 'main' will be used instead.
{code}
Seems like, that 'NONE' constant from WildFly code is somehow used instead of default 'main' value. Version 'NONE' is not specified anywhere, so this warning should not be present.
> Warning about JSF version 'NONE' is shown in logs 
> --------------------------------------------------
>
>                 Key: WFLY-10796
>                 URL: https://issues.jboss.org/browse/WFLY-10796
>             Project: WildFly
>          Issue Type: Bug
>          Components: JSF
>    Affects Versions: 14.0.0.Beta2
>            Reporter: Jan Kašík
>            Assignee: Dmitrii Tikhomirov
>
> Following warning is shown in log upon server start:
> {code}
> 2018-08-02 16:13:28,487 WARN  [org.jboss.as.jsf] (MSC service thread 1-3) WFLYJSF0005: Unknown JSF version 'NONE'.  Default version 'main' will be used instead.
> {code}
> Seems like, that 'NONE' constant from WildFly code is somehow used instead of default 'main' value. Version 'NONE' is not specified anywhere, so this warning should not be present. From my point of view, it seems like I am trying set slot 'NONE' to be the default. But nothing like that is happening.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
                                
                         
                        
                                
                                1 month, 1 week
                        
                        
                 
         
 
        
            
        
        
        
            
        
        
        
            
        
        
        
            
        
        
        
            
        
        
        
            
        
        
        
            
        
        
        
                
                        
                                
                                
                                        
                                
                         
                        
                                
                                
                                        
                                                
                                        
                                        
                                        [JBoss JIRA] (WFLY-10912) CodecSessionConfig#findSessionId() causes an incorrect JSESSIONID Set-Cookie header
                                
                                
                                
                                    
                                        by Paul Ferraro (JIRA)
                                    
                                
                                
                                        
    [ https://issues.jboss.org/browse/WFLY-10912?page=com.atlassian.jira.plugin... ] 
Paul Ferraro commented on WFLY-10912:
-------------------------------------
[~mmiura] I'm not sure I agree with the premise of this jira.
The CodecSessionConfig is responsible for encoding/decoding the route into/from the session ID.  Thus, if you send a request containing a cookie that is missing a route, the response will contain a Set-Cookie header with a modified JSESSIONID containing the appended route.
> CodecSessionConfig#findSessionId() causes an incorrect JSESSIONID Set-Cookie header
> -----------------------------------------------------------------------------------
>
>                 Key: WFLY-10912
>                 URL: https://issues.jboss.org/browse/WFLY-10912
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 13.0.0.Final, 14.0.0.Beta2
>            Reporter: Masafumi Miura
>            Assignee: Paul Ferraro
>
> This issue is very similar to WFLY-10262/JBEAP-14641 but the condition causing the problem is a bit different.
> The issue happens when the client sends JSESSIONID Cookie in the request to the web application does NOT use HttpSession. JSESSIONID Set-Cookie response header should not be sent in this scenario, but WildFly/EAP 7 returns the response with JSESSIONID reusing the requested session id which does not exist in the session manager.
> The fix for WFLY-10262 / JBEAP-14641 added AttachmentKey SESSION_ID_SET to avoid invoking CodecSessionConfig#setSessionId() more than once. However, the fix does not help for this issue because CodecSessionConfig#setSessionId() is not invoked (= SESSION_ID_SET is null) before the problematic CodecSessionConfig#findSessionId() processing in this scenario. 
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
                                
                         
                        
                                
                                7 years, 1 month