[JBoss JIRA] (DROOLS-3398) Remove duplicated code
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3398?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3398:
-----------------------------------
Sprint: 2018 Week 48-50, 2019 Week 02-04, 2018 Week 51-01 (was: 2018 Week 48-50, 2018 Week 51-01)
> Remove duplicated code
> ----------------------
>
> Key: DROOLS-3398
> URL: https://issues.jboss.org/browse/DROOLS-3398
> Project: Drools
> Issue Type: Task
> Components: Scenario Simulation and Testing
> Reporter: Gabriele Cardosi
> Assignee: Anna Baker
> Priority: Minor
>
> During various refactoring, differente methods/implementations get duplkicated all over the code - especially inside the Command stack.
> Find and remove duplication,. eventually moving code in common/static methods
> *Specs*
> - Remove enable/disable methods from org.drools.workbench.screens.scenariosimulation.client.rightpanel.ListGroupItemView and relative implementation (ListGroupItemViewImpl) and usages because the implementation is empty
> - Cleanup org.drools.workbench.screens.scenariosimulation.client.popup.ScenarioConfirmationPopupViewTest: setup() and unused field
> - Refactor most execution logic of org.drools.workbench.screens.scenariosimulation.client.commands.actualcommands.PrependColumnCommand and org.drools.workbench.screens.scenariosimulation.client.commands.actualcommands.AppendColumnCommand to a method in a new common abstract class
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3406) [DMN Designer] Decision Service splitter should be movable
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3406?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3406:
-----------------------------------
Sprint: 2018 Week 48-50, 2019 Week 02-04, 2018 Week 51-01 (was: 2018 Week 48-50, 2018 Week 51-01)
> [DMN Designer] Decision Service splitter should be movable
> ----------------------------------------------------------
>
> Key: DROOLS-3406
> URL: https://issues.jboss.org/browse/DROOLS-3406
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
>
> The _splitter_ within a Decision Service is static.
> It needs to be movable (vertically) maintaining it's alignment with the Decision Service bounds. At this point we need to either decide to add _result_ decision(s) and _encapsulated_ decisions to the Decision Service by Command (depending on where the node is dropped) or update the Marshaller to determine the type of decision based on its vertical positioning and location of the _splitter_.
> h2. Acceptance test
> Decision state is updated according to _splitter_ movement. Example if area of result decision expanded so some decision belongs there now, this decision should have state _rusult decision_
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3373) [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3373?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3373:
-----------------------------------
Sprint: 2018 Week 48-50, 2019 Week 02-04, 2018 Week 51-01 (was: 2018 Week 48-50, 2018 Week 51-01)
> [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
> ----------------------------------------------------------------------------
>
> Key: DROOLS-3373
> URL: https://issues.jboss.org/browse/DROOLS-3373
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Brian Dellascio
> Priority: Major
> Labels: drools-tools, ux_needed
>
> We need a new "Palette" icon and Canvas shape for "Decision Services".
> See Table 1: DRD components in the [DMN 1.2 Specification|https://www.omg.org/spec/DMN/1.2/Beta1/PDF].
> See also 6.2.5 Decision service for some narrative regarding the shape.
> {quote}
> A Decision Service is represented in a DRD as rectangle with rounded corners, drawn with a heavy solid border.... the Decision Service SHALL be divided into two parts with a straight solid line.
> {quote}
> We are currently adding support for the _expanded_ form however we will also require (at some stage) a Palette glyph/icon and Canvas shape for the _collapsed_ form too.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months
[JBoss JIRA] (DROOLS-3283) Incorrect V&V results when operator is filled in the row (as opposed to column definition)
by Kris Verlaenen (Jira)
[ https://issues.jboss.org/browse/DROOLS-3283?page=com.atlassian.jira.plugi... ]
Kris Verlaenen updated DROOLS-3283:
-----------------------------------
Sprint: 2018 Week 45-47, 2018 Week 48-50, 2019 Week 02-04, 2018 Week 51-01 (was: 2018 Week 45-47, 2018 Week 48-50, 2018 Week 51-01)
> Incorrect V&V results when operator is filled in the row (as opposed to column definition)
> ------------------------------------------------------------------------------------------
>
> Key: DROOLS-3283
> URL: https://issues.jboss.org/browse/DROOLS-3283
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.14.0.Final
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools, support
>
> Imagine data model Person with attribute age.
> If you create decision table and add two columns:
> - both are defined against "age" attribute
> - none of them have operator defined
> then you add one row, and you fill in the operator and the value directly inside the row.
> For example:
> >= 20
> <= 30
> The generated DRL looks like this:
> {code:java}
> package org;
> //from row number: 1
> rule "Row 1 AnotherTest"
> dialect "mvel"
> when
> p : Person( age >= 20 , age <= 30 )
> then
> p.setAgeGroup( "whatever" );
> end
> {code}
> The V&V will report this as conflicting row:
> !6iOx.png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 5 months