[JBoss JIRA] (WFCORE-3887) Smarter range validation error messages
by Michal Petrov (Jira)
[ https://issues.jboss.org/browse/WFCORE-3887?page=com.atlassian.jira.plugi... ]
Michal Petrov reassigned WFCORE-3887:
-------------------------------------
Assignee: Michal Petrov
> Smarter range validation error messages
> ---------------------------------------
>
> Key: WFCORE-3887
> URL: https://issues.jboss.org/browse/WFCORE-3887
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Management
> Reporter: Brian Stansberry
> Assignee: Michal Petrov
> Priority: Minor
>
> A message like this is kind of silly: "Value must be between 0 and 9007199254740991".
> Smarter would be the ParameterValidator code that detects the message checking if the range max is Integer.MAX_INT (for an int) or Long.MAX_LONG (for a long) and if the bad value is below the max, just saying the equivalent of "Value must be greater than %d".
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (WFCORE-3891) Cannot create xml-formatter and json-formatter with the same name as existing resources in logging subsystem
by Michal Petrov (Jira)
[ https://issues.jboss.org/browse/WFCORE-3891?page=com.atlassian.jira.plugi... ]
Michal Petrov reassigned WFCORE-3891:
-------------------------------------
Assignee: Michal Petrov (was: James Perkins)
> Cannot create xml-formatter and json-formatter with the same name as existing resources in logging subsystem
> ------------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-3891
> URL: https://issues.jboss.org/browse/WFCORE-3891
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: Nikoleta Žiaková
> Assignee: Michal Petrov
> Priority: Major
>
> When trying to create an {{xml-formatter}} or {{json-formatter}} with the same name as another resource (e.g. a {{file-handler}}), the operation fails:
> {code}
> [standalone@localhost:9990 /] /subsystem=logging/file-handler=test:add(file={path=aaa.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/xml-formatter=test:add
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.IllegalArgumentException: No property \"dateFormat\" setter found for formatter \"test\"",
> "rolled-back" => true
> }
> {code}
> Similarly vice-versa, when trying to create another resource in logging subsystem with the same name as an {{xml-formatter}} or a {{json-formatter}}, the operation fails:
> {code}
> [standalone@localhost:9990 /] /subsystem=logging/json-formatter=test:add
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/file-handler=test:add(file={path=test.log})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.IllegalArgumentException: No property \"pattern\" setter found for formatter \"test\"",
> "rolled-back" => true
> }
> {code}
> The same scenario works for e.g. {{pattern-formatter}}:
> {code}
> [standalone@localhost:9990 /] /subsystem=logging/file-handler=test:add(file={path=test.log})
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=logging/pattern-formatter=test:add
> {"outcome" => "success"}
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (WFLY-11818) wildfly-16.0.0.Final: "From address" is no more used as default from in email
by Brian Stansberry (Jira)
[ https://issues.jboss.org/browse/WFLY-11818?page=com.atlassian.jira.plugin... ]
Brian Stansberry reassigned WFLY-11818:
---------------------------------------
Assignee: Yeray Borges (was: Tomaz Cerar)
[~yersan] Can you have a look?
Given the xml snippets in the previous comment it's clear the 'from' attribute on the mail session resource is being configured, so the simple answer is ruled out.
> wildfly-16.0.0.Final: "From address" is no more used as default from in email
> -----------------------------------------------------------------------------
>
> Key: WFLY-11818
> URL: https://issues.jboss.org/browse/WFLY-11818
> Project: WildFly
> Issue Type: Bug
> Components: Mail
> Affects Versions: 16.0.0.Final
> Environment: mvn -v
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00)
> Maven home: /apps/apache-maven-3.6.0
> Java version: 11.0.2, vendor: Oracle Corporation, runtime: /usr/java/jdk-11.0.2
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "4.12.14-lp150.12.48-default", arch: "amd64", family: "unix"
> Reporter: Wolfgang Mayer
> Assignee: Yeray Borges
> Priority: Major
>
> As mentioned in the Help (description) of 'Mail Session' configuration:
> From: *From address that is used as default from, if not set when sending*
> Apparently this is not the case anymore in wildfly-16.0.0.Final.
> For example I made a test with quickstart-16.0/mail/.
> When omitting the line
> *message.setFrom(new InternetAddress(from));*
> Sending mail fails with:
> com.sun.mail.smtp.SMTPSendFailedException: 554-Transaction failed
> 554 Unauthorized sender address.
> I have the same issue when replacing the line above with
> message.setFrom(new InternetAddress());
> I am pretty sure that this is working in wildfly-15
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (WFWIP-157) Wildfly 16 incorrect working log zip rotator
by Игорь Дмитриев (Jira)
[ https://issues.jboss.org/browse/WFWIP-157?page=com.atlassian.jira.plugin.... ]
Игорь Дмитриев updated WFWIP-157:
---------------------------------
Environment:
Windows,
Oracle JDK 8
> Wildfly 16 incorrect working log zip rotator
> --------------------------------------------
>
> Key: WFWIP-157
> URL: https://issues.jboss.org/browse/WFWIP-157
> Project: WildFly WIP
> Issue Type: Bug
> Components: Logging
> Environment: Windows,
> Oracle JDK 8
> Reporter: Игорь Дмитриев
> Assignee: James Perkins
> Priority: Major
>
> My logging profile configuration is:
> 1)
> {code:xml}
> <periodic-size-rotating-file-handler name="FILE" rotate-on-boot="false" autoflush="true">
> <level name="ALL"/>
> <file relative-to="jboss.server.log.dir" path="corp.log"/>
> <rotate-size value="300k"/>
> <max-backup-index value="10000"/>
> <suffix value=".yyyy-MM-dd.zip"/>
> <append value="true"/>
> </periodic-size-rotating-file-handler>
> {code}
> File corp.log increase it size permanently, even after new corp.log.yyyy-MM-dd.N.zip file created. Due it, each .zip archive contain same corp.log with maximum current size.
> 2)
> {code:xml}
> <periodic-size-rotating-file-handler name="FILE2" rotate-on-boot="true" autoflush="true">
> <level name="ALL"/>
> <file relative-to="jboss.server.log.dir" path="corp.log"/>
> <rotate-size value="300k"/>
> <max-backup-index value="10000"/>
> <suffix value=".yyyy-MM-dd.zip"/>
> <append value="false"/>
> </periodic-size-rotating-file-handler>
> {code}
> All work as expected, except each time corp.log reach 300k, appear pair .zip files with same content?
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (WFLY-3559) RemoteHostTrustLoginModule: HostThreadLocal seems to be unset
by Ramesh Raghavan (Jira)
[ https://issues.jboss.org/browse/WFLY-3559?page=com.atlassian.jira.plugin.... ]
Ramesh Raghavan commented on WFLY-3559:
---------------------------------------
In Wildfly 15, when using the RemoteHostTrustLoginModule it fails since HostThreadLocal is not set anywhere by Wildfly. Is the RemoteHostTrustLoginModule bundled in Wildfly no longer valid for use?
> RemoteHostTrustLoginModule: HostThreadLocal seems to be unset
> -------------------------------------------------------------
>
> Key: WFLY-3559
> URL: https://issues.jboss.org/browse/WFLY-3559
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: JBoss AS7 7.2.0.Final, 8.1.0.Final
> Reporter: Matthias Berndt
> Assignee: Darran Lofthouse
> Priority: Major
> Fix For: 11.0.0.Alpha1
>
>
> RemoteHostTrustLoginModule needs HostThreadLocal to work correctly. In 6.0 org.jboss.web.tomcat.security.RemoteHostValve was used to call org.jboss.security.plugins.HostThreadLocal#set.
>
> In 8.1 ist doesn't work and looking at the source RemoteHostValve is (of cause) gone und HostThreadLocal#set doesn't seem to be called anywhere. At least it isn't called directly in any class and debugging doesn't step into this method.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (DROOLS-3794) Inconsistent null check between JITed and non-JITed "contains"/"memberOf" condition
by Mario Fusco (Jira)
[ https://issues.jboss.org/browse/DROOLS-3794?page=com.atlassian.jira.plugi... ]
Mario Fusco updated DROOLS-3794:
--------------------------------
Sprint: (was: 2019 Week 11-13)
> Inconsistent null check between JITed and non-JITed "contains"/"memberOf" condition
> -----------------------------------------------------------------------------------
>
> Key: DROOLS-3794
> URL: https://issues.jboss.org/browse/DROOLS-3794
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.19.0.Final
> Reporter: Max Zerzouri
> Assignee: Mario Fusco
> Priority: Major
> Attachments: DroolsTest.java, drl.drl
>
>
> A condition such as {{list contains item}} or {{item memberOf list}} seems to correspond to {{EvaluatorHelper.contains(list, item)}}, but when this has been compiled through {{ASMConditionEvaluatorJitter}}, the condition includes the additional constraint, {{item != null}}. This differs to the non-JITed condition, which does not require {{item}} to be non-null.
> Attached an example {{.drl}} file as an example case, and a simple runner. Running {{java DroolsTest 14}} triggers the issue for me (resulting in an infinite loop in this case), but since the recompilation is asynchronous, it might require a larger number.
> Decompiled {{ConditionalEvaluator}} for the test case below:
> {code:java}
> import droolstest.Bar;
> import droolstest.Foo;
> import java.util.List;
> import org.drools.core.common.InternalFactHandle;
> import org.drools.core.common.InternalWorkingMemory;
> import org.drools.core.rule.Declaration;
> import org.drools.core.rule.constraint.ConditionEvaluator;
> import org.drools.core.rule.constraint.EvaluatorHelper;
> import org.drools.core.spi.Tuple;
> public class ConditionEvaluator4471f59df9b54235ba1be708b5c480da
> implements ConditionEvaluator {
> private static final String EXPRESSION = "!( foo.barNames contains name )";
> private final Declaration[] declarations;
> public boolean evaluate(InternalFactHandle internalFactHandle, InternalWorkingMemory internalWorkingMemory, Tuple tuple) {
> Tuple tuple2 = tuple;
> Foo foo = (Foo)this.declarations[0].getValue(internalWorkingMemory, tuple2.getFactHandle().getObject());
> List list = foo.getBarNames();
> String string = ((Bar)internalFactHandle.getObject()).getName();
> return !(list == null ? false : (string == null ? false : EvaluatorHelper.contains((Object)list, (Object)string)));
> }
> public ConditionEvaluator4471f59df9b54235ba1be708b5c480da(Declaration[] arrdeclaration) {
> this.declarations = arrdeclaration;
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (WFWIP-134) Bad WARN messages: AMQ222211: Storage is back to stable now...
by Miroslav Novak (Jira)
[ https://issues.jboss.org/browse/WFWIP-134?page=com.atlassian.jira.plugin.... ]
Miroslav Novak reassigned WFWIP-134:
------------------------------------
Assignee: Justin Bertram (was: Martyn Taylor)
> Bad WARN messages: AMQ222211: Storage is back to stable now...
> --------------------------------------------------------------
>
> Key: WFWIP-134
> URL: https://issues.jboss.org/browse/WFWIP-134
> Project: WildFly WIP
> Issue Type: Bug
> Components: Artemis
> Reporter: Miroslav Novak
> Assignee: Justin Bertram
> Priority: Major
>
> There are unwanted WARN messages:
> {code}
> 13:47:48,158 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 15.0.0.Alpha1-SNAPSHOT (WildFly Core 7.0.0.Alpha4) started in 8017ms - Started 495 of 723 services (489 services are lazy, passive or on-demand)
> 13:47:50,235 WARN [org.apache.activemq.artemis.core.server] (Thread-0 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@371ff371)) AMQ222183: Blocking message production on address 'jms.queue.InQueue'; size is currently: 10,635,300 bytes; max-size-bytes on address: 10,485,760, global-max-size is 10,635,300
> 13:47:52,642 WARN [org.apache.activemq.artemis.core.server] (Thread-4 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@371ff371)) AMQ222211: Storage is back to stable now, under max-disk-usage.
> 13:47:57,642 WARN [org.apache.activemq.artemis.core.server] (Thread-15 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@371ff371)) AMQ222211: Storage is back to stable now, under max-disk-usage.
> ...
> {code}
> when server has configured {{global-max-memory-size}} and address-full-policy to BLOCK. Once {{global-max-memory-size}} then starts to log above warnings which with max-disk-usage. Which is not correct as no disk limitation was reached.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (WFWIP-158) Artemis 2.7.0 logs password for STOMP protocol in clear text in debug logs
by Miroslav Novak (Jira)
[ https://issues.jboss.org/browse/WFWIP-158?page=com.atlassian.jira.plugin.... ]
Miroslav Novak edited comment on WFWIP-158 at 3/26/19 6:05 AM:
---------------------------------------------------------------
[~jbertram] This issue popped up when pre-testing Artemis 2.7.0 with Wildfly Master. Could you take a look, please?
was (Author: mnovak):
[~jbertram] This issue popped when pre-testing Artemis 2.7.0 with Wildfly Master. Could you take a look, please?
> Artemis 2.7.0 logs password for STOMP protocol in clear text in debug logs
> --------------------------------------------------------------------------
>
> Key: WFWIP-158
> URL: https://issues.jboss.org/browse/WFWIP-158
> Project: WildFly WIP
> Issue Type: Bug
> Components: Artemis
> Reporter: Miroslav Novak
> Assignee: Justin Bertram
> Priority: Major
>
> If TRACE log is enabled for {{org.apache.activemq.artemis}} then StompProtoco is logging password in clear text:
> {code}
> 13:48:06,488 DEBUG [org.apache.commons.beanutils.BeanUtils] (ServerService Thread Pool -- 86) BeanUtils.populate(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@2aa25516, {needClientAuth=tru
> e, trustStorePassword=hornetqexample, keyStorePassword=hornetqexample, port=6445, sslEnabled=true, host=127.0.0.1, trustStorePath=/home/hudson/hudson_workspace/workspace/eap-7.x-messaging-weekly-common-ssl/eap-t
> estsuite/jboss-hornetq-testsuite/tests-eap7/src/test/resources/org/jboss/qa/hornetq/test/transportprotocols/hornetq.example.truststore, keyStorePath=/home/hudson/hudson_workspace/workspace/eap-7.x-messaging-week
> ly-common-ssl/eap-testsuite/jboss-hornetq-testsuite/tests-eap7/src/test/resources/org/jboss/qa/hornetq/test/transportprotocols/hornetq.example.keystore})
> ...
> 13:48:06,488 TRACE [org.apache.commons.beanutils.BeanUtils] (ServerService Thread Pool -- 86) setProperty(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@2aa25516, trustStorePassword, horn
> etqexample)
> ...
> 13:48:06,489 TRACE [org.apache.commons.beanutils.BeanUtils] (ServerService Thread Pool -- 86) setProperty(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@2aa25516, keyStorePassword, hornet
> qexample)
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (WFWIP-158) Artemis 2.7.0 logs password for STOMP protocol in clear text in debug logs
by Miroslav Novak (Jira)
[ https://issues.jboss.org/browse/WFWIP-158?page=com.atlassian.jira.plugin.... ]
Miroslav Novak updated WFWIP-158:
---------------------------------
Steps to Reproduce:
Steps to reproduce:
{code}
git clone git@gitlab.mw.lab.eng.bos.redhat.com:jbossqe-eap/messaging-testsuite.git
cd messaging-testsuite/scripts/
groovy -DEAP_ZIP_URL=https://eap-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/eap-7.x-messaging-testing-prepare/703/artifact/jboss-eap.zip PrepareServers7.groovy
export WORKSPACE=$PWD
export JBOSS_HOME_1=$WORKSPACE/server1/jboss-eap
export JBOSS_HOME_2=$WORKSPACE/server2/jboss-eap
export JBOSS_HOME_3=$WORKSPACE/server3/jboss-eap
export JBOSS_HOME_4=$WORKSPACE/server4/jboss-eap
cd ../jboss-hornetq-testsuite/
mvn clean test -Dtest=SslAuthenticationTestCase#testClusterWithSSL -Deap7.org.jboss.qa.hornetq.apps.clients.version=7.1553519968-ehsavoie-WFLY-11876-SNAPSHOT -DfailIfNoTests=false | tee log
{code}
> Artemis 2.7.0 logs password for STOMP protocol in clear text in debug logs
> --------------------------------------------------------------------------
>
> Key: WFWIP-158
> URL: https://issues.jboss.org/browse/WFWIP-158
> Project: WildFly WIP
> Issue Type: Bug
> Components: Artemis
> Reporter: Miroslav Novak
> Assignee: Justin Bertram
> Priority: Major
>
> If TRACE log is enabled for {{org.apache.activemq.artemis}} then StompProtoco is logging password in clear text:
> {code}
> 13:48:06,488 DEBUG [org.apache.commons.beanutils.BeanUtils] (ServerService Thread Pool -- 86) BeanUtils.populate(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@2aa25516, {needClientAuth=tru
> e, trustStorePassword=hornetqexample, keyStorePassword=hornetqexample, port=6445, sslEnabled=true, host=127.0.0.1, trustStorePath=/home/hudson/hudson_workspace/workspace/eap-7.x-messaging-weekly-common-ssl/eap-t
> estsuite/jboss-hornetq-testsuite/tests-eap7/src/test/resources/org/jboss/qa/hornetq/test/transportprotocols/hornetq.example.truststore, keyStorePath=/home/hudson/hudson_workspace/workspace/eap-7.x-messaging-week
> ly-common-ssl/eap-testsuite/jboss-hornetq-testsuite/tests-eap7/src/test/resources/org/jboss/qa/hornetq/test/transportprotocols/hornetq.example.keystore})
> ...
> 13:48:06,488 TRACE [org.apache.commons.beanutils.BeanUtils] (ServerService Thread Pool -- 86) setProperty(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@2aa25516, trustStorePassword, horn
> etqexample)
> ...
> 13:48:06,489 TRACE [org.apache.commons.beanutils.BeanUtils] (ServerService Thread Pool -- 86) setProperty(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@2aa25516, keyStorePassword, hornet
> qexample)
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months