February 2020 - jboss-jira - Jboss List Archives

[JBoss JIRA] (DROOLS-5060) [DMN Designer] Editor allows node with prefix/trailing space

by Jozef Marko (Jira)

[ https://issues.redhat.com/browse/DROOLS-5060?page=com.atlassian.jira.plug... ] Jozef Marko updated DROOLS-5060: -------------------------------- Description: I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. But, imho, an UX point is not being considered, where is necessary instead. By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. Further, I consider is just the Analyst which slipped a space. In my perspective, the editor should just strip away the prefix/trailing space: * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) * While editing a DRGElement and hitting OK to save its name For your consideration, thanks. h2. Manual acceptance test - Rename a node, check undo/redo (/) - Leading space (/) - Trailing space (/) - Save and reopen (/) - Documentation tab - Rename via node popup - Rename via properties panel - Rename via expression grid - where applicable was: I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. But, imho, an UX point is not being considered, where is necessary instead. By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. Further, I consider is just the Analyst which slipped a space. In my perspective, the editor should just strip away the prefix/trailing space: * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) * While editing a DRGElement and hitting OK to save its name For your consideration, thanks. h2. Manual acceptance test - Rename a node, check undo/redo (/) - Rename node as ctrl-c/ctrl+v - Try to use \tab in the middle of the name - Leading space - Trailing space - Save and reopen (/) - Documentation tab - Rename via node popup - Rename via properties panel - Rename via expression grid - where applicable > [DMN Designer] Editor allows node with prefix/trailing space > ------------------------------------------------------------ > > Key: DROOLS-5060 > URL: https://issues.redhat.com/browse/DROOLS-5060 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Reporter: Matteo Mortari > Assignee: Michael Anstis > Priority: Major > Labels: drools-tools > Attachments: ItemDefinition-white-space.png > > > I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. > But, imho, an UX point is not being considered, where is necessary instead. > By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. > The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. > Further, I consider is just the Analyst which slipped a space. > In my perspective, the editor should just strip away the prefix/trailing space: > * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) > * While editing a DRGElement and hitting OK to save its name > For your consideration, thanks. > h2. Manual acceptance test > - Rename a node, check undo/redo (/) > - Leading space (/) > - Trailing space (/) > - Save and reopen (/) > - Documentation tab > - Rename via node popup > - Rename via properties panel > - Rename via expression grid - where applicable -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-5060) [DMN Designer] Editor allows node with prefix/trailing space

by Jozef Marko (Jira)

[ https://issues.redhat.com/browse/DROOLS-5060?page=com.atlassian.jira.plug... ] Jozef Marko updated DROOLS-5060: -------------------------------- Description: I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. But, imho, an UX point is not being considered, where is necessary instead. By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. Further, I consider is just the Analyst which slipped a space. In my perspective, the editor should just strip away the prefix/trailing space: * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) * While editing a DRGElement and hitting OK to save its name For your consideration, thanks. h2. Manual acceptance test - Rename a node, check undo/redo (/) - Rename node as ctrl-c/ctrl+v - Try to use \tab in the middle of the name - Leading space - Trailing space - Save and reopen (/) - Documentation tab - Rename via node popup - Rename via properties panel - Rename via expression grid - where applicable was: I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. But, imho, an UX point is not being considered, where is necessary instead. By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. Further, I consider is just the Analyst which slipped a space. In my perspective, the editor should just strip away the prefix/trailing space: * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) * While editing a DRGElement and hitting OK to save its name For your consideration, thanks. h2. Manual acceptance test - Rename a node, check undo/redo - Rename node as ctrl-c/ctrl+v - Try to use \tab in the middle of the name - Leading space - Trailing space - Save and reopen - Documentation tab - Rename via node popup - Rename via properties panel - Rename via expression grid - where applicable > [DMN Designer] Editor allows node with prefix/trailing space > ------------------------------------------------------------ > > Key: DROOLS-5060 > URL: https://issues.redhat.com/browse/DROOLS-5060 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Reporter: Matteo Mortari > Assignee: Michael Anstis > Priority: Major > Labels: drools-tools > Attachments: ItemDefinition-white-space.png > > > I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. > But, imho, an UX point is not being considered, where is necessary instead. > By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. > The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. > Further, I consider is just the Analyst which slipped a space. > In my perspective, the editor should just strip away the prefix/trailing space: > * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) > * While editing a DRGElement and hitting OK to save its name > For your consideration, thanks. > h2. Manual acceptance test > - Rename a node, check undo/redo (/) > - Rename node as ctrl-c/ctrl+v > - Try to use \tab in the middle of the name > - Leading space > - Trailing space > - Save and reopen (/) > - Documentation tab > - Rename via node popup > - Rename via properties panel > - Rename via expression grid - where applicable -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13164) When "corrupted" public key is supplied to server, user is not informed

by Jan Kasik (Jira)

[ https://issues.redhat.com/browse/WFLY-13164?page=com.atlassian.jira.plugi... ] Jan Kasik updated WFLY-13164: ----------------------------- Affects Testing: Regression > When "corrupted" public key is supplied to server, user is not informed > ----------------------------------------------------------------------- > > Key: WFLY-13164 > URL: https://issues.redhat.com/browse/WFLY-13164 > Project: WildFly > Issue Type: Bug > Components: MP JWT > Affects Versions: 19.0.0.Beta2, 20.0.0.Beta1 > Reporter: Jan Kasik > Assignee: Darran Lofthouse > Priority: Blocker > Attachments: CorruptedKeyTest.war > > > When corrupted public key (a valid key cannot be extracted from the string value) is supplied to JWT verifier, user is not informed since there is no error message in log and clients receives 401 status code in response instead of an error code of 500. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13164) When "corrupted" public key is supplied to server, user is not informed

by Jan Kasik (Jira)

[ https://issues.redhat.com/browse/WFLY-13164?page=com.atlassian.jira.plugi... ] Jan Kasik updated WFLY-13164: ----------------------------- Priority: Blocker (was: Major) > When "corrupted" public key is supplied to server, user is not informed > ----------------------------------------------------------------------- > > Key: WFLY-13164 > URL: https://issues.redhat.com/browse/WFLY-13164 > Project: WildFly > Issue Type: Bug > Components: MP JWT > Affects Versions: 19.0.0.Beta2, 20.0.0.Beta1 > Reporter: Jan Kasik > Assignee: Darran Lofthouse > Priority: Blocker > Attachments: CorruptedKeyTest.war > > > When corrupted public key (a valid key cannot be extracted from the string value) is supplied to JWT verifier, user is not informed since there is no error message in log and clients receives 401 status code in response instead of an error code of 500. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13164) When "corrupted" public key is supplied to server, user is not informed

by Jan Kasik (Jira)

[ https://issues.redhat.com/browse/WFLY-13164?page=com.atlassian.jira.plugi... ] Jan Kasik commented on WFLY-13164: ---------------------------------- Raising priority to blocker since this issue is a regression when compared against state when the feature was being merged. > When "corrupted" public key is supplied to server, user is not informed > ----------------------------------------------------------------------- > > Key: WFLY-13164 > URL: https://issues.redhat.com/browse/WFLY-13164 > Project: WildFly > Issue Type: Bug > Components: MP JWT > Affects Versions: 19.0.0.Beta2, 20.0.0.Beta1 > Reporter: Jan Kasik > Assignee: Darran Lofthouse > Priority: Blocker > Attachments: CorruptedKeyTest.war > > > When corrupted public key (a valid key cannot be extracted from the string value) is supplied to JWT verifier, user is not informed since there is no error message in log and clients receives 401 status code in response instead of an error code of 500. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13164) When "corrupted" public key is supplied to server, user is not informed

by Jan Kasik (Jira)

[ https://issues.redhat.com/browse/WFLY-13164?page=com.atlassian.jira.plugi... ] Jan Kasik updated WFLY-13164: ----------------------------- Affects Version/s: 20.0.0.Beta1 > When "corrupted" public key is supplied to server, user is not informed > ----------------------------------------------------------------------- > > Key: WFLY-13164 > URL: https://issues.redhat.com/browse/WFLY-13164 > Project: WildFly > Issue Type: Bug > Components: MP JWT > Affects Versions: 19.0.0.Beta2, 20.0.0.Beta1 > Reporter: Jan Kasik > Assignee: Darran Lofthouse > Priority: Major > Attachments: CorruptedKeyTest.war > > > When corrupted public key (a valid key cannot be extracted from the string value) is supplied to JWT verifier, user is not informed since there is no error message in log and clients receives 401 status code in response instead of an error code of 500. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13165) When "corrupted" public key is supplied to server, user is not informed

by Jan Kasik (Jira)

Jan Kasik created WFLY-13165: -------------------------------- Summary: When "corrupted" public key is supplied to server, user is not informed Key: WFLY-13165 URL: https://issues.redhat.com/browse/WFLY-13165 Project: WildFly Issue Type: Bug Components: MP JWT Affects Versions: 19.0.0.Beta2 Reporter: Jan Kasik Assignee: Darran Lofthouse When corrupted public key (a valid key cannot be extracted from the string value) is supplied to JWT verifier, user is not informed since there is no error message in log and clients receives 401 status code in response instead of an error code of 500. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13165) When "corrupted" public key is supplied to server, user is not informed

by Jan Kasik (Jira)

[ https://issues.redhat.com/browse/WFLY-13165?page=com.atlassian.jira.plugi... ] Jan Kasik deleted WFLY-13165: ----------------------------- > When "corrupted" public key is supplied to server, user is not informed > ----------------------------------------------------------------------- > > Key: WFLY-13165 > URL: https://issues.redhat.com/browse/WFLY-13165 > Project: WildFly > Issue Type: Bug > Reporter: Jan Kasik > Assignee: Darran Lofthouse > Priority: Major > > When corrupted public key (a valid key cannot be extracted from the string value) is supplied to JWT verifier, user is not informed since there is no error message in log and clients receives 401 status code in response instead of an error code of 500. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13164) When "corrupted" public key is supplied to server, user is not informed

by Jan Kasik (Jira)

Jan Kasik created WFLY-13164: -------------------------------- Summary: When "corrupted" public key is supplied to server, user is not informed Key: WFLY-13164 URL: https://issues.redhat.com/browse/WFLY-13164 Project: WildFly Issue Type: Bug Components: MP JWT Affects Versions: 19.0.0.Beta2 Reporter: Jan Kasik Assignee: Darran Lofthouse Attachments: CorruptedKeyTest.war When corrupted public key (a valid key cannot be extracted from the string value) is supplied to JWT verifier, user is not informed since there is no error message in log and clients receives 401 status code in response instead of an error code of 500. -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-5060) [DMN Designer] Editor allows node with prefix/trailing space

by Jozef Marko (Jira)

[ https://issues.redhat.com/browse/DROOLS-5060?page=com.atlassian.jira.plug... ] Jozef Marko updated DROOLS-5060: -------------------------------- Description: I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. But, imho, an UX point is not being considered, where is necessary instead. By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. Further, I consider is just the Analyst which slipped a space. In my perspective, the editor should just strip away the prefix/trailing space: * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) * While editing a DRGElement and hitting OK to save its name For your consideration, thanks. h2. Manual acceptance test - Rename a node, check undo/redo - Rename node as ctrl-c/ctrl+v - Try to use \tab in the middle of the name - Leading space - Trailing space - Save and reopen - Documentation tab - Rename via node popup - Rename via properties panel - Rename via expression grid - where applicable was: I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. But, imho, an UX point is not being considered, where is necessary instead. By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. Further, I consider is just the Analyst which slipped a space. In my perspective, the editor should just strip away the prefix/trailing space: * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) * While editing a DRGElement and hitting OK to save its name For your consideration, thanks. > [DMN Designer] Editor allows node with prefix/trailing space > ------------------------------------------------------------ > > Key: DROOLS-5060 > URL: https://issues.redhat.com/browse/DROOLS-5060 > Project: Drools > Issue Type: Bug > Components: DMN Editor > Reporter: Matteo Mortari > Assignee: Michael Anstis > Priority: Major > Labels: drools-tools > Attachments: ItemDefinition-white-space.png > > > I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine. > But, imho, an UX point is not being considered, where is necessary instead. > By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc. > The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO. > Further, I consider is just the Analyst which slipped a space. > In my perspective, the editor should just strip away the prefix/trailing space: > * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062]) > * While editing a DRGElement and hitting OK to save its name > For your consideration, thanks. > h2. Manual acceptance test > - Rename a node, check undo/redo > - Rename node as ctrl-c/ctrl+v > - Try to use \tab in the middle of the name > - Leading space > - Trailing space > - Save and reopen > - Documentation tab > - Rename via node popup > - Rename via properties panel > - Rename via expression grid - where applicable -- This message was sent by Atlassian Jira (v7.13.8#713008)

4 years, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira February 2020