[JBoss JIRA] (DROOLS-5046) [DMN Designer] Marshalling questions
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5046?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5046:
-----------------------------------
Sprint: 2020 Week 07-09 (from Feb 10), 2020 Week 10-12 (from Mar 2) (was: 2020 Week 07-09 (from Feb 10))
> [DMN Designer] Marshalling questions
> ------------------------------------
>
> Key: DROOLS-5046
> URL: https://issues.redhat.com/browse/DROOLS-5046
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.33.0.Final
> Reporter: Michael Anstis
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools
>
> Our marshaller is EXPLICITLY setting Definitions.typeLanguage to FEEL. Is this acceptable?
> DMN1.2 Specification "6.3.2 Definitions metamodel" states :
> An instance of Definitions MAY specify a typeLanguage, which is a URI that identifies the default type language used in elements within the scope of this Definitions ... If unspecified, the default typeLanguage is FEEL.
> So it is not wrong, but it is not necessary.
> ---------------------------------------------------------------------------------
> Our marshaller is EXPLICITLY setting ItemDefinition.id
> DMN1.2 Specification "7.3.2 - ItemDefinition metamodel" states :
> ...an instance of ItemDefinition HAS a name and an OPTIONAL id
> So it is not wrong, but it is not necessary.
> ---------------------------------------------------------------------------------
> Our marshaller IS NOT setting ContextEntry.id
> DMN1.2 Specification 10.5.2 - ContextEntry metamodel states :
> ...ContextEntry is a specialization of DMNElement, from which it INHERITS the OPTIONAL id...
> It is therefore correct for us to exclude the id (but _other tools_ includes it. Is that wrong?!)
> ---------------------------------------------------------------------------------
> Our marshaller is EXPLICITLY setting DecisionTable.preferredOrientation (to Rule-as-Row)
> DMN1.2 Specification 8.3.1 - Decision Table metamodel states :
> ...It has a preferredOrientation, which SHALL be one of the enumerated DecisionTableOrientation.
> It is therefore not wrong for us to include preferredOrientation and seems mandatory.
> ---------------------------------------------------------------------------------
> Our marshaller is EXPLICITLY setting inputExpression.id.
> DMN1.2 Specification 8.3.2 - Decision Table Input and Output metamodel:-
> ...An instance of InputClause is made of an optional inputExpression... [where an inputExpression is an Expression].
> There is not mention as to whether the Expression inherits its id or needs one explicitly defined.
> Is it therefore incorrect for us to include the id?
> ---------------------------------------------------------------------------------
> Our marshaller IS NOT setting outputEntry.expressionLanguage.
> DMN1.2 Specification 8.3.2 - Decision Table Input and Output metamodel states (well does NOT state anything!) :
> OutputClause does not appear to have an expressionLanguage property; only the UnaryTests that is encapsulated by OutputClause supports it.
> Is this an issue with _other tools_'s marshaller?
> ---------------------------------------------------------------------------------
> [DMN Designer] Marshaller does not support DMN1.2 DecisionTable RuleAnnotation
> https://issues.redhat.com/browse/DROOLS-5045
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5032) [DMN Designer] Add support for (un)marshalling disconnected connections
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5032?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5032:
-----------------------------------
Sprint: 2020 Week 07-09 (from Feb 10), 2020 Week 10-12 (from Mar 2) (was: 2020 Week 07-09 (from Feb 10))
> [DMN Designer] Add support for (un)marshalling disconnected connections
> -----------------------------------------------------------------------
>
> Key: DROOLS-5032
> URL: https://issues.redhat.com/browse/DROOLS-5032
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.33.0.Final
> Reporter: Jozef Marko
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
>
> Connections leading 'nowhere' are lost after save and reopen the diagram.
> It is possible to have either the _start_ (source node) or _end_ (target node) of a connection "disconnected" i.e. not attached to a node.
> The DMN (un)marshaller needs to support this (as per the narrative below). The client-side (un)marshaller also needs to support it.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5045) [DMN Designer] Marshaller does not support DMN1.2 DecisionTable RuleAnnotation
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5045?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5045:
-----------------------------------
Sprint: 2020 Week 07-09 (from Feb 10), 2020 Week 10-12 (from Mar 2) (was: 2020 Week 07-09 (from Feb 10))
> [DMN Designer] Marshaller does not support DMN1.2 DecisionTable RuleAnnotation
> -------------------------------------------------------------------------------
>
> Key: DROOLS-5045
> URL: https://issues.redhat.com/browse/DROOLS-5045
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.33.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
>
> DMN1.2 has RuleAnnotation in the DecisionTable expression.
> Our marshallers (-backend and -client) do not support it and use the Expression's Description element for the DecisionRule description column. We also need to enhance the UI to support adding/deleting additional RuleAnnotations.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-4956) Normarize rule constraints for property reactivity and indexing
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-4956?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-4956:
-----------------------------------
Sprint: 2020 Week 04-06 (from Jan 20), 2020 Week 07-09 (from Feb 10), 2020 Week 10-12 (from Mar 2) (was: 2020 Week 04-06 (from Jan 20), 2020 Week 07-09 (from Feb 10))
> Normarize rule constraints for property reactivity and indexing
> ---------------------------------------------------------------
>
> Key: DROOLS-4956
> URL: https://issues.redhat.com/browse/DROOLS-4956
> Project: Drools
> Issue Type: Bug
> Components: core engine, executable model
> Affects Versions: 7.31.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
>
> Having a constraint like
> {code:java}
> Person(name == $customer)
> {code}
> is not really the same thing as
> {code:java}
> Person($customer == name)
> {code}
> In the second case not only you don't have property reactivity, but also you don't have indexing. This an inconsistent behaviour and hoping to fix it with a "normalization" phase where the second constraint got rewritten like the first before being analyzed by property reactivity and indexing.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months