[JBoss JIRA] (DROOLS-5360) Avoid direct invocation of PMMLModelExecutor.evaluate
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5360?page=com.atlassian.jira.plug... ]
Gabriele Cardosi closed DROOLS-5360.
------------------------------------
> Avoid direct invocation of PMMLModelExecutor.evaluate
> -----------------------------------------------------
>
> Key: DROOLS-5360
> URL: https://issues.redhat.com/browse/DROOLS-5360
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: TrustyAI
>
> -Change PMMLModelExecutor public API so that user should not retrieve the KiePMMLModel to invoke the "evaluate" method-
> -PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)-
> ->
> -PMML4Result evaluate(final KieBase knowledgeBase, String modelName, PMMLContext context);-
> -Create AbstractPMMLModelExecutor that implement the above interface and declare an abstract method-
> -PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)-
> -AbstractPMMLModelExecutor should then use KnoweledgeBaseUtils to retrieve the KiePMMLModel and invoke/delegate to actual implementations-
> -Actual implementations should then extend AbstractPMMLModelExecutor-
> The PMMLModelExecutor API should be intended as private API, i.e. users should not invoke it directly, nor they should need to retrieve the KiePMMLModel.
> Unfortunately, for the moment being the KiePMMLModel is needed to retrieve the actual implementation of PMMLModelExecutor, so it is not possible to invoke
> {code:java}
> PMMLModelExecutor.evaluate(...)
> {code}
> on it using only the model name without retrieve the KiePMMLModel itself before.
> For the moment being this ticket will remove usage of PMMLModelExecutor implementation inside integrations tests.
> Moreover, there will also be a small name refactoring to uniform the name of the classes in the hierarchy, so that the main interface will be
> PMMLModelEvaluator, and all the implementing class will end with "Evaluator"
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (WFLY-13424) External pooled connection factory won't be properly injected if it has several JNDI entries
by Jeff Mesnil (Jira)
[ https://issues.redhat.com/browse/WFLY-13424?page=com.atlassian.jira.plugi... ]
Jeff Mesnil commented on WFLY-13424:
------------------------------------
thanks for the explanation, that was not clear to me that `pcf instanceof ContextListAndJndiViewManagedReferenceFactory` means it is an alias.
iiuc, that means that when we integrate a version of WildFly with WFLY-13424 to build our images, CLOUD-3625 will not be required. Is that correct?
> External pooled connection factory won't be properly injected if it has several JNDI entries
> --------------------------------------------------------------------------------------------
>
> Key: WFLY-13424
> URL: https://issues.redhat.com/browse/WFLY-13424
> Project: WildFly
> Issue Type: Bug
> Components: JMS
> Affects Versions: 19.1.0.Final
> Reporter: Emmanuel Hugonnet
> Assignee: Emmanuel Hugonnet
> Priority: Major
> Fix For: 20.0.0.Beta1
>
>
> If the default JNDI name for MDB to get the resource adapter is not the first entry of the JNDI names bound for a pooled-connection-factory then the injection fails.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months