[JBoss JIRA] (DROOLS-5434) Incorrect warning about file declaring wrong package
by Magnus Larsson (Jira)
[ https://issues.redhat.com/browse/DROOLS-5434?page=com.atlassian.jira.plug... ]
Magnus Larsson updated DROOLS-5434:
-----------------------------------
Description:
I am running Drools in a Spring-Boot jar and get the following warning statement _File 'BOOT-INF/classes/com/example/test/TEST.drl' is in folder 'BOOT-INF/classes/com/example/test' but declares package 'com.example.test'. It is advised to have a correspondance between package and folder names_. The package name in the drl file is correct, the problem is just that _BOOT-INF.classes._ isn't considered when evaluating if printing the warning or not.
I have tracked it down to *KieBuilderImpl.java*, method *isFileInKieBase*. The last 2 lines in that method calls:
{code:java}
// Does not care about SUPPORTED_RESOURCES_ROOTS, thus prints the warning
String pkgNameForFile = packageNameForFile( fileName, folderNameForFile, !useFolders, file );
// Does care about SUPPORTED_RESOURCES_ROOTS, so the drl file is loaded
return isPackageInKieBase( kieBase, pkgNameForFile );
{code}
As it is implemented right now, the warning might either be a false-positive (and still get loaded), or the package is wrong (and the file is not loaded).
Voting to include the SUPPORTED_RESOURCES_ROOTS as valid prefixes when checking if the warning should be printed.
was:
I am running Drools in a Spring-Boot jar and get the following warning statement _File 'BOOT-INF/classes/com/example/test/TEST.drl' is in folder 'BOOT-INF/classes/com/example/test' but declares package 'com.example.test'. It is advised to have a correspondance between package and folder names_. The package name in the drl file is correct, the problem is just that _BOOT-INF.classes._ isn't considered when evaluating if printing the warning or not.
I have tracked it down to KieBuilderImpl.java, method isFileInKieBase. The last 2 lines in that method calls:
{code:java}
// Does not care about SUPPORTED_RESOURCES_ROOTS, thus prints the warning
String pkgNameForFile = packageNameForFile( fileName, folderNameForFile, !useFolders, file );
// Does care about SUPPORTED_RESOURCES_ROOTS, so the drl file is loaded
return isPackageInKieBase( kieBase, pkgNameForFile );
{code}
As it is implemented right now, the warning might either be a false-positive (and still get loaded), or the package is wrong (and the file is not loaded).
Voting to include the SUPPORTED_RESOURCES_ROOTS as valid prefixes when checking if the warning should be printed.
> Incorrect warning about file declaring wrong package
> ----------------------------------------------------
>
> Key: DROOLS-5434
> URL: https://issues.redhat.com/browse/DROOLS-5434
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Reporter: Magnus Larsson
> Assignee: Mario Fusco
> Priority: Major
>
> I am running Drools in a Spring-Boot jar and get the following warning statement _File 'BOOT-INF/classes/com/example/test/TEST.drl' is in folder 'BOOT-INF/classes/com/example/test' but declares package 'com.example.test'. It is advised to have a correspondance between package and folder names_. The package name in the drl file is correct, the problem is just that _BOOT-INF.classes._ isn't considered when evaluating if printing the warning or not.
> I have tracked it down to *KieBuilderImpl.java*, method *isFileInKieBase*. The last 2 lines in that method calls:
> {code:java}
> // Does not care about SUPPORTED_RESOURCES_ROOTS, thus prints the warning
> String pkgNameForFile = packageNameForFile( fileName, folderNameForFile, !useFolders, file );
> // Does care about SUPPORTED_RESOURCES_ROOTS, so the drl file is loaded
> return isPackageInKieBase( kieBase, pkgNameForFile );
> {code}
> As it is implemented right now, the warning might either be a false-positive (and still get loaded), or the package is wrong (and the file is not loaded).
> Voting to include the SUPPORTED_RESOURCES_ROOTS as valid prefixes when checking if the warning should be printed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (DROOLS-5434) Incorrect warning about file declaring wrong package
by Magnus Larsson (Jira)
Magnus Larsson created DROOLS-5434:
--------------------------------------
Summary: Incorrect warning about file declaring wrong package
Key: DROOLS-5434
URL: https://issues.redhat.com/browse/DROOLS-5434
Project: Drools
Issue Type: Bug
Components: core engine
Reporter: Magnus Larsson
Assignee: Mario Fusco
I am running Drools in a Spring-Boot jar and get the following warning statement _File 'BOOT-INF/classes/com/example/test/TEST.drl' is in folder 'BOOT-INF/classes/com/example/test' but declares package 'com.example.test'. It is advised to have a correspondance between package and folder names_. The package name in the drl file is correct, the problem is just that _BOOT-INF.classes._ isn't considered when evaluating if printing the warning or not.
I have tracked it down to KieBuilderImpl.java, method isFileInKieBase. The last 2 lines in that method calls:
{code:java}
// Does not care about SUPPORTED_RESOURCES_ROOTS, thus prints the warning
String pkgNameForFile = packageNameForFile( fileName, folderNameForFile, !useFolders, file );
// Does care about SUPPORTED_RESOURCES_ROOTS, so the drl file is loaded
return isPackageInKieBase( kieBase, pkgNameForFile );
{code}
As it is implemented right now, the warning might either be a false-positive (and still get loaded), or the package is wrong (and the file is not loaded).
Voting to include the SUPPORTED_RESOURCES_ROOTS as valid prefixes when checking if the warning should be printed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (LOGMGR-278) PeriodicRotatingFileHandler may fail to rotate a file with a security permission
by James Perkins (Jira)
[ https://issues.redhat.com/browse/LOGMGR-278?page=com.atlassian.jira.plugi... ]
James Perkins closed LOGMGR-278.
--------------------------------
Resolution: Rejected
The actual issue is setting the file not rotating it which seems correct.
> PeriodicRotatingFileHandler may fail to rotate a file with a security permission
> --------------------------------------------------------------------------------
>
> Key: LOGMGR-278
> URL: https://issues.redhat.com/browse/LOGMGR-278
> Project: JBoss Log Manager
> Issue Type: Bug
> Components: core
> Reporter: James Perkins
> Assignee: James Perkins
> Priority: Major
> Fix For: 2.2.0.Final, 2.1.17.Final, 2.3.0.Beta1
>
>
> During rotate the {{File.lastModified()}} time is used to determine if the file is ready to rotate. In situations such as a deployment on WildFly the deployment itself may fail to log a message as the security context is that of the deployment. The reason for the failure is the deployment does not have read permissions for the file.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (WFCORE-5007) Make use of the SocketAddressCallbackServerMechanismFactory to set the peer's IP address during HTTP authentication
by Farah Juma (Jira)
Farah Juma created WFCORE-5007:
----------------------------------
Summary: Make use of the SocketAddressCallbackServerMechanismFactory to set the peer's IP address during HTTP authentication
Key: WFCORE-5007
URL: https://issues.redhat.com/browse/WFCORE-5007
Project: WildFly Core
Issue Type: Task
Components: Security
Reporter: Farah Juma
Assignee: Farah Juma
WFCORE-4725 added the ability to configure a {{source-address-role-decoder}} to make use of the client's IP address for authorization decisions. Currently, it's only possible to make use of the IP address of a remote client during SASL authentication. To be able to make use of the IP address of a client during HTTP authentication, we just need to make use of a {{SocketAddressCallbackServerMechanismFactory}} to inform the server's callback handler of the peer's address.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (LOGMGR-278) PeriodicRotatingFileHandler may fail to rotate a file with a security permission
by James Perkins (Jira)
James Perkins created LOGMGR-278:
------------------------------------
Summary: PeriodicRotatingFileHandler may fail to rotate a file with a security permission
Key: LOGMGR-278
URL: https://issues.redhat.com/browse/LOGMGR-278
Project: JBoss Log Manager
Issue Type: Bug
Components: core
Reporter: James Perkins
Assignee: James Perkins
Fix For: 2.2.0.Final, 2.1.17.Final, 2.3.0.Beta1
During rotate the {{File.lastModified()}} time is used to determine if the file is ready to rotate. In situations such as a deployment on WildFly the deployment itself may fail to log a message as the security context is that of the deployment. The reason for the failure is the deployment does not have read permissions for the file.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (DROOLS-5147) [DMN Designer] DMN Decision Table - Input/Output clauses enhancements (UX)
by Elizabeth Clayton (Jira)
[ https://issues.redhat.com/browse/DROOLS-5147?page=com.atlassian.jira.plug... ]
Elizabeth Clayton updated DROOLS-5147:
--------------------------------------
Sprint: 2020 Week 25-27 (from Jun 15)
> [DMN Designer] DMN Decision Table - Input/Output clauses enhancements (UX)
> --------------------------------------------------------------------------
>
> Key: DROOLS-5147
> URL: https://issues.redhat.com/browse/DROOLS-5147
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Guilherme Gomes
> Assignee: Elizabeth Clayton
> Priority: Minor
> Labels: UXTeam, drools-tools
> Attachments: prototype.png
>
>
> Currently, the DMN Decision Tables input/output clauses work fine, but they have the following unpractical scenarios:
> - When users have a structure input node "associated" with an input clause (input column), they frequently need to go back to the data types page and remember the name of some field.
> - When users select a structure data type as the type of an output clause, they need to create sub-columns for each field manually.
> The goal for this JIRA is to get input from UX to enhance interactions with input and output clauses.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months