[jboss-jira] [JBoss JIRA] Closed: (JBMESSAGING-1218) ResultSet and PreparedStatement not explicitly closed in JDBCPersistenceManager

ResultSet and PreparedStatement not explicitly closed in JDBCPersistenceManager ------------------------------------------------------------------------------- Key: JBMESSAGING-1218 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1218 Project: JBoss Messaging Issue Type: Bug Affects Versions: 1.4.0.SP3 Reporter: Tim Fox Assigned To: Tim Fox Priority: Minor Fix For: 1.4.0.SP3.CP01, 1.4.1.beta1 A ResultSet is left open at line 924 JDBCPersistenceManager:loadFromStart. Also there is a preparedstatement left open in JDBCPersistenceManager$1HandleBeforeCommit1PCRunner.doTransaction(JDBCPersistenceManager.java:1587) This line creates a prepared statement within a loop but only the last statement created will be released. Other examples of this construct, within this file, use a simple guard to prevent subsequent allocations. This appears to be the only occurrence which does not." The preparedstatements will be when the connection is closed, but if you process a large transaction there is a possibility you could run out of resources in your database for that transaction. E.g. run out of cursors on Oracle.