[jboss-jira] [JBoss JIRA] Updated: (AS7-1483) Threads leaking when DeploymentScannerService stopped as ScheduledExecutor not shutdown

[ https://issues.jboss.org/browse/AS7-1483?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse updated AS7-1483: ---------------------------------- Summary: Threads leaking when DeploymentScannerService stopped as ScheduledExecutor not shutdown (was: After so many deployments subsequent deployments are not deployed.) Priority: Minor (was: Major) Description: To test the changes for AS7-1473 added a temporary test to ServerInModuleDeploymentTestCase to loop 50 times and call each of the filesystem based test cases. Almost at the end the marker based test is being executed and the deployment requested to be deployed, the scanner picks this up and the following is logged: - {noformat} 16:50:42,027 DEBUG [org.jboss.as.deployment] (DeploymentScanner-threads - 1) Deployment scan of [/home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/marker-deployments] found update action [{ "operation" => "composite", "address" => undefined, "steps" => [ { "operation" => "add", "address" => [("deployment" => "test-deployment.sar")], "content" => [{ "path" => "/home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/marker-deployments/test-deployment.sar", "archive" => true }], "persistent" => false }, { "operation" => "deploy", "address" => [("deployment" => "test-deployment.sar")] } ] }] {noformat} However the deployment is not logged and there is no further logging in relation to this scan. It appears however that the thread continues to be used for subsequent scans. {noformat} 16:50:46,997 TRACE [org.jboss.as.deployment] (DeploymentScanner-threads - 1) Scanning directory /home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/jbossas/standalone/deployments for deployment content changes {noformat} Reviewing the thread dump shows no threads blocked in a call to scan within FileSystemDeploymentService. After further testing the "OutOfMemoryError: unable to create new native thread" error was reported, the DeploymentScannerService is not calling shutdown on the SceduledExecutor once stops. was: To test the changes for AS7-1473 added a temporary test to ServerInModuleDeploymentTestCase to loop 50 times and call each of the filesystem based test cases. Almost at the end the marker based test is being executed and the deployment requested to be deployed, the scanner picks this up and the following is logged: - {noformat} 16:50:42,027 DEBUG [org.jboss.as.deployment] (DeploymentScanner-threads - 1) Deployment scan of [/home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/marker-deployments] found update action [{ "operation" => "composite", "address" => undefined, "steps" => [ { "operation" => "add", "address" => [("deployment" => "test-deployment.sar")], "content" => [{ "path" => "/home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/marker-deployments/test-deployment.sar", "archive" => true }], "persistent" => false }, { "operation" => "deploy", "address" => [("deployment" => "test-deployment.sar")] } ] }] {noformat} However the deployment is not logged and there is no further logging in relation to this scan. It appears however that the thread continues to be used for subsequent scans. {noformat} 16:50:46,997 TRACE [org.jboss.as.deployment] (DeploymentScanner-threads - 1) Scanning directory /home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/jbossas/standalone/deployments for deployment content changes {noformat} Reviewing the thread dump shows no threads blocked in a call to scan within FileSystemDeploymentService. Complexity: Low (Setting priority to Minor as a large number of file system scanner registration / removals is not a likely end user use case) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira