[jboss-jira] [JBoss JIRA] (AS7-3276) NPE thrown in SecurityContextAssociationValve.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Remy Maucherat commented on AS7-3276:
-------------------------------------
Casting a null object does not cause a NPE. The NPE will only occur if there's no
session.
Since right above, there's session = manager.findSession(hsession.getId()), a if
(session != null) should be enough.
I'd suggest removing the big try/catch(throwable) and logging a debug info. That's
not funny.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira