[jboss-jira] [JBoss JIRA] Commented: (JBAS-8734) API change in deployment scanner's add cause failed deployments
[
https://issues.jboss.org/browse/JBAS-8734?page=com.atlassian.jira.plugin....
]
Snjezana Peco commented on JBAS-8734:
-------------------------------------
The TomcatDeployment patch doesn't resolve all the issues. There are several places in
the AS 6 code where VFS.getChild(URL url) is called with an invalid (decoded) URL.
If you fix weld-int and TomcatDeployment, you will still have the issue in
jboss-deployers-vfs (UrlIntegrationDeployer.deploy()). If you fix the problem with
UrlIntegrationDeployer (haven't tried that), it is possible that you will get the same
problem on some other places.
So there are two solutions:
- fixing the problem with creating an invalid URL on all the places it occurs
- fixing the problem at one place - VFS.getChild(URL url)
The attached patch fixes all the potential issues with invalid (decoded) URLs.
API change in deployment scanner's add cause failed deployments
---------------------------------------------------------------
Key: JBAS-8734
URL: https://issues.jboss.org/browse/JBAS-8734
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployers
Affects Versions: 6.0.0.CR1
Reporter: Rob Stryker
Assignee: Remy Maucherat
Priority: Critical
Fix For: 6.0.0.Final
Attachments: jbas8734.patch, JBAS_8734.trace, jboss-vfs-sources.jar,
jboss-vfs.jar
When using the deployment scanner mbean to pass in a new URL that the JBossAS should scan
for deployments, a path format which worked fine in JBoss 5 and below no longer works.
Specifically, passing in a URL such as the one below:
file:/home/rob/apps/eclipse/workspaces/main_code/runtime%20space%20workspace/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_6.0_Runtime_Server1292215199516/deploy/Dyn888.war/
When passing this string into the addURL mbean, the following error in the jboss console
results:
14:52:54,927 INFO [org.jboss.web.tomcat.service.deployers.TomcatDeployment] deploy,
ctxPath=/Dyn888
14:52:54,930 ERROR [org.jboss.kernel.plugins.dependency.AbstractKernelController] Error
installing to Start: name=jboss.web.deployment:war=/Dyn888 state=Create mode=Manual
requiredState=Installed: java.net.URISyntaxException: Illegal character in path at index
56: file:/home/rob/apps/eclipse/workspaces/main_code/runtime space
workspace/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_6.0_Runtime_Server1292215199516/deploy/Dyn888.war/
at java.net.URI$Parser.fail(URI.java:2809) [:1.6.0_14]
at java.net.URI$Parser.checkChars(URI.java:2982) [:1.6.0_14]
Despite that I pass in a string with clear %20 blocking out the spaces, the deployment
scanner does not seem to recognize this and errors. This format of a string has no problem
working in AS 5.1 however.
This is blocking JBossTools server integration.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira