[jboss-jira] [JBoss JIRA] Commented: (JBSEAM-421) Update to Seam i18n to support DatabaseResourceBundle

Update to Seam i18n to support DatabaseResourceBundle ----------------------------------------------------- Key: JBSEAM-421 URL: http://jira.jboss.com/jira/browse/JBSEAM-421 Project: JBoss Seam Issue Type: Feature Request Components: Core Affects Versions: 1.1 Reporter: Todd Smart Fix For: 1.1 Attachments: ResourceBundle.java The current Seam i18n ResourceBundle class only supports loading java.util.ResourceBundle resource bundles. For ref, the loadBundle() method is: {code} private void loadBundle() { try { bundle = java.util.ResourceBundle.getBundle( bundleName, Locale.instance(), Thread.currentThread().getContextClassLoader() ); log.debug("loaded resource bundle: " + bundleName); } catch (MissingResourceException mre) { log.debug("resource bundle missing: " + bundleName); } } {code} I've updated the org.seam.core.ResourceBundle class to plug into the org.sadun.util.DatabaseResourceBundle ... providing for a very flexible, db-driven i18n system. The only change required (for the prototype code!) to get this to work was an update to the Seam ResourceBundle was: {code} private void loadBundle() { try { DatabaseResourceBundle databaseResourceBundle = new DatabaseResourceBundle(jdbcUrl, bundleName, Locale.instance()); bundle = databaseResourceBundle; log.debug("loaded resource bundle: " + bundleName); } catch (MissingResourceException mre) { log.debug("resource bundle missing: " + bundleName); } } {code} Beyond the prototype, of course, this will be cleaned up. I'm thinking others may benefit from updating this Seam class to allow for supporting other types of resource bundle repositories. Feature Request: ------------------------ 1) Add an attribute to ResourceBundle called: resourceType (thus allowing a class to be called to load a bundle). This attribute would be configured in seam.properties. 2) Update the loadBundle() method such that if resourceType is not null, to get an instance of ResourceType.instance() followed by a call to resourceType.loadBundle() method I don't mind contributing the code ... just testing the waters first. Regards, Todd Smart todd.smart(a)smartbinary.com