[jboss-jira] [JBoss JIRA] Reopened: (JBAS-6407) TestResourceAdapterTxInflow can't assume one phase commit

TestResourceAdapterTxInflow can't assume one phase commit --------------------------------------------------------- Key: JBAS-6407 URL: https://jira.jboss.org/jira/browse/JBAS-6407 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service, Test Suite Affects Versions: JBossAS-5.0.0.GA Reporter: Jonathan Halliday Assignee: Jesper Pedersen Fix For: JBossAS-5.0.1.GA, JBossAS-5.1.0.Beta1, JBossAS-6.0.0.M3, JBossAS-Branch_4_2 The TestWork class in TestResourceAdapterTxInflow implements XAResource but has some methods stubbed out to throw exceptions, on the basis that they are never invoked. One such is prepare(), on the assumption that a transaction containing only a single resource will always use one phase commit, skipping the prepare call. This is not the case. Whilst 1PC is a useful performance optimisation, it's not required. Also, it's not possible in certain distributed transaction cases, depending on the use of interposition. In particular, the JBossTS JTS implementation won't always use 1PC, which can cause this test case to fail. Fix: modify TestWork.prepare to return XAResource.XA_OK instead of throwing XAException