[JBoss JIRA] Created: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
4:53 p.m.
ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on
every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:57 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Scott M Stark commented on JBAS-6219:
-------------------------------------
We need to add a clone operation to DeploymentTemplateInfo, JBAS-6232
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:55 p.m.
New subject: [JBoss JIRA] Assigned: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Scott M Stark reassigned JBAS-6219:
-----------------------------------
Assignee: Ian Springer (was: Scott M Stark)
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Ian Springer
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:55 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Scott M Stark commented on JBAS-6219:
-------------------------------------
I can't reproduce this, and can't see how it can happen as the
DeploymentTemplateInfo is only used in a copy semantic. The properties are copied to the
client, and the client passes back an updated copy that is never written back onto the
original template properties. Is there some way your caching the original template info? I
have added logging of the DeploymentTemplateInfo as received and after updated, and for
this output I have run the testAddDataSource test twice, but I still see null/default
values in the template properties that are updated to non-null values:
1552 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: valid-connection-checker-class-name,null
1552 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
valid-connection-checker-class-name,SimpleMetaType:java.lang.String:org.jboss.resource.adapter.jdbc.vendor.DummyValidConnectionChecker
1553 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: jndi-name,SimpleMetaType:java.lang.String:
1553 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: jndi-name,SimpleMetaType:java.lang.String:TestLocalTxDs
1553 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: validate-on-match,SimpleMetaType:java.lang.Boolean:true
1553 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: validate-on-match,SimpleMetaType:java.lang.Boolean:false
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: connection-url,null
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: connection-url,SimpleMetaType:java.lang.String:jdbc:hsqldb:.
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: metadata,null
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: metadata,CompositeValueSupport:
metaType=[MutableCompositeMetaType{org.jboss.resource.metadata.mcf.DBMSMetaData
items=[name=typeMapping type=java.lang.String]}] items=[typeMapping=null]
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: url-delimiter,null
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: url-delimiter,SimpleMetaType:java.lang.String:+
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: driver-class,null
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
driver-class,SimpleMetaType:java.lang.String:org.hsqldb.jdbcDriver
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: min-pool-size,SimpleMetaType:java.lang.Integer:0
1554 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: min-pool-size,SimpleMetaType:java.lang.Integer:0
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before:
prepared-statement-cache-size,SimpleMetaType:java.lang.Integer:0
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
prepared-statement-cache-size,SimpleMetaType:java.lang.Integer:12
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: exception-sorter-class-name,null
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
exception-sorter-class-name,SimpleMetaType:java.lang.String:org.jboss.resource.adapter.jdbc.vendor.DummyExceptionSorter
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: max-pool-size,SimpleMetaType:java.lang.Integer:10
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: max-pool-size,SimpleMetaType:java.lang.Integer:11
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before:
share-prepared-statements,SimpleMetaType:java.lang.Boolean:false
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: share-prepared-statements,SimpleMetaType:java.lang.Boolean:true
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: use-strict-min,null
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: use-strict-min,SimpleMetaType:java.lang.Boolean:true
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: no-tx-separate-pools,null
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: no-tx-separate-pools,SimpleMetaType:java.lang.Boolean:true
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: statistics-formatter,null
1555 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
statistics-formatter,SimpleMetaType:java.lang.String:org.jboss.resource.statistic.pool.JBossDefaultSubPoolStatisticFormatter
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: track-connection-by-tx,SimpleMetaType:java.lang.Boolean:true
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: track-connection-by-tx,SimpleMetaType:java.lang.Boolean:true
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: prefill,null
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: prefill,SimpleMetaType:java.lang.Boolean:true
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: password,null
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: password,SimpleMetaType:java.lang.String:
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: use-java-context,SimpleMetaType:java.lang.Boolean:true
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: use-java-context,SimpleMetaType:java.lang.Boolean:true
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: set-tx-query-timeout,SimpleMetaType:java.lang.Boolean:false
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: set-tx-query-timeout,SimpleMetaType:java.lang.Boolean:true
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: stale-connection-checker-class-name,null
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
stale-connection-checker-class-name,SimpleMetaType:java.lang.String:org.jboss.resource.adapter.jdbc.vendor.DummyValidConnectionChecker
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: use-try-lock,null
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: use-try-lock,SimpleMetaType:java.lang.Long:5000
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: blocking-timeout-millis,SimpleMetaType:java.lang.Long:30000
1556 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: blocking-timeout-millis,SimpleMetaType:java.lang.Long:15000
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: type-mapping,null
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: type-mapping,SimpleMetaType:java.lang.String:Hypersonic SQL
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: connection-definition,null
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
connection-definition,SimpleMetaType:java.lang.String:javax.sql.DataSource
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: idle-timeout-minutes,SimpleMetaType:java.lang.Integer:30
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: idle-timeout-minutes,SimpleMetaType:java.lang.Integer:111
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: transaction-isolation,null
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
transaction-isolation,SimpleMetaType:java.lang.String:TRANSACTION_SERIALIZABLE
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: background-validation,SimpleMetaType:java.lang.Boolean:false
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: background-validation,SimpleMetaType:java.lang.Boolean:true
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: isSameRM-override-value,null
1557 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: isSameRM-override-value,SimpleMetaType:java.lang.Boolean:false
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: track-statements,null
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: track-statements,SimpleMetaType:java.lang.String:
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: rar-name,null
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: rar-name,SimpleMetaType:java.lang.String:jboss-local-jdbc.rar
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: user-name,null
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: user-name,SimpleMetaType:java.lang.String:sa
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: check-valid-connection-sql,null
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: check-valid-connection-sql,SimpleMetaType:java.lang.String:CALL
ABS(1.0)
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: new-connection-sql,null
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: new-connection-sql,SimpleMetaType:java.lang.String:CALL ABS(2.0)
1558 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: background-validation-millis,SimpleMetaType:java.lang.Long:0
1559 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: background-validation-millis,SimpleMetaType:java.lang.Long:5000
1559 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: query-timeout,SimpleMetaType:java.lang.Integer:0
1559 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after: query-timeout,SimpleMetaType:java.lang.Integer:100
1559 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property before: url-selector-strategy-class-name,null
1559 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
template property after:
url-selector-strategy-class-name,SimpleMetaType:java.lang.String:org.jboss.test.jca.support.MyURLSelector
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{valid-connection-checker-class-name,validConnectionCheckerClassName,metaType=SimpleMetaType:java.lang.String}
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking: ManagedProperty{jndi-name,jndiName,metaType=SimpleMetaType:java.lang.String}
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{validate-on-match,validateOnMatch,metaType=SimpleMetaType:java.lang.Boolean}
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{connection-url,connectionUrl,metaType=SimpleMetaType:java.lang.String}
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{metadata,DBMSMetaData,metaType=MutableCompositeMetaType{org.jboss.resource.metadata.mcf.DBMSMetaData
items=[name=typeMapping type=java.lang.String]}}
3340 [main] WARN org.jboss.test.profileservice.test.ProfileServiceUnitTestCase - Not
checking composite: CompositeValueSupport:
metaType=[MutableCompositeMetaType{org.jboss.resource.metadata.mcf.DBMSMetaData
items=[name=typeMapping type=java.lang.String]}] items=[typeMapping=null]
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{url-delimiter,URLDelimiter,metaType=SimpleMetaType:java.lang.String}
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{driver-class,driverClass,metaType=SimpleMetaType:java.lang.String}
3340 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{min-pool-size,minSize,metaType=SimpleMetaType:java.lang.Integer}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{prepared-statement-cache-size,preparedStatementCacheSize,metaType=SimpleMetaType:java.lang.Integer}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{exception-sorter-class-name,exceptionSorterClassName,metaType=SimpleMetaType:java.lang.String}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{max-pool-size,maxSize,metaType=SimpleMetaType:java.lang.Integer}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{share-prepared-statements,sharePreparedStatements,metaType=SimpleMetaType:java.lang.Boolean}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{use-strict-min,useStrictMin,metaType=SimpleMetaType:java.lang.Boolean}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{no-tx-separate-pools,noTxSeparatePools,metaType=SimpleMetaType:java.lang.Boolean}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{statistics-formatter,statisticsFormatter,metaType=SimpleMetaType:java.lang.String}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{track-connection-by-tx,trackConnectionByTransaction,metaType=SimpleMetaType:java.lang.Boolean}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking: ManagedProperty{prefill,prefill,metaType=SimpleMetaType:java.lang.Boolean}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking: ManagedProperty{password,passWord,metaType=SimpleMetaType:java.lang.String}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{use-java-context,useJavaContext,metaType=SimpleMetaType:java.lang.Boolean}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{set-tx-query-timeout,useQueryTimeout,metaType=SimpleMetaType:java.lang.Boolean}
3341 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{stale-connection-checker-class-name,staleConnectionCheckerClassName,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking: ManagedProperty{use-try-lock,useTryLock,metaType=SimpleMetaType:java.lang.Long}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{blocking-timeout-millis,blockingTimeoutMilliSeconds,metaType=SimpleMetaType:java.lang.Long}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{type-mapping,typeMapping,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{connection-definition,connectionDefinition,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{idle-timeout-minutes,idleTimeoutMinutes,metaType=SimpleMetaType:java.lang.Integer}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{transaction-isolation,transactionIsolation,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{background-validation,backgroundValidation,metaType=SimpleMetaType:java.lang.Boolean}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{isSameRM-override-value,isSameRMOverrideValue,metaType=SimpleMetaType:java.lang.Boolean}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{track-statements,trackStatements,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking: ManagedProperty{rar-name,rarName,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking: ManagedProperty{user-name,userName,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{check-valid-connection-sql,checkValidConnectionSQL,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{new-connection-sql,newConnectionSQL,metaType=SimpleMetaType:java.lang.String}
3342 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{background-validation-millis,backgroundValidationMillis,metaType=SimpleMetaType:java.lang.Long}
3343 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{query-timeout,queryTimeout,metaType=SimpleMetaType:java.lang.Integer}
3344 [main] DEBUG org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
Checking:
ManagedProperty{url-selector-strategy-class-name,URLSelectorStrategyClassName,metaType=SimpleMetaType:java.lang.String}
3344 [main] WARN org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
testAddDataSource> untested properties: [connectionDestroyedCount, local-transaction,
jmx-invoker-name, security-domain, interleaving, maxConnectionsInUseCount,
connection-properties, connectionCreatedCount, inUseConnectionCount,
availableConnectionCount, minSize, maxSize, config-property, poolJndiName,
connectionCount, allocation-retry, allocation-retry-wait-millis]
3344 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{connectionDestroyedCount,connectionDestroyedCount,metaType=SimpleMetaType:java.lang.Integer}
3344 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{local-transaction,localTransactions,metaType=SimpleMetaType:java.lang.Boolean}
3344 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{jmx-invoker-name,jmxInvokerName,metaType=SimpleMetaType:java.lang.String}
3344 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{security-domain,securityMetaData,metaType=GenericMetaType:org.jboss.managed.api.ManagedObject}
3344 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{interleaving,interleaving,metaType=SimpleMetaType:java.lang.Boolean}
3344 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{maxConnectionsInUseCount,maxConnectionsInUseCount,metaType=SimpleMetaType:java.lang.Long}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{connection-properties,dataSourceConnectionProperties,metaType=MapCompositeMetaType{java.util.Map}}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{connectionCreatedCount,connectionCreatedCount,metaType=SimpleMetaType:java.lang.Integer}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{inUseConnectionCount,inUseConnectionCount,metaType=SimpleMetaType:java.lang.Long}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{availableConnectionCount,availableConnectionCount,metaType=SimpleMetaType:java.lang.Long}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{minSize,minSize,metaType=SimpleMetaType:java.lang.Integer}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{maxSize,maxSize,metaType=SimpleMetaType:java.lang.Integer}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{config-property,managedConnectionFactoryProperties,metaType=MapCompositeMetaType{java.util.Map}}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{poolJndiName,poolJndiName,metaType=SimpleMetaType:java.lang.String}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{connectionCount,connectionCount,metaType=SimpleMetaType:java.lang.Integer}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{allocation-retry,allocationRetry,metaType=SimpleMetaType:java.lang.Integer}
3345 [main] INFO org.jboss.test.profileservice.test.ProfileServiceUnitTestCase -
ManagedProperty{allocation-retry-wait-millis,allocationRetryWaitMillis,metaType=SimpleMetaType:java.lang.Long}
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:30 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Ian Springer commented on JBAS-6219:
------------------------------------
Scott, to see that I'm talking about, turn on DEBUG logging for
org.rhq.plugins.jbossas5, then create two new Queues via Embedded Jopr (to do this, go to
the "Platform > JBossAS Servers > JBoss App Server:default > Resources >
JMS Destinations > Queues" node, then click the [Add a new Resource] button. You
should see output in the log similar to the following:
// This is the 1st call to createResource(), creating a queue named "jojo"
12:09:29,533 DEBUG [ApplicationServerComponent] BEFORE CREATE:
Properties for DeploymentTemplateInfo [QueueTemplate]:
name=JNDIName, mappedName=null, viewUse=NONE, required=false, type=SimpleMetaType,
value= <<<null>>>
name=name, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=
<<<null>>>
12:09:29,705 DEBUG [ConversionUtils] Converting property PropertySimple[id=0,
name=JNDIName, value=jojo, override=false]
with definition SimpleProperty[JNDIName] (Type: STRING) to MetaValue with type
SimpleMetaType:java.lang.String...
12:09:29,736 DEBUG [ApplicationServerComponent] AFTER CREATE:
Properties for DeploymentTemplateInfo [QueueTemplate]:
name=JNDIName, mappedName=null, viewUse=NONE, required=false, value=
SimpleMetaType:java.lang.String:jojo
name=name, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=
<<<null>>>
...
...
...
// This is the 2nd call to createResource(), creating a queue named "gugu"
12:10:38,115 DEBUG [ApplicationServerComponent] BEFORE CREATE:
Properties for DeploymentTemplateInfo [QueueTemplate]:
name=JNDIName, mappedName=null, viewUse=NONE, required=false, value=
SimpleMetaType:java.lang.String:jojo
name=name, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=
<<<null>>>
12:10:38,115 DEBUG [ConversionUtils] convertConfigurationToManagedProperties:
ManagedProperty.getValue() returned: Simpl
eValueSupport for property: JNDIName
12:10:38,115 DEBUG [ApplicationServerComponent] AFTER CREATE:
Properties for DeploymentTemplateInfo [QueueTemplate]:
name=JNDIName, mappedName=null, viewUse=NONE, required=false, value=
SimpleMetaType:java.lang.String:gugu
name=name, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=
<<<null>>>
These log messages are printed by ApplicationServerComponent.createResource(). What they
are dumping is managementView.getTemplate(templateName).getProperties().
As you can see in the 2nd call to createResource(), the template property
"JNDIName" still has a value of "jojo". This is a remnant from the 1st
call. Every time I call managementView.getTemplate(), I should get a fresh template (or
alternatively, managementView.getTemplate().getProperties() could always return a fresh
copy of the properties).
I tried adding a call to managementView.loadProfile() at the beginning of createResource()
to refresh the view, but that didn't help.
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Ian Springer
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:33 p.m.
New subject: [JBoss JIRA] Assigned: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Scott M Stark reassigned JBAS-6219:
-----------------------------------
Assignee: Scott M Stark (was: Ian Springer)
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:04 p.m.
New subject: [JBoss JIRA] Assigned: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Scott M Stark reassigned JBAS-6219:
-----------------------------------
Assignee: Ian Springer (was: Scott M Stark)
As I mentioned on the jop-dev list, I can't get the admin-console to display the queue
properties to be able to validate the scenario you describe. I have added the following
jbas testcase which follows the code I see in
ApplicationServerComponent.createConfigurationBasedResource as closely as possible, and it
does not see the previous jndi name. Assign it back to me when the admin-console is
showing this or you see a change to make in this test.
public void testMultipleQueues() throws Exception
{
ManagementView managementView = getManagementView();
Map<String, MetaValue> propValues = new HashMap<String, MetaValue>();
// testCreateQueue1
String jndiName = "testCreateQueue1";
String templateName = "QueueTemplate";
MetaValue jndiName1MV = SimpleValueSupport.wrap(jndiName);
propValues.put("JNDIName", jndiName1MV);
ComponentType type = KnownComponentTypes.JMSDestination.Queue.getType();
DeploymentTemplateInfo queue1Info = managementView.getTemplate(templateName);
Map<String, ManagedProperty> testCreateQueue1Props =
queue1Info.getProperties();
log.debug("QueueTemplate#1: "+testCreateQueue1Props);
for(String propName : testCreateQueue1Props.keySet())
{
ManagedProperty prop = testCreateQueue1Props.get(propName);
assertNotNull("property " + propName + " found in template "
+ templateName, prop);
log.debug("createComponentTest("+propName+") before:
"+prop.getValue());
prop.setValue(propValues.get(propName));
log.debug("createComponentTest("+propName+") after:
"+prop.getValue());
}
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
"testCreateQueue1", queue1Info);
managementView.process();
// testCreateQueue2
jndiName = "testCreateQueue2";
MetaValue jndiName2MV = SimpleValueSupport.wrap(jndiName);
propValues.put("JNDIName", jndiName2MV);
// Get a fresh template info view
DeploymentTemplateInfo queue2Info = managementView.getTemplate(templateName);
Map<String, ManagedProperty> testCreateQueue2Props =
queue2Info.getProperties();
log.debug("QueueTemplate#2: "+testCreateQueue2Props);
// Validate the properties don't have the previous template values
ManagedProperty jndiNameCheck1 = testCreateQueue2Props.get("JNDIName");
assertFalse("Fresh temmplate properties does not have previous JNDIName",
jndiName1MV.equals(jndiNameCheck1.getValue()));
for(String propName : testCreateQueue2Props.keySet())
{
ManagedProperty prop = testCreateQueue2Props.get(propName);
assertNotNull("property " + propName + " found in template "
+ templateName, prop);
log.debug(propName+" before: "+prop.getValue());
prop.setValue(propValues.get(propName));
log.debug(propName+" after: "+prop.getValue());
}
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
"testCreateQueue2", queue2Info);
managementView.process();
// Validate the components
managementView.reloadProfile();
ManagedComponent queue1 = managementView.getComponent("testCreateQueue1",
type);
assertNotNull(queue1);
assertEquals("testCreateQueue1", queue1.getName());
ManagedComponent queue2 = managementView.getComponent("testCreateQueue2",
type);
assertNotNull(queue2);
assertEquals("testCreateQueue2", queue2.getName());
}
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Ian Springer
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:33 p.m.
New subject: [JBoss JIRA] Assigned: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Charles Crouch reassigned JBAS-6219:
------------------------------------
Assignee: Scott M Stark (was: Ian Springer)
Scott, you should now be able to replay Ian's steps, though you will have to work
around EMBJOPR-86. Just click on the Queue type in the nav after you've created the
first resource and you should be fine.
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:05 a.m.
New subject: [JBoss JIRA] Resolved: (JBAS-6219) ManagementView.getTemplate() should return a new copy of the DeploymentTemplateInfo on every call
[
https://jira.jboss.org/jira/browse/JBAS-6219?page=com.atlassian.jira.plug...
]
Scott M Stark resolved JBAS-6219.
---------------------------------
Fix Version/s: JBossAS-5.1.0.Beta1
Resolution: Done
With the jboss-managed 2.1.0.CR3 and related JBAS changes this is fixed. The console
running in the server was seeing call by reference values from the getTemplate call.
ManagementView.getTemplate() should return a new copy of the
DeploymentTemplateInfo on every call
-------------------------------------------------------------------------------------------------
Key: JBAS-6219
URL: https://jira.jboss.org/jira/browse/JBAS-6219
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
Fix For: JBossAS-5.1.0.Beta1
In our create-resource code, we do the following:
DeploymentTemplateInfo template = managementView.getTemplate(templateName);
Map<String, ManagedProperty> managedProperties = template.getProperties();
// Update managedProperties according to the properties the user entered in the EmbJopr
UI.
managementView.applyTemplate(ManagedDeployment.DeploymentPhase.APPLICATION,
resourceName, template);
managementView.process();
This all works fine the first time through. The problem is the next time we execute the
above code using the same templateName, getTemplate(() returns the same
DeploymentTemplateInfo from the previous call (with the updates we made to its
managedProperties). Instead, it should return a new "fresh"
DeploymentTemplateInfo object that contains only the properties from the original
template.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5789
days inactive
5895
days old
8 comments
3 participants
participants (3)
-
Charles Crouch (JIRA) -
Ian Springer (JIRA)
-
Scott M Stark (JIRA)