[JBoss JIRA] Created: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
12:56 p.m.
Use of system property for proxy generation setting is too inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated for
type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too aggressively.
In CDI extensions, we are forced to use a static code block to set the property so it is
assigned early enough that JBoss Logging caches the correct value. However, with multiple
extensions loading in a non-deterministic order, we end up having to put this static block
in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration API
to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:04 p.m.
New subject: [JBoss JIRA] Assigned: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
David Lloyd reassigned JBLOGGING-52:
------------------------------------
Assignee: Dan Allen (was: David Lloyd)
Reassigning to Dan Allen for further comment.
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:04 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
David Lloyd commented on JBLOGGING-52:
--------------------------------------
This setting is very definitely not intended for any purpose even approaching production
use. You should instead use the org.jboss.logging:jboss-logging-tools project to process
the logger annotations at build time. The only time you should be using the property is,
for example, testing in your IDE where the whole project is not necessarily being compiled
before you run it; in this case the property would be set on the command line. Dynamic
generation of proxies will not be used for any purpose beyond this use case.
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:47 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
Pete Muir commented on JBLOGGING-52:
------------------------------------
David, is it not possible to provide automatic fallback to proxies if the classes have not
been generated by the tooling at compile time, and log a warning? This would be more
developer friendly.
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:03 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-52:
------------------------------------
I now understand the situation better. I came into this from the side, so I wasn't
aware that the use of tooling was the intended design. We can put that tooling in place
within the Seam modules to avoid these intermittent failures.
As for the application use of JBoss Logging...
I have to agree with Pete that there will be some users that would prefer to leverage the
dynamic generation in earlier phases of the project (and not just because they are using
an IDE). Having to use a system property is *very* unfriendly for developers (trust me,
they are going to complain loudly about it). We can encourage them to do the right thing,
but we have to have that nice safety net to fallback on.
We have options like Seam Config that developers can use to set values of fields for
app-wide configuration concerns. We'd like to be able to leverage that.
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:14 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
David Lloyd commented on JBLOGGING-52:
--------------------------------------
To Pete: yes, this is possible, however the reason this isn't the default behavior is
that there can be surprising adverse performance effects to doing this. Even if you do
log a message, since this is in fact the logging framework that we're talking about,
there is a lot that can go wrong: the log message might be logged before there is even a
logger, the log message might be filtered out, etc. The consequence to this is that your
application might suddenly appear to have massively slowed down without any visible reason
as to why.
To Dan: I think a more realistic long-term solution would be to look at the possibility of
runtime generation of these classes somehow. The proxy solution that is in there now is
exceedingly crappy and is the result of about 10 minutes of thought. If people truly want
to skip the tooling then by generating these things at runtime is the best option because
there's only a one-time performance hit; after that, runtime performance is not
impacted. However, it would be a lot of work, so it's not even nearly on my radar,
though I wouldn't mind abusing our current volunteer crowd to achieve this goal if
it's very important and if they're willing and able to do so.
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:18 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-52:
------------------------------------
We need a simpler, less global way of enabling the proxy generation. The simplest way for
developers is likely to include a .properties file on the classpath, perhaps with a
boolean property that enables or disables it. Application developers need a simple step
that does not involve changing the parameters by which the application server starts
(because that requires different instructions per application server that frankly we
don't want to have to worry about).
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:40 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
David Lloyd commented on JBLOGGING-52:
--------------------------------------
I've gotta be honest, I don't think the proxy feature should even exist. If a
developer is building a development version of their module, they're running it
through a compiler. If they're running it through a compiler then they're also
running it through an annotation processor, ergo they'll have the generated classes.
The only case this doesn't hold true is for IDEs - supposedly - though as an IDE user
I have yet to encounter this situation.
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:51 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-52:
------------------------------------
After giving it more thought, I absolutely support your position. The proxy feature was
really a temporary solution until the tooling was ready. Now it is. The generated classes
are so much more reliable and fool-proof, permitted the developer is given the information
to set up the tooling.
I've removed references to the proxy setting from the reference documentation. Can we
convert this issue into "remove the proxy generation?"
(Btw. If we decide to do the proxy generation in the future, I realized that it would be
more appropriated for us to do it in Solder anyhow, as it's more of
developer-oriented, programming model related issue.)
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:33 a.m.
New subject: [JBoss JIRA] Updated: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
David Lloyd updated JBLOGGING-52:
---------------------------------
Fix Version/s: 3.0.0.CR1
(was: 3.0.0.Beta5-jboss-logging)
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.CR1
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:45 p.m.
New subject: [JBoss JIRA] Updated: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
David Lloyd updated JBLOGGING-52:
---------------------------------
Fix Version/s: 3.1.0.Beta1
(was: 3.0.0.GA)
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.1.0.Beta1
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:41 p.m.
New subject: [JBoss JIRA] Assigned: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
James Perkins reassigned JBLOGGING-52:
--------------------------------------
Assignee: James Perkins (was: Dan Allen)
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: James Perkins
Fix For: 3.1.0.Beta1
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
New subject: [JBoss JIRA] (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible
[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
David Lloyd resolved JBLOGGING-52.
----------------------------------
Fix Version/s: (was: 3.1.0.Beta1)
Resolution: Won't Fix
Proxy generation is disabled for the time being.
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL: https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: James Perkins
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4767
days inactive
5067
days old
12 comments
5 participants
participants (5)
-
Dan Allen (JIRA) -
David Lloyd (JIRA)
-
David Lloyd (Resolved) (JIRA)
-
James Perkins (JIRA)
-
Pete Muir (JIRA)