10:52 a.m.
Allow setting globals for access by the scoring rules
-----------------------------------------------------
Key: JBRULES-2700
URL: https://jira.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Mark Proctor
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:59 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-2700) Allow setting globals for access by the scoring rules
[
https://jira.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet reassigned JBRULES-2700:
-----------------------------------------
Assignee: Geoffrey De Smet (was: Mark Proctor)
Allow setting globals for access by the scoring rules
-----------------------------------------------------
Key: JBRULES-2700
URL: https://jira.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:05 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2700) Allow setting globals for access by the scoring rules
[
https://jira.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
For another issue, it should be possible to set the RuleBase instead of supplying the DRL
references.
Would that solve this issue? Maybe not because a service needs to be set on the WM, not
the RuleBase which creates the WM.
However, every now and then planner needs to create a new WM (especially once we go
multi-threaded/vm), currently only in debug mode I believe, so setting it on an individual
WM isn't a good solution.
Defining a map of globals to put on any WM that is created, might work.
Allow setting globals for access by the scoring rules
-----------------------------------------------------
Key: JBRULES-2700
URL: https://jira.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:07 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://jira.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet updated JBRULES-2700:
--------------------------------------
Summary: Allow setting a global variable (for example a service) which can be used by
the score rules (was: Allow setting globals for access by the scoring rules)
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://jira.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
Similar discussion with a workaround:
http://stackoverflow.com/questions/6625000/drools-creating-a-custom-score
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet edited comment on JBRULES-2700 at 7/29/11 7:44 AM:
--------------------------------------------------------------------
For another issue, it should be possible to set the RuleBase instead of supplying the DRL
references.
Would that solve this issue? Maybe not because a service needs to be set on the WM, not
the RuleBase which creates the WM.
Update: It would not solve this issue because setting it on the rulebase doesn't work,
because global variables need to be set on the WorkingMemory instances, not the RuleBase.
However, every now and then planner needs to create a new WM (especially once we go
multi-threaded/vm), currently only in debug mode I believe, so setting it on an individual
WM isn't a good solution.
Defining a map of globals to put on any WM that is created, might work.
was (Author: ge0ffrey):
For another issue, it should be possible to set the RuleBase instead of supplying the
DRL references.
Would that solve this issue? Maybe not because a service needs to be set on the WM, not
the RuleBase which creates the WM.
However, every now and then planner needs to create a new WM (especially once we go
multi-threaded/vm), currently only in debug mode I believe, so setting it on an individual
WM isn't a good solution.
Defining a map of globals to put on any WM that is created, might work.
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
One resolution would be the ability to hook in a WorkingMemoryPreperator, which is a class
that would be run every time a new memory is created. The problem is you 'll probably
want to be able to fetch those constants from some service that you need to inject in that
Preperator, which would be hard...
I am not yet convinced that simply putting some InstitutionWeightings instance like in
Examination example doesn't suffice :/
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:50 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Henrik Saksela commented on JBRULES-2700:
-----------------------------------------
I have a setup in which I simply must look up some information from a database from within
a rule; this concerns adding some data to generated facts prior to inserting them. I'm
going to generate these facts in a factory-type service which performs the necessary data
lookup.
I'd very much like some way of making this service object available as a global, but
from the looks of it I'll have to resort to overriding internal drools behavior to
achieve this (my first idea was to wrap RuleBase and override newStatefulSession?). Please
consider adding some sort of supported API for achieving this instead.
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:04 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
@Henrik That scenario makes sense.
Here's solution proposal A:
DroolsScoreDirectorFactory gets a Map<String, Object> globalVariablesToInjectMap
for every entry in that map, DroolsScoreDirector injects them (key = global variable name,
value = instance to inject) when creating a new working memory.
ScoreDirectorFactoryConfig gets a Map<String, Object>
droolsGlobalVariablesToInjectMap.
Database connections in XML won't work well (because the connection will never get
closed), so the use of droolsGlobalVariablesToInjectMap would call for the use of API
configuration (see manual), which is fine.
Chapter-Score_calculation.xml should document how to use it, preferably with a connection
based example. It should clearly state that all global variables must be thread-safe.
Open questions: Is the thead-safe requirement doable? In some cases they might need to
hack it with ThreadLocals.
Currently this is not a priority for me, but pull requests are welcome :)
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
solution proposal B:
DroolsScoreDirectorFactory gets a WorkingMemoryCreator class.
The default implementation just creates a working memory like it does now.
But you can override it to create a working memory with globals (and whatever).
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet updated JBRULES-2700:
--------------------------------------
Description:
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
was:
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface:
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:29 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Henrik Saksela commented on JBRULES-2700:
-----------------------------------------
Thanks for a quick reply! I'll see what I can do. Proposal A is probably more
reasonable, I can't see a reason for exposing the rest of WorkingMemory? I read
through the stuff you mentioned, and this seems straightforward.
Regarding thread safety: Should the globals possibly implement some interface to allow
them to be notified when the solver session starts / ends? This could allow the globals to
handle thread specific db-connection lifecycle stuff.
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:33 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
@Henrik WorkingMemory's are created in the middle of solving too, between 2 phases.
For example, genetic algorithms will require 1 WM per Solution in it's population
(consider that local search don't have a population of solutions, so it only has
actually a population of 1 solution).
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:35 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
The main reason why there are multiple WM's in population scenario's and/or
multi-threaded solving scenario's (neither which have been implemented today), is
because of incremental score calculation (see manual).
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:48 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Henrik Saksela commented on JBRULES-2700:
-----------------------------------------
Yeah I noticed the part about creating new WMs between phases; my first attempt att
solving this crudely injected the globals into the initial WM which worked until the first
phase ended.. Overriding the WM creation in RuleBase worked, but it wasn't a very
elegant solution :)
Still, if the globals were notified 1) at the beginning / end of solve() at this point, 2)
at the beginning / end of any spawned threads in the future, they could take care of the
their own thread safety using threadlocals. Of course, as long as planner isn't
multithreaded I can just implement the thread-specific stuff outside solver..
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:56 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
Solution proposal D: Notifying the globals at the beginning and ending of workingMemory
creation (not solve())
I don't prefer this proposal, because it requires the global instances to implement a
custom interface, so you can't reuse JDCB's datasource directly etc.
Solution proposal E: Notify a WorkingMemoryManager interface from
DroolsScoreDirectorFactory every time a WM is created or destroyed.
This is basically proposal B. I think I prefer this one.
How to do proposal E:
DroolsScoreDirector must delegate WM creation and destruction to
DroolsScoreDirectorFactory
DroolsScoreDirectorFactory can have a WorkingMemoryManager instance.
Upon WM creation and destruction, DroolsScoreDirectorFactory calls WorkingMemoryManager.
This gives WorkingMemoryManager an opportunity to add globals (and whatnot) to the WM
during creation and cleanup during destruction.
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:04 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Henrik Saksela commented on JBRULES-2700:
-----------------------------------------
Yes, Solution E does sound the most elegant. I'll see what implementing this would
entail / look into doing a pull request. Thanks for your time!
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:06 a.m.
New subject: [JBoss JIRA] (JBRULES-2700) Allow setting a global variable (for example a service) which can be used by the score rules
[
https://issues.jboss.org/browse/JBRULES-2700?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2700:
-------------------------------------------
@Henrik thanks! If it's good, I 'll merge it :)
Allow setting a global variable (for example a service) which can be
used by the score rules
--------------------------------------------------------------------------------------------
Key: JBRULES-2700
URL: https://issues.jboss.org/browse/JBRULES-2700
Project: Drools
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: drools-planner
Reporter: Wouter Horré
Assignee: Geoffrey De Smet
Currently, it is not possible to set a global variable in the working memory used by the
solver. If a scoring rule needs an external helper for calculating scores (e.g. a
dependency injected with OSGi DS), a workaround using a static variable in some class
accessible by the scoring rules is needed.
The easiest implementation is probably a new method in the Solver interface: //
Impossible
public WorkingMemory getWorkingMemory();
which provides access to the working memory used by the solver.
=> Impossible because the number of WorkingMemory equals the number of threads being
used by Planner, and sometimes they are reset.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4524
days inactive
5224
days old
17 comments
3 participants
participants (3)
-
Geoffrey De Smet (JIRA) -
Henrik Saksela (JIRA)
-
Wouter Horré (JIRA)