[ https://jira.jboss.org/jira/browse/JBMESSAGING-1617?page=com.atlassian.ji... ] Howard Gao reassigned JBMESSAGING-1617: --------------------------------------- Assignee: Howard Gao (was: Tim Fox) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMESSAGING-1617?page=com.atlassian.ji... ] Howard Gao commented on JBMESSAGING-1617: ----------------------------------------- As using byte[] as correlation ID is not portable, we can drop it. But if the foreign message has a string correlation ID, it should be preserved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMESSAGING-1617?page=com.atlassian.ji... ] Tim Fox commented on JBMESSAGING-1617: -------------------------------------- The description doesn't actually explain what the perceived problem is. I just see a long quote from the JMS spec followed by some talk about a new constructor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMESSAGING-1617?page=com.atlassian.ji... ] Tim Fox updated JBMESSAGING-1617: --------------------------------- Summary: JBM does not handle java.lang.UnsupportedOperationException thrown from getCorrelationIDBytes() when copying a foreign message. (was: JBoss should rely on JMSCorrelationID as String as per JMS1.1 spec and handle java.lang.UnsupportedOperationException) Description: Some providers can throw UnsupportedOperationException from getCorrelationIDBytes(). This is called in the foreign message constructor of a JBM message. Currently JBM will fail to copy the message since the exception is not handled. JavaTM Message Service Specification Version 1.1 : " 3.4.5 JMSCorrelationID A client can use the JMSCorrelationID header field to link one message with another. A typical use is to link a response message with its request message. JMSCorrelationID can hold one of the following: • A provider-specific message ID • An application-specific String • A provider-native byte[] value Since each message sent by a JMS provider is assigned a message ID value, it is convenient to link messages via message ID. All message ID values must start with the 'ID:' prefix. In some cases, an application (made up of several clients) needs to use an application-specific value for linking messages. For instance, an application may use JMSCorrelationID to hold a value referencing some external information. Application-specified values must not start with the 'ID:' prefix; this is reserved for provider-generated message ID values. If a provider supports the native concept of correlation ID, a JMS client may need to assign specific JMSCorrelationID values to match those expected by non-JMS clients. A byte[] value is used for this purpose. JMS providers without native correlation ID values are not required to support byte[] values*. The use of a byte[] value for JMSCorrelationID is non-portable. * Their implementation of setJMSCorrelationIDAsBytes() and getJMSCorrelationIDAsBytes() may throw java.lang.UnsupportedOperationException" So, the following constructor should rely on the application-specific String as JMSCorrelationID and handle UnsupportedOperationException : /** * A copy constructor for non-JBoss Messaging JMS messages. */ public JBossMessage(Message foreign, long messageID) throws JMSException { super(messageID); setJMSTimestamp(foreign.getJMSTimestamp()); try { byte[] corrIDBytes = foreign.getJMSCorrelationIDAsBytes(); setJMSCorrelationIDAsBytes(corrIDBytes); } catch(JMSException e) { // specified as String String corrIDString = foreign.getJMSCorrelationID(); if (corrIDString != null) { setJMSCorrelationID(corrIDString); } } setJMSReplyTo(foreign.getJMSReplyTo()); setJMSDestination(foreign.getJMSDestination()); setJMSDeliveryMode(foreign.getJMSDeliveryMode()); setJMSExpiration(foreign.getJMSExpiration()); setJMSPriority(foreign.getJMSPriority()); setJMSType(foreign.getJMSType()); for (Enumeration props = foreign.getPropertyNames(); props.hasMoreElements(); ) { String name = (String)props.nextElement(); Object prop = foreign.getObjectProperty(name); this.setObjectProperty(name, prop); } } was: JavaTM Message Service Specification Version 1.1 : " 3.4.5 JMSCorrelationID A client can use the JMSCorrelationID header field to link one message with another. A typical use is to link a response message with its request message. JMSCorrelationID can hold one of the following: • A provider-specific message ID • An application-specific String • A provider-native byte[] value Since each message sent by a JMS provider is assigned a message ID value, it is convenient to link messages via message ID. All message ID values must start with the 'ID:' prefix. In some cases, an application (made up of several clients) needs to use an application-specific value for linking messages. For instance, an application may use JMSCorrelationID to hold a value referencing some external information. Application-specified values must not start with the 'ID:' prefix; this is reserved for provider-generated message ID values. If a provider supports the native concept of correlation ID, a JMS client may need to assign specific JMSCorrelationID values to match those expected by non-JMS clients. A byte[] value is used for this purpose. JMS providers without native correlation ID values are not required to support byte[] values*. The use of a byte[] value for JMSCorrelationID is non-portable. * Their implementation of setJMSCorrelationIDAsBytes() and getJMSCorrelationIDAsBytes() may throw java.lang.UnsupportedOperationException" So, the following constructor should rely on the application-specific String as JMSCorrelationID and handle UnsupportedOperationException : /** * A copy constructor for non-JBoss Messaging JMS messages. */ public JBossMessage(Message foreign, long messageID) throws JMSException { super(messageID); setJMSTimestamp(foreign.getJMSTimestamp()); try { byte[] corrIDBytes = foreign.getJMSCorrelationIDAsBytes(); setJMSCorrelationIDAsBytes(corrIDBytes); } catch(JMSException e) { // specified as String String corrIDString = foreign.getJMSCorrelationID(); if (corrIDString != null) { setJMSCorrelationID(corrIDString); } } setJMSReplyTo(foreign.getJMSReplyTo()); setJMSDestination(foreign.getJMSDestination()); setJMSDeliveryMode(foreign.getJMSDeliveryMode()); setJMSExpiration(foreign.getJMSExpiration()); setJMSPriority(foreign.getJMSPriority()); setJMSType(foreign.getJMSType()); for (Enumeration props = foreign.getPropertyNames(); props.hasMoreElements(); ) { String name = (String)props.nextElement(); Object prop = foreign.getObjectProperty(name); this.setObjectProperty(name, prop); } } I changed the title and added a short description so it's more obvious what this JIRA is about. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMESSAGING-1617?page=com.atlassian.ji... ] Howard Gao reopened JBMESSAGING-1617: ------------------------------------- Reopen because it drops an existing functionality and will cause backward compatibility issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMESSAGING-1617?page=com.atlassian.ji... ] Howard Gao reopened JBMESSAGING-1617: ------------------------------------- As discussed with Tim, the current fix, which adds a catch of UnsupportedOperationException, will have big perf impact when the foreign message doesn't support the bytesID. The better way to do is making it an optional behavior by introducing a property into the fix. Re-open it for the new solution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMESSAGING-1617?page=com.atlassian.ji... ] Howard Gao reopened JBMESSAGING-1617: ------------------------------------- It's already done but it keeps in the unresolved list. try to reopen and close it again. See if that fix the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira