11:09 a.m.
Thomas Diesler created AS7-3556:
-----------------------------------
Summary: Replace mocked subsystem model tests with functional tests
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: Thomas Diesler
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:30 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
Thomas Diesler reassigned AS7-3556:
-----------------------------------
Assignee: (was: Thomas Diesler)
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
Thomas Diesler reassigned AS7-3556:
-----------------------------------
Assignee: David Bosschaert
David, I'd like to discuss with you how the subsystem is supposed to behave on these
various DM operations. The tests should then verify and document the behaviour.
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: David Bosschaert
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:24 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
David Bosschaert commented on AS7-3556:
---------------------------------------
Thomas, could you please list the test classes involved so I can be sure we're talking
about the same thing?
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: David Bosschaert
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:53 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
Thomas Diesler commented on AS7-3556:
-------------------------------------
Sure, here they are
{code}
$ git grep AS7-3556
osgi/service/src/test/java/org/jboss/as/osgi/parser/ActivateOperationTestCase.java://@Ignore("[AS7-3556]
Replace mocked subsystem model tes
osgi/service/src/test/java/org/jboss/as/osgi/parser/ActivationWriteHandlerTestCase.java://@Ignore("[AS7-3556]
Replace mocked subsystem mode
osgi/service/src/test/java/org/jboss/as/osgi/parser/BundleRuntimeHandlerTestCase.java://@Ignore("[AS7-3556]
Replace mocked subsystem model
osgi/service/src/test/java/org/jboss/as/osgi/parser/OSGiCapabilityAddRemoveTestCase.java:@Ignore("[AS7-3556]
Replace mocked subsystem model
osgi/service/src/test/java/org/jboss/as/osgi/parser/OSGiFrameworkPropertyAddRemoveTestCase.java://@Ignore("[AS7-3556]
Replace mocked subsys
osgi/service/src/test/java/org/jboss/as/osgi/parser/ResourceAddRemoveTestBase.java://@Ignore("[AS7-3556]
Replace mocked subsystem model tes
osgi/service/src/test/java/org/jboss/as/osgi/parser/StartLevelHandlerTestCase.java://@Ignore("[AS7-3556]
Replace mocked subsystem model tes
osgi/service/src/test/java/org/jboss/as/osgi/parser/SubsystemStateTestCase.java:@Ignore("[AS7-3556]
Replace mocked subsystem model tests wi
{code}
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: David Bosschaert
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:03 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
David Bosschaert commented on AS7-3556:
---------------------------------------
These unit tests are actually quite valuable. They test the inner workings of these
classes and therefore mock out their environment.
However I do see value in providing additional system tests for the OSGi subsystem
management. Shall we rename this bug to 'Add system tests for OSGi subsystem
model'?
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: David Bosschaert
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:59 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
Thomas Diesler commented on AS7-3556:
-------------------------------------
The value of these tests would disappear once the functional tests are in place.
Currently, some are broken and ignored.
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: David Bosschaert
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:57 p.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
David Bosschaert commented on AS7-3556:
---------------------------------------
I see that OSGiCapabilityAddRemoveTestCase and SubsystemStateTestCase are ignored and
possibly broken. The other tests are running as normal AFAICS.
{quote}The value of these tests would disappear once the functional tests are in
place{quote}
Basically what you're saying here is that unit tests aren't useful any more once
you have system tests in place. I disagree with that.
On the other hand I would be more than happy fixing the broken tests and adding some extra
system tests if that works for you.
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: David Bosschaert
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:44 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
Thomas Diesler reassigned AS7-3556:
-----------------------------------
Assignee: Thomas Diesler (was: David Bosschaert)
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: Thomas Diesler
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:46 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
Thomas Diesler updated AS7-3556:
--------------------------------
Fix Version/s: 7.1.2.Final
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: Thomas Diesler
Fix For: 7.1.2.Final
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:05 a.m.
[
https://issues.jboss.org/browse/AS7-3556?page=com.atlassian.jira.plugin.s...
]
Thomas Diesler reassigned AS7-3556:
-----------------------------------
Assignee: David Bosschaert (was: Thomas Diesler)
Initial test template added
https://github.com/jbossas/jboss-as/pull/1711
Replace mocked subsystem model tests with functional tests
----------------------------------------------------------
Key: AS7-3556
URL: https://issues.jboss.org/browse/AS7-3556
Project: Application Server 7
Issue Type: Task
Components: OSGi
Reporter: Thomas Diesler
Assignee: David Bosschaert
Fix For: 7.1.2.Final
There are a number of tests that heavily use mocked objects and attempt to verify correct
operations on the OSGi subsystem domain model. These should be replaced with functional
tests that run against a managed server and verify that the subsystem actually behaves as
intended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4693
days inactive
4727
days old
10 comments
2 participants
participants (2)
-
David Bosschaert (JIRA) -
Thomas Diesler (JIRA)