[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Jason Greene updated AS7-1893: ------------------------------ Fix Version/s: 7.1.0.CR1 (was: 7.1.0.Beta1) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Richard Achmatowicz commented on AS7-1893: ------------------------------------------ I almost certainly don't have time to get to this. What I propose is that Tristan rework his original implementation as described above, and then I can have a look at trying to incorporate it before the deadline. I'm finishing off the other stores (store, file-store, remote-store) in the next day or so. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Jason Greene updated AS7-1893: ------------------------------ Fix Version/s: 7.1.2.Final (was: 7.1.1.Final) This issue is being relocated to 7.1.2 so that 7.1.1 only contains criticals, blockers, and EAP LA issues (which are probably not yet at the right status, or need an extra triage pass). If these issues are completed in a 7.1.1 timeframe please change the fix version. Although if you forget I will bulk correct. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Richard Achmatowicz edited comment on AS7-1893 at 2/26/12 7:48 PM: ------------------------------------------------------------------- Manik, Paul Tristan set up the JDBC store configuration in such a way that: - if you define an entry table only, you get a string based store - if you define a bucket table only, you get a binary based store - if you define both types of tables, you get a mixed store I assume you would rather see something which makes the creation of the different types of stores more explicit, such as: {noformat} <!-- define a string-based store --> <string-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= > <string-keyed-table ...> ... </string-keyed-table> <string-keyed-jdbc-store> <!-- define a binary-based store --> <binary-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= > <binary-keyed-table ...> ... </binary-keyed-table> <binary-keyed-jdbc-store> <!-- define a mixed store --> <mixed-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= > <string-keyed-table ...> ... </string-keyed-table> <binary-keyed-table ...> ... </binary-keyed-table> <mixed-keyed-jdbc-store> {noformat} As you point out, in the current implementation, one can specify specific details for the underlying database tables, such as column names and column types, and table name prefixes. When you say that the current implementation exposes implementation details, do you mean that you simply want to change the names so that we aren't tied to a particular implementation, but keep the underlying implementation the same (i.e. get rid of the word bucket-table and replace it with binary-keyed-table, but use a bucket-based cache store anyway). Also, is the exposure to TableManipulation attributes ok as is? In other words, retain the ability to set the column names and types for each column? was (Author: rachmato): Manik, Paul Tristan set up the JDBC store configuration in such a way that: - if you define an entry table only, you get a string based store - if you define a bucket table only, you get a binary based store - if you define both types of tables, you get a mixed store I assume you would rather see something which makes the creation of the different types of stores more explicit, such as: {noformat} <!-- define a string-based store --> <string-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= > <string-keyed-table ...> ... </string-keyed-table> <string-keyed-jdbc-store> <!-- define a binary-based store --> <binary-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= > <binary-keyed-table ...> ... </binary-keyed-table> <binary-keyed-jdbc-store> <!-- define a mixed store --> <mixed-keyed-jdbc-store fetch-state= passivation= preload= purge= shared= singleton= > <string-keyed-table ...> ... </string-keyed-table> <binary-keyed-table ...> ... </binary-keyed-table> <mixed-keyed-jdbc-store> {noformat} As you point out, in the current implementation, one can specify specific details for the underlying database tables, such as column names and column types, and table name prefixes. When you say that the current implementation exposes implementation details, do you mean that you simply want to change the names so that we aren't tied to a particular implementation, but keep the underlying implementation the same (i.e. get rid of the word bucket-table and replace it with binary-keyed-table, but use a bucket-based cache store anyway). Also, is the exposure to TableManipulation attributes ok as is? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Kabir Khan commented on AS7-1893: --------------------------------- I'm testing https://github.com/jbossas/jboss-as/pull/1691. As mentioned I'd like to see some tests for these new attributes in the subsystem itself, but will pull the changes if they pass since Tristan mentioned he needs them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Kabir Khan commented on AS7-1893: --------------------------------- I opened my eyes and see the test changes now :-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Martin Gencur commented on AS7-1893: ------------------------------------ One more thing.. I'm looking at https://github.com/rachmatowicz/jboss-as/commit/9fed5aad5faacde351966d15f... and https://github.com/rachmatowicz/jboss-as/commit/9fed5aad5faacde351966d15f... and I see a problem. When we have XSD types for all three jdbc cache stores (string-keyed-jdbc-store, binary-keyed-jdbc-store and mixed-keyed-jdbc-store), I would suppose that when I use mixed-keyed-jdbc-store, I can really only create mixed jdbc cache store from it. However, from the code logic it seems that when a user specifies mixed-keyed-jdbc-store and inside that only binary-keyed-table, they will actually get binary jdbc cache store (the same for string-based one when they specify only string-keyed-table). I would suppose here that the XSD will say that binary-keyed-table has minOccurs=1 and maxOccurs=1 as well as string-keyed-table (they have "0" now): https://github.com/rachmatowicz/jboss-as/blob/9fed5aad5faacde351966d15f11... WDYT? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1893?page=com.atlassian.jira.plugin.s... ] Richard Achmatowicz commented on AS7-1893: ------------------------------------------ OK, i'll have a look. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira