[JBoss JIRA] Created: (JGRP-644) Shared transport: add cluster name to thread name for easier logging
3:10 a.m.
Shared transport: add cluster name to thread name for easier logging
--------------------------------------------------------------------
Key: JGRP-644
URL: http://jira.jboss.com/jira/browse/JGRP-644
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assigned To: Bela Ban
Priority: Optional
Fix For: 2.7
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:04 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-644) Shared transport: add cluster name to thread name for easier logging
[ http://jira.jboss.com/jira/browse/JGRP-644?page=all ]
Bela Ban updated JGRP-644:
--------------------------
Fix Version/s: 2.6.3
Shared transport: add cluster name to thread name for easier logging
--------------------------------------------------------------------
Key: JGRP-644
URL: http://jira.jboss.com/jira/browse/JGRP-644
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assigned To: Bela Ban
Priority: Optional
Fix For: 2.7, 2.6.3
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:58 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-644) Shared transport: add cluster name to thread name for easier logging
[ http://jira.jboss.com/jira/browse/JGRP-644?page=comments#action_12409722 ]
Vladimir Blagojevic commented on JGRP-644:
------------------------------------------
Are you referring to renaming of a thread that pushes message up the stack on a particular
shared transport? For example, if a thread pushes message up the stack on a singleton
"udp" then "udp" should be appended to a thread name?
Shared transport: add cluster name to thread name for easier logging
--------------------------------------------------------------------
Key: JGRP-644
URL: http://jira.jboss.com/jira/browse/JGRP-644
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assigned To: Bela Ban
Priority: Optional
Fix For: 2.7, 2.6.3
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:10 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-644) Shared transport: add cluster name to thread name for easier logging
[ http://jira.jboss.com/jira/browse/JGRP-644?page=comments#action_12409831 ]
Michael Newcomb commented on JGRP-644:
--------------------------------------
Suggest using a log for each protocol for each cluster.
Currently:
log = LogFactory.getLog(getClass())
Change to:
OnConnect:
log = LogFactory.getLog(getClass() + "." + <channel_name>)
OnDisconnect:
log = LogFactory.getLog(getClass())
If a typical JChannel stack setup has 'L' number of Log objects, it will now have
(N + 1) * L Log objects.
I'm willing to pay this memory price for the increased readability of the logs in a
shared-transport / multiple-JChannel environment.
It might be ugly, but perhaps a common flag in Protocol/Transport to have a Log object for
each cluster? Then it could check in up/down for the connect/disconnect events and set the
Log appropriately?
This would require adding some generic code to Protocol.up/down to handle these events and
then going through and ensuring that all subclasses of Protocol call super.up/down, which
alot don't, as they just call down_prot.up/down themselves...
Michael
Shared transport: add cluster name to thread name for easier logging
--------------------------------------------------------------------
Key: JGRP-644
URL: http://jira.jboss.com/jira/browse/JGRP-644
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assigned To: Bela Ban
Priority: Optional
Fix For: 2.7, 2.6.3
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:38 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-644) Shared transport: add cluster name to thread name for easier logging
[ http://jira.jboss.com/jira/browse/JGRP-644?page=comments#action_12413956 ]
Bela Ban commented on JGRP-644:
-------------------------------
This doesn't work for the shared transport where the transport protocol possibly
serves more than 1 channel, so we cannot append the cluster name to it.
I recently made some changes to thread naming:
#1 Default thread naming
- Each thread has the local address and cluster name appended, depending on the
thread_naming_pattern (default: "cl") in the transport. If ou include the thread
name in your log config, this should give you exactly what you want
# Shared transport thread naming
- All threads in the transport (default thread pool, OOB thread pool, timer thread pool)
are named with an increasing ID and the local address, e.g. Timer-1,192.168.1.5:4673. We
cannot append the cluster name, as a shared transport serves multiple channels (a.k.a
clusters)
- All threads *above* the transport (e.g. FD_SOCK server socket handler thread) are named
as in the default case, with local address and cluster name appended
Shared transport: add cluster name to thread name for easier logging
--------------------------------------------------------------------
Key: JGRP-644
URL: http://jira.jboss.com/jira/browse/JGRP-644
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assigned To: Bela Ban
Priority: Optional
Fix For: 2.7, 2.6.3
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:53 a.m.
New subject: [JBoss JIRA] Resolved: (JGRP-644) Shared transport: add cluster name to thread name for easier logging
[ http://jira.jboss.com/jira/browse/JGRP-644?page=all ]
Bela Ban resolved JGRP-644.
---------------------------
Resolution: Rejected
All threads now have the cluster name appened (thread_naming_pattern="cl"), so
one can set logging to include the thread name and then grep for all log statements for a
given cluster.
The suggested solution adds overhead, so I rejected it.
Shared transport: add cluster name to thread name for easier logging
--------------------------------------------------------------------
Key: JGRP-644
URL: http://jira.jboss.com/jira/browse/JGRP-644
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assigned To: Bela Ban
Priority: Optional
Fix For: 2.6.3, 2.7
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6076
days inactive
6240
days old
5 comments
3 participants
participants (3)
-
Bela Ban (JIRA) -
Michael Newcomb (JIRA)
-
Vladimir Blagojevic (JIRA)