[ https://issues.jboss.org/browse/AS7-430?page=com.atlassian.jira.plugin.sy... ] Farah Juma commented on AS7-430: -------------------------------- Created a new branch: https://github.com/fjuma/jboss-as/commits/AS7-430_refactored This is a refactored version of my original implementation to allow discovery options to be specified using a generic untyped configuration instead of a typed configuration. In particular, the <discovery-options> element can now have any number of <discovery-option> children. A <discovery-option> specifies: - a class that implements the DiscoveryOption interface (note: the module that contains this class can optionally be specified as well) - key/value properties for the particular discovery option Sample Configuration - Slave host controller (note: this example configures only S3 discovery): {code:xml} <remote security-realm="ManagementRealm"> <discovery-options> <discovery-option name="option-one" code="org.jboss.as.host.controller.discovery.S3Discovery"> <property name="access-key" value="s3_access_key"/> <property name="secret-access-key" value="s3_secret_access_key"/> <property name="location" value="s3_bucket_name"/> </discovery-option> </discovery-options> </remote> {code} The remote domain controller's host and port can also still be statically configured, exactly as before. Additional static discovery options can also be provided via the <discovery-option> element, as follows: Slave host controller (note: this example configures multiple static discovery options): {code:xml} <remote host="${jboss.domain.master.address}" port="${jboss.domain.master.port:9999}" security-realm="ManagementRealm"> <discovery-options> <discovery-option name="backup-hc-one" code="org.jboss.as.host.controller.discovery.StaticDiscovery"> <property name="host" value="172.16.81.100"/> <property name="port" value="9999"/> </discovery-option> <discovery-option name="backup-hc-two" code="org.jboss.as.host.controller.discovery.StaticDiscovery"> <property name="host" value="172.16.81.101"/> <property name="port" value="9999"/> </discovery-option> </discovery-options> </remote> {code} Should I close the existing pull request (https://github.com/jbossas/jboss-as/pull/3593) that uses a typed configuration and open a new one for this refactored version instead? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira