[JBoss JIRA] Created: (JBRULES-1970) Error expanding DSL when #-Character is in right-side of dsl-property
4:49 a.m.
Error expanding DSL when #-Character is in right-side of dsl-property
---------------------------------------------------------------------
Key: JBRULES-1970
URL: https://jira.jboss.org/jira/browse/JBRULES-1970
Project: JBoss Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-compiler
Affects Versions: 5.0.0.M5
Environment: Eclipse 3.4, jre6u10, WinXp
Reporter: Norbert Ziegler
Assignee: Mark Proctor
Having a line in a DSL like following:
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("#UML-ATZ-1") <
$p.getZvUmlStfr() )
Using "Bedingung-19-MKM4" in the LHS of a rule "Regel-151" in an
dslr-File I get the following 3 errors:
[12] Unable to expand: Bedingung-19-MKM4
[ERR 103] Line 201:2 no viable alternative at input 'Bedingung' in rule
"Regel-151"
Unknown error while parsing. This is a bug. Please contact the Development team.
The problem is the #-Character. If you change the line to
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("UML-ATZ-1") <
$p.getZvUmlStfr() )
it works. But that's not what I need.
Hint: maybe this is related to (JBRULES-1960) Syntaxcoloring wrong if DSLR contains a
"#"-Character.
But in this case it's more important because it's not an "optical"
problem only.
By the way: if I use the value #UML-ATZ-1 as an argument / placeholder it works (thank
God, need this often). But using a placeholder is not what I need.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:20 a.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-1970) Error expanding DSL when #-Character is in right-side of dsl-property
[
https://jira.jboss.org/jira/browse/JBRULES-1970?page=com.atlassian.jira.p...
]
Edson Tirelli resolved JBRULES-1970.
------------------------------------
Fix Version/s: 5.0.0.CR1
Resolution: Done
Assignee: Edson Tirelli (was: Mark Proctor)
Ok, I see the problem and I fixed it in CR1. Although, for now, I would like to keep the
ability of adding comments not only as the first character in the line, as suggested by
JBRULES-1960. So, # is handled as a special character in the grammar and as so, it
requires escaping. The grammar mapping would be:
[condition][]Bedingung-\#19-MKM4 = eval ( $p.getTempVal("\#UML-ATZ-1") <
$p.getZvUmlStfr() )
Please note that I added a # on the left side of your expression just to make sure it
works there too, and both are escaped as any regexp special character. The escaping is
only required for the grammar, obviously, and does not affect the way users write the
sentences.
The following test case shows the example:
public void testExpandWithPound() throws IOException {
final String inputKey = "Bedingung-\\#19-MKM4";
final String inputValue = "eval ( $p.getTempVal(\"\\#UML-ATZ-1\")
< $p.getZvUmlStfr() )";
DSLMappingEntry entry = createEntry( inputKey,
inputValue );
assertEquals( "(\\W|^)Bedingung-#19-MKM4(\\W|$)",
entry.getKeyPattern().toString() );
assertEquals( "$1eval ( \\$p.getTempVal(\"#UML-ATZ-1\") <
\\$p.getZvUmlStfr() )$2",
entry.getValuePattern());
String result = entry.getKeyPattern().matcher( "Bedingung-#19-MKM4"
).replaceAll( entry.getValuePattern() );
assertEquals( result,
"eval ( $p.getTempVal(\"#UML-ATZ-1\") <
$p.getZvUmlStfr() )",
result );
}
Let me know if that fix the problem for you.
Thank you for reporting and providing example.
Edson
Error expanding DSL when #-Character is in right-side of
dsl-property
---------------------------------------------------------------------
Key: JBRULES-1970
URL: https://jira.jboss.org/jira/browse/JBRULES-1970
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-compiler
Affects Versions: 5.0.0.M5
Environment: Eclipse 3.4, jre6u10, WinXp
Reporter: Norbert Ziegler
Assignee: Edson Tirelli
Fix For: 5.0.0.CR1
Having a line in a DSL like following:
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("#UML-ATZ-1") <
$p.getZvUmlStfr() )
Using "Bedingung-19-MKM4" in the LHS of a rule "Regel-151" in an
dslr-File I get the following 3 errors:
[12] Unable to expand: Bedingung-19-MKM4
[ERR 103] Line 201:2 no viable alternative at input 'Bedingung' in rule
"Regel-151"
Unknown error while parsing. This is a bug. Please contact the Development team.
The problem is the #-Character. If you change the line to
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("UML-ATZ-1") <
$p.getZvUmlStfr() )
it works. But that's not what I need.
Hint: maybe this is related to (JBRULES-1960) Syntaxcoloring wrong if DSLR contains a
"#"-Character.
But in this case it's more important because it's not an "optical"
problem only.
By the way: if I use the value #UML-ATZ-1 as an argument / placeholder it works (thank
God, need this often). But using a placeholder is not what I need.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1970) Error expanding DSL when #-Character is in right-side of dsl-property
[
https://jira.jboss.org/jira/browse/JBRULES-1970?page=com.atlassian.jira.p...
]
Norbert Ziegler commented on JBRULES-1970:
------------------------------------------
Thanks for solving in CR1.
So two things to be mentioned:
a) if escaping the "#" in the right side (value) of the dsl-property solves my
problem than this is ok for me and saves time for doing some dirty workaround.
b) Need confirmation of your sentence "...The escaping is only required for the
grammar, obviously, and does not affect the way users write the sentences. .."
If I understand it right, than the user still can use # in the rule (dslr)-file without
escaping it?
This is essential for me and works now.
E.g. a line of my dslr:
Berechne #ENTG-ZUSBEI-ATZ-AN als Personenfeld ZvAtzVzBetr holen - Rechenfeld
#ENTG-ZUSBEI-ATZ-AG holen
wich is mapped to technical stuff by some dsl-properties as follows:
[*][]Rechenfeld {tmpname} holen = $p.getTempVal("{tmpname}")
[*][]Personenfeld {variablenname} holen = $p.get{variablenname}()
[consequence][]Berechne {variable} als {numerischerWert} =
$p.setTempVal("{variable}", {numerischerWert});
and the result today is (and should be after your change)
$p.setTempVal("#ENTG-ZUSBEI-ATZ-AN", $p.getZvAtzVzBetr() -
$p.getTempVal("#ENTG-ZUSBEI-ATZ-AG"));
Can you please confirm that b) still works?
As I just see CR1 is available now for download. I could swear yesterday it wasn't...
I'll try it.
Btw: one should change the "Released"-Column in your download-Page which still
points to 10th Dec. 2008 which is wrong / irritating since M5.
Thanks and kind regards,
Norbert
Error expanding DSL when #-Character is in right-side of
dsl-property
---------------------------------------------------------------------
Key: JBRULES-1970
URL: https://jira.jboss.org/jira/browse/JBRULES-1970
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-compiler
Affects Versions: 5.0.0.M5
Environment: Eclipse 3.4, jre6u10, WinXp
Reporter: Norbert Ziegler
Assignee: Edson Tirelli
Fix For: 5.0.0.CR1
Having a line in a DSL like following:
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("#UML-ATZ-1") <
$p.getZvUmlStfr() )
Using "Bedingung-19-MKM4" in the LHS of a rule "Regel-151" in an
dslr-File I get the following 3 errors:
[12] Unable to expand: Bedingung-19-MKM4
[ERR 103] Line 201:2 no viable alternative at input 'Bedingung' in rule
"Regel-151"
Unknown error while parsing. This is a bug. Please contact the Development team.
The problem is the #-Character. If you change the line to
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("UML-ATZ-1") <
$p.getZvUmlStfr() )
it works. But that's not what I need.
Hint: maybe this is related to (JBRULES-1960) Syntaxcoloring wrong if DSLR contains a
"#"-Character.
But in this case it's more important because it's not an "optical"
problem only.
By the way: if I use the value #UML-ATZ-1 as an argument / placeholder it works (thank
God, need this often). But using a placeholder is not what I need.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:09 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1970) Error expanding DSL when #-Character is in right-side of dsl-property
[
https://jira.jboss.org/jira/browse/JBRULES-1970?page=com.atlassian.jira.p...
]
Norbert Ziegler commented on JBRULES-1970:
------------------------------------------
I tried your fix with CR1 and it works.
So the above mentioned 2 points a) and b) are ok: a) works now after replacing # by \# in
the right side of the property-file, b) still works.
But now a new problem occurs!
I do not now if it has been a bug or a feature in earlier release, but now it does not
work anymore.
Problem as follows:
I wanted to generate a linebreak, so the value in the dsl-File contained an \n
Example:
[consequence][]this is a test {expression} with result {result} = IF {expression} \n THEN
\n PRINT {result} \n END-IF
Before I got 4 lines. Now the result is a single line where simple that \n is replaced
with the letter "n", no linebreak anymore.
Think this a consequence of this fix.
Question now: is there any way to generate linebreaks using a dsl?
In the Drools-doc you write:
<<<
chapter 7.10.3. Using a DSL in your rules
...You can also have the resulting rule expressions span lines...
<<<
but you do not explain how.
Please let me know and if necessary open a new bug.
Error expanding DSL when #-Character is in right-side of
dsl-property
---------------------------------------------------------------------
Key: JBRULES-1970
URL: https://jira.jboss.org/jira/browse/JBRULES-1970
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-compiler
Affects Versions: 5.0.0.M5
Environment: Eclipse 3.4, jre6u10, WinXp
Reporter: Norbert Ziegler
Assignee: Edson Tirelli
Fix For: 5.0.0.CR1
Having a line in a DSL like following:
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("#UML-ATZ-1") <
$p.getZvUmlStfr() )
Using "Bedingung-19-MKM4" in the LHS of a rule "Regel-151" in an
dslr-File I get the following 3 errors:
[12] Unable to expand: Bedingung-19-MKM4
[ERR 103] Line 201:2 no viable alternative at input 'Bedingung' in rule
"Regel-151"
Unknown error while parsing. This is a bug. Please contact the Development team.
The problem is the #-Character. If you change the line to
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("UML-ATZ-1") <
$p.getZvUmlStfr() )
it works. But that's not what I need.
Hint: maybe this is related to (JBRULES-1960) Syntaxcoloring wrong if DSLR contains a
"#"-Character.
But in this case it's more important because it's not an "optical"
problem only.
By the way: if I use the value #UML-ATZ-1 as an argument / placeholder it works (thank
God, need this often). But using a placeholder is not what I need.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:42 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1970) Error expanding DSL when #-Character is in right-side of dsl-property
[
https://jira.jboss.org/jira/browse/JBRULES-1970?page=com.atlassian.jira.p...
]
Edson Tirelli commented on JBRULES-1970:
----------------------------------------
It was definitively possible to add line breaks and should still be. Can you please open a
new ticket? Lets not reopen this one because it goes into the release reports, but lets
link both together.
I will look at this as soon as possible.
Thanks,
Edson
Error expanding DSL when #-Character is in right-side of
dsl-property
---------------------------------------------------------------------
Key: JBRULES-1970
URL: https://jira.jboss.org/jira/browse/JBRULES-1970
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-compiler
Affects Versions: 5.0.0.M5
Environment: Eclipse 3.4, jre6u10, WinXp
Reporter: Norbert Ziegler
Assignee: Edson Tirelli
Fix For: 5.0.0.CR1
Having a line in a DSL like following:
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("#UML-ATZ-1") <
$p.getZvUmlStfr() )
Using "Bedingung-19-MKM4" in the LHS of a rule "Regel-151" in an
dslr-File I get the following 3 errors:
[12] Unable to expand: Bedingung-19-MKM4
[ERR 103] Line 201:2 no viable alternative at input 'Bedingung' in rule
"Regel-151"
Unknown error while parsing. This is a bug. Please contact the Development team.
The problem is the #-Character. If you change the line to
[condition][]Bedingung-19-MKM4 = eval ( $p.getTempVal("UML-ATZ-1") <
$p.getZvUmlStfr() )
it works. But that's not what I need.
Hint: maybe this is related to (JBRULES-1960) Syntaxcoloring wrong if DSLR contains a
"#"-Character.
But in this case it's more important because it's not an "optical"
problem only.
By the way: if I use the value #UML-ATZ-1 as an argument / placeholder it works (thank
God, need this often). But using a placeholder is not what I need.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5782
days inactive
5808
days old
4 comments
2 participants
participants (2)
-
Edson Tirelli (JIRA) -
Norbert Ziegler (JIRA)