12:06 p.m.
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: http://jira.jboss.com/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Reporter: John Ruud
Assigned To: Koen Aers
Priority: Blocker
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to be
able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:06 p.m.
New subject: [JBoss JIRA] Updated: (GPD-79) ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
[ http://jira.jboss.com/jira/browse/GPD-79?page=all ]
John Ruud updated GPD-79:
-------------------------
Component/s: jpdl
Affects Version/s: jBPM JPDL Designer 3.1.0.alpha4
Priority: Major (was: Blocker)
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: http://jira.jboss.com/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Components: jpdl
Affects Versions: jBPM JPDL Designer 3.1.0.alpha4
Reporter: John Ruud
Assigned To: Koen Aers
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to
be able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:21 a.m.
New subject: [JBoss JIRA] Updated: (GPD-79) ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
[ http://jira.jboss.com/jira/browse/GPD-79?page=all ]
Koen Aers updated GPD-79:
-------------------------
Fix Version/s: jBPM JPDL Designer 3.1.0.beta2
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: http://jira.jboss.com/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Components: jpdl
Affects Versions: jBPM JPDL Designer 3.1.0.alpha4
Reporter: John Ruud
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.beta2
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to
be able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:24 a.m.
New subject: [JBoss JIRA] Commented: (GPD-79) ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
[ http://jira.jboss.com/jira/browse/GPD-79?page=comments#action_12369662 ]
Koen Aers commented on GPD-79:
------------------------------
Hi John,
I don't understand why you had to do this. Node types are only used to determine the
order of the xml elements. They absolutely do not serve any purpose with respect to the
palette.
Can you elaborate on this?
Regards,
Koen
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: http://jira.jboss.com/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Components: jpdl
Affects Versions: jBPM JPDL Designer 3.1.0.alpha4
Reporter: John Ruud
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.beta2
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to
be able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:59 p.m.
New subject: [JBoss JIRA] Resolved: (GPD-79) ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
[ http://jira.jboss.com/jira/browse/GPD-79?page=all ]
John Ruud resolved GPD-79.
--------------------------
Resolution: Cannot Reproduce Bug
Koen,
I believe there used to be some validation done before nodes got added to the diagram, and
this prevented my nodes from being added to the diagram unless they were included in the
NODE_TYPES list. However, I can no longer reproduce this (after removing my node types
from the list things still work in beta2).
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: http://jira.jboss.com/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Components: jpdl
Affects Versions: jBPM JPDL Designer 3.1.0.alpha4
Reporter: John Ruud
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.beta2
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to
be able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:53 a.m.
New subject: [JBoss JIRA] Closed: (GPD-79) ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
[ http://jira.jboss.com/jira/browse/GPD-79?page=all ]
Koen Aers closed GPD-79.
------------------------
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: http://jira.jboss.com/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Components: jpdl
Affects Versions: jBPM JPDL Designer 3.1.0.alpha4
Reporter: John Ruud
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.beta2
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to
be able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4 p.m.
New subject: [JBoss JIRA] Reopened: (GPD-79) ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
[ http://jira.jboss.com/jira/browse/GPD-79?page=all ]
John Ruud reopened GPD-79:
--------------------------
It looks like the problem is back in GPD 3.1.2 (I'm synced up with the
branch_jbpm_jpdl_gpd_3_1_x branch of jbpm.3/designer/jpdl/org.jbpm.gd.jpdl). The following
exception is written to the Eclipse error log once I drop any of my custom nodes (earlier
selected from the palette) onto the diagram.
java.lang.NullPointerException
at org.jbpm.gd.common.xml.XmlAdapter.isNodeOfType(XmlAdapter.java:225)
at org.jbpm.gd.common.xml.XmlAdapter.getFirstNode(XmlAdapter.java:240)
at org.jbpm.gd.common.xml.XmlAdapter.hasNode(XmlAdapter.java:259)
at org.jbpm.gd.common.xml.XmlAdapter.addElement(XmlAdapter.java:77)
at org.jbpm.gd.common.xml.XmlAdapter.addElement(XmlAdapter.java:383)
at
org.jbpm.gd.jpdl.xml.ProcessDefinitionDomAdapter.doPropertyChange(ProcessDefinitionDomAdapter.java:120)
at org.jbpm.gd.common.xml.XmlAdapter.propertyChange(XmlAdapter.java:481)
at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:339)
at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:276)
at
org.jbpm.gd.common.model.AbstractSemanticElement.firePropertyChange(AbstractSemanticElement.java:20)
at org.jbpm.gd.jpdl.model.ProcessDefinition.addNodeElement(ProcessDefinition.java:81)
at org.jbpm.gd.jpdl.command.NodeCreateCommand.addAbstractNode(NodeCreateCommand.java:42)
at org.jbpm.gd.jpdl.command.NodeCreateCommand.execute(NodeCreateCommand.java:35)
at org.eclipse.gef.commands.CommandStack.execute(CommandStack.java:149)
at org.eclipse.gef.tools.AbstractTool.executeCommand(AbstractTool.java:388)
at org.eclipse.gef.tools.AbstractTool.executeCurrentCommand(AbstractTool.java:400)
at org.eclipse.gef.tools.CreationTool.performCreation(CreationTool.java:254)
at org.eclipse.gef.tools.CreationTool.handleButtonUp(CreationTool.java:178)
at org.eclipse.gef.tools.AbstractTool.mouseUp(AbstractTool.java:1053)
at org.eclipse.gef.EditDomain.mouseUp(EditDomain.java:259)
at
org.eclipse.gef.ui.parts.DomainEventDispatcher.dispatchMouseReleased(DomainEventDispatcher.java:374)
at org.eclipse.draw2d.LightweightSystem$EventHandler.mouseUp(LightweightSystem.java:538)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:206)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3682)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3293)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
at org.eclipse.equinox.launcher.Main.run(Main.java:1173)
at org.eclipse.equinox.launcher.Main.main(Main.java:1148)
Adding the mapping for my custom node (NODE_TYPES.put("decide",
"node-element")) to ProcessDefinitionDomAdapter.getNodeTypes() resolved the
problem. I can also reproduce the problem by for example removing the hardcoded mapping
for 'state', and then attemping to add a new 'state' to the diagram from
the palette.
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: http://jira.jboss.com/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Components: jpdl
Affects Versions: jBPM JPDL Designer 3.1.0.alpha4
Reporter: John Ruud
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.beta2
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to
be able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:26 p.m.
New subject: [JBoss JIRA] Resolved: (GPD-79) ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
[
https://jira.jboss.org/jira/browse/GPD-79?page=com.atlassian.jira.plugin....
]
Koen Aers resolved GPD-79.
--------------------------
Resolution: Out of Date
The 3.2 branch will be discontinued in favor of the 4 branch.
ProcessDefinitionDomAdapter.NODE_TYPES should not be hardcoded
--------------------------------------------------------------
Key: GPD-79
URL: https://jira.jboss.org/jira/browse/GPD-79
Project: JBoss jBPM GPD
Issue Type: Bug
Components: jpdl
Affects Versions: jBPM JPDL Designer 3.1.0.alpha4
Reporter: John Ruud
Assignee: Koen Aers
I had to add my custom node types to ProcessDefinitionDomAdapter.NODE_TYPES in order to
be able to add the nodes from the palette. It would be helpful if
ProcessDefinitionDomAdapter.NODE_TYPES could get populated from an extension point instead
(similar to: org.jbpm.gd.jpdl.notationMappings). This change is probably already planned,
just attempting to bump it up on the priority list slightly as it's something I'm
currently using
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5846
days inactive
6455
days old
7 comments
2 participants
participants (2)
-
John Ruud (JIRA) -
Koen Aers (JIRA)