[ https://issues.jboss.org/browse/AS7-2703?page=com.atlassian.jira.plugin.s... ] Jason Greene updated AS7-2703: ------------------------------ Priority: Blocker (was: Major) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2703?page=com.atlassian.jira.plugin.s... ] Scott Marlow commented on AS7-2703: ----------------------------------- https://github.com/scottmarlow/jboss-as/commit/bce74f9775efe37977e1ad2be8... contains the changes for AS7-2703 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2703?page=com.atlassian.jira.plugin.s... ] Jason Greene updated AS7-2703: ------------------------------ Fix Version/s: 7.1.0.Final (was: 7.1.0.CR1) Priority: Major (was: Blocker) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2703?page=com.atlassian.jira.plugin.s... ] Stuart Douglas commented on AS7-2703: ------------------------------------- Up until recently interceptor state was not serialised at all. https://github.com/jbossas/jboss-as/commit/0fcc66c325b021104e57167fe4c350... shows the approach I have taken with CDI interceptors, and https://github.com/jbossas/jboss-as/commit/fbb585a70adcac1e0c33f4446e0a1b... is the commit that added the general serialization support. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2703?page=com.atlassian.jira.plugin.s... ] Stuart Douglas commented on AS7-2703: ------------------------------------- But the way the code base is currently when the SFSB is replicated it will get a new interceptor that will have the SFSBXPCMap as per normal, I don't see why all the serialization is necessary when it should be possible to re-create the interceptors on the target node without any additional information. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2703?page=com.atlassian.jira.plugin.s... ] Stuart Douglas commented on AS7-2703: ------------------------------------- The SFSB service name is serialised, which is used to get the StatefulSessionComponent, which has enough info to re-create the interceptors. This happens at the Serialisation level, it should not matter wether it is being serialised for passivation or replication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2703?page=com.atlassian.jira.plugin.s... ] Scott Marlow commented on AS7-2703: ----------------------------------- I'm closing this jira and reverting the JPA interceptor "serialization" changes. {quote} <smarlow> stuartdouglas: regarding AS7-2703, are you saying that interceptors are not serialized with the StatefulSessionComponent, so I may as well not bother making the JPA interceptors serializable? <jbossbot> jira [AS7-2703] clustering task, JPA interceptors should be serializable [Open (Unresolved) Sub-task, Major, Scott Marlow] https://issues.jboss.org/browse/AS7-2703 <stuartdouglas> yes <stuartdouglas> ~ a week ago I noticed that no interceptors were being serialized <stuartdouglas> so I changed things so that now user level interceptors serialise their state <stuartdouglas> but not container level interceptors, cause they all seem to be basically stateless <stuartdouglas> or at least container only transient state that can be re-created by simply re-creating the interceptor <stuartdouglas> have a look at org.jboss.as.ejb3.component.stateful.SerializedStatefulSessionComponent * smarlow looking <stuartdouglas> StatefulSessionComponentInstance has a writeReplace that returns one of those <stuartdouglas> it just contains the SFSB service name, the serialised instance, and the serialised interceptor state <stuartdouglas> when it is de-serialized a new instance is created, but it re-uses the de-serialized instance and interceptor state <stuartdouglas> and does not call the post construct chain <smarlow> stuartdouglas: when the component.constructComponentInstance is invoked, is that like creating the SFSB for the first time otherwise (except for the post construct)? <stuartdouglas> basically <stuartdouglas> it will re-create all interceptors <stuartdouglas> but the serialised interceptors are already in the InterceptorFactoryContext, so they are not re-created <stuartdouglas> (and any interceptor can serialise data using that mechanism if it needs to, although at the moment none of them do, except for the JSR299BindingsInterceptor) {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira