[JBoss JIRA] Created: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
4:18 a.m.
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 4.0.3
Reporter: Brian Stiles
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:58 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12397517 ]
Jan Boboli commented on JBRULES-1392:
-------------------------------------
I run into a similar problem, and analyzed your issue.
it happens because VariableRestriction$VariableContextEntry Class is storing
InternalWorkingMemory locally, and is shared within threads, which have concurrent access
to this class.
Put the breakpoint in debugger in the class LongVariableContextEntry in method
"updateFromTuple" and in variables window you will see that among different
threads:
-this (refering to LongVariableContextEntry) is pointing to the same object
-workingMemory is pointing to different objects (with different id and address)
This issue should be a blocker, because it proves that drools is not reliable in
multithreaded environments.
Similar problem exists in DroolsMVELFactory which is also shared among different threads
and ReturnValueContextEntry.
Regards,
Jan Boboli
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.0.3
Reporter: Brian Stiles
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:52 a.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=all ]
Edson Tirelli reassigned JBRULES-1392:
--------------------------------------
Assignee: Edson Tirelli
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12397591 ]
Edson Tirelli commented on JBRULES-1392:
----------------------------------------
Thank you both for reporting the problem and providing test case and analysis.
I just fixed the context entry problem in trunk. I will double check the DroolsMVELFactory
problem before closing the ticket.
Once I have fixed trunk, we will backport the fix to 4.0.x branch.
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:45 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=all ]
Edson Tirelli updated JBRULES-1392:
-----------------------------------
Component/s: Reteoo
Priority: Blocker (was: Major)
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:48 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12397593 ]
Brian Stiles commented on JBRULES-1392:
---------------------------------------
Fantastic! Thanks!
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:18 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12397787 ]
Jan Boboli commented on JBRULES-1392:
-------------------------------------
Cool!
I saw you changed a lot of classes to resolve problem. Tnank you for your quick response.
I think you should also check following calsses for potential concurrent access:
-MVELPredicateExpression
-DroolsMVELPreviousDeclarationVariable
-LocalVariableResolver
-MVELReturnValueExpression
Thanks again,
Jan Boboli
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:35 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12397789 ]
Edson Tirelli commented on JBRULES-1392:
----------------------------------------
Yes, still working on them. One difficult I had is to create a test that reproduces the
error (for the DroolsMVELFactory). I see the code has the potential problem and I'm
fixing it, but having a test to add to our integration tests would be great.
Are you able to create such a test?
The test provided was a good one and I will add to our test base, but it checks the
constraint context part only.
Thanks
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:49 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12397930 ]
Jan Boboli commented on JBRULES-1392:
-------------------------------------
i will try to make such test.
Jan
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:41 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12397988 ]
Edson Tirelli commented on JBRULES-1392:
----------------------------------------
I think that now I covered all (hopefully) scenarios around the use of constraint contexts
and the DroolsMVELFactory.
Fernando will backport that do 4.0.x and SOA-P.
If you are reviewing my changes, let me know plz if I missed anything.
Thanks a lot for reporting and helping find the solution.
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:43 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=all ]
Jan Boboli updated JBRULES-1392:
--------------------------------
Attachment: DroolsMVELFactoryProject.zip
I've attached the sample eclipse project that reproduces the problem with concurrent
access to DroolsMVELFactory.
Clasess Aaa, Bbb, Ccc extends BaseObject.
BaseObject has a property "parent" which points to a parent BaseObject.
Objects are inserted in different threads, in the following way:
- object of class Aaa has no parent
- object of class Aaa is a parent to Bbb;
- object of class Bbb is a parent to Ccc
In the rule "DroolsMVELFactoryRule", in LHS part of the rule,
object of class Aaa is binded to Ccc.parent.parent .
During the insertion of the objects, NPE occurs beause of concurrent access to
DroolsMVELFactory class.
NPE occurs, because drools attempt to resolve parent.parent of Aaa class.
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:17 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12398245 ]
Edson Tirelli commented on JBRULES-1392:
----------------------------------------
Jan,
Thanks for that. I ran your test against 4.0.x and saw the exceptions. Then I run against
(fixed) trunk and saw no problems anymore. So, my understanding is that the fixes worked.
As soon as the changes are backported to 4.0.x branch, we will do a release.
Thanks for providing the test case.
Edson
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:30 p.m.
New subject: [JBoss JIRA] Closed: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=all ]
Fernando Meyer closed JBRULES-1392.
-----------------------------------
Fix Version/s: 4.0.5
5.0.0-M1
Resolution: Done
Patch Applied
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 4.0.5, 5.0.0-M1
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:23 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399031 ]
Navaljit Bhasin commented on JBRULES-1392:
------------------------------------------
Thanks for fixing this issue.
Need your help.
How can I download the patch ? If I download 4.04 from the download section, will it have
patch applied to it ?
Inother words how do I get updated jar files 4.04 version ( with patch fixed ).
This was really a show stopper for us. I am glad you guys took the initiative and fixed it
! Kudos !
I will like to try this fix on our environement. I had posted this bug 2 months ago. Will
let you know how if it' resolved !!!
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:25 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399037 ]
Edson Tirelli commented on JBRULES-1392:
----------------------------------------
You need to checkout source code from here:
http://anonsvn.labs.jboss.com/labs/jbossrules/branches/4.0.x/
Build the jars following the instructions in the manual.
4.0.5 will be released probably next week, so if you can check and let us know if it works
for you before that, we can make sure that if there is any missing scenario, we can fix
and include in 4.0.5.
Edson
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:28 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399045 ]
Navaljit Bhasin commented on JBRULES-1392:
------------------------------------------
I tried compiling from the link
http://anonsvn.labs.jboss.com/labs/jbossrules/branches/4.0.x/
Never used maven before:
Here's what I used
mvn clean install
However the build is failing with following error.
Results :
Failed tests:
testDirectory(org.drools.agent.RuleAgentTest)
testNotRemoveIdentities(org.drools.reteoo.CrossProductTest)
Tests run: 460, Failures: 2, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] There are test failures.
[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.BuildFailureException: There are test failures.
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(Defa
ultLifecycleExecutor.java:560)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLi
fecycle(DefaultLifecycleExecutor.java:480)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.forkProjectLifecy
cle(DefaultLifecycleExecutor.java:896)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.forkLifecycle(Def
aultLifecycleExecutor.java:734)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(Defa
ultLifecycleExecutor.java:510)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandalone
Goal(DefaultLifecycleExecutor.java:493)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(Defau
ltLifecycleExecutor.java:463)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHan
dleFailures(DefaultLifecycleExecutor.java:311)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegmen
ts(DefaultLifecycleExecutor.java:224)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLi
fecycleExecutor.java:143)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:333)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:126)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:282)
at jrockit.reflect.InitialMethodInvoker.invoke(Ljava.lang.Object;[Ljava.
lang.Object;)Ljava.lang.Object;(Unknown Source)
at java.lang.reflect.Method.invoke(Ljava.lang.Object;[Ljava.lang.Object;
I)Ljava.lang.Object;(Unknown Source)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures
.
at org.apache.maven.plugin.surefire.SurefirePlugin.execute(SurefirePlugi
n.java:425)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPlugi
nManager.java:447)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(Defa
ultLifecycleExecutor.java:539)
... 18 more
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24 seconds
[INFO] Finished at: Sun Feb 10 17:05:57 EST 2008
[INFO] Final Memory: 23M/64M
[INFO] ------------------------------------------------------------------------
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:43 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399046 ]
Navaljit Bhasin commented on JBRULES-1392:
------------------------------------------
I have excluded the tests using
mvn assembly:assembly -Dmaven.test.skip clean install
Now the new error is as follows.
Since I am running into errors, I really don't waant to waste your valuable time. Is
it possible for you to mail me a zip file of the jar files build with the updated code ?
Thanks a lot.
Downloading: http://people.apache.org/repo/m2-snapshot-repository/org/drools/dro
ols-core/4.0.3.SNAPSHOT/drools-core-4.0.3.SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.
Missing:
----------
1) org.drools:drools-core:jar:4.0.3.SNAPSHOT
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=org.drools -DartifactId=drools-core -Dv
ersion=4.0.3.SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=org.drools -DartifactId=drools-core -Dver
sion=4.0.3.SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -Drepositor
yId=[id]
Path to dependency:
1) org.drools:drools-compiler:jar:4.0.3.SNAPSHOT
2) org.drools:drools-core:jar:4.0.3.SNAPSHOT
----------
1 required artifact is missing.
for artifact:
org.drools:drools-compiler:jar:4.0.3.SNAPSHOT
from the specified remote repositories:
Maven Snapshots (http://snapshots.maven.codehaus.org/maven2/),
central (http://repo1.maven.org/maven2),
softeu-repo (http://maven.softeu.cz/),
jboss-snapshot (http://snapshots.jboss.org/maven2),
apache.org (http://people.apache.org/repo/m2-snapshot-repository),
basedir (file://C:\TEMP\drools_4x\drools-compiler/../m2_repo),
jboss (http://repository.jboss.com/maven2/)
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5 seconds
[INFO] Finished at: Sun Feb 10 18:35:30 EST 2008
[INFO] Final Memory: 42M/64M
[INFO] ------------------------------------------------------------------------
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:51 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399292 ]
Navaljit Bhasin commented on JBRULES-1392:
------------------------------------------
Hi there.
Let me know if you can mail me the jar files( with fix) ( in zip). I really want to test
multithreading issues in our application before you release 4.05.
Thanks for your help.
-Nav
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:42 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399315 ]
Jan Boboli commented on JBRULES-1392:
-------------------------------------
Navalit- you need to get the whole project from svn, and then build it with maven, it will
work.
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:49 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399317 ]
Jan Boboli commented on JBRULES-1392:
-------------------------------------
We still have some issues that appear in our project :
- strings are broken - i.e. if we have a string that represents date or a number, after
running many rules the strings are broken - they consist random values. We are trying to
reproduce the problem in a single project, but it's very difficult .
- we also observed, that some rules fire that didn't fire before and shouldn't
fire, we are also trying to reproduce it in a single project.
Jan
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:55 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399338 ]
Edson Tirelli commented on JBRULES-1392:
----------------------------------------
Navaljit,
Just follow this steps:
svn checkout http://anonsvn.labs.jboss.com/labs/jbossrules/branches/4.0.x/ drools-4.0.x
cd drools-4.0.x
mvn -Dmaven.test.skip clean install
It must work.
The zip is big to send by e-mail. Let me know if you still have problems.
Thanks,
Edson
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:05 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399456 ]
Edson Tirelli commented on JBRULES-1392:
----------------------------------------
I opened a related ticket http://jira.jboss.com/jira/browse/JBRULES-1467 to handle the
date conversion fix.
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1392) Rules behave incorrectly (randomly) in multi-threaded environment
[ http://jira.jboss.com/jira/browse/JBRULES-1392?page=comments#action_12399669 ]
Navaljit Bhasin commented on JBRULES-1392:
------------------------------------------
Hi Edson,
I am able to compile and create the jar files.
But it seems there is some issue with drools on linux platform.
I replaced the following jar files in my project with the corresponding snapshot jar
files.
10,293 drools-ant-4.0.3.jar
10,557 drools-ant-4.0.3.SNAPSHOT.jar
553,326 drools-compiler-4.0.3.jar
563,621 drools-compiler-4.0.3.SNAPSHOT.jar
1,066,794 drools-core-4.0.3.jar
1,083,609 drools-core-4.0.3.SNAPSHOT.jar
78,186 drools-decisiontables-4.0.3.jar
78,327 drools-decisiontables-4.0.3.SNAPSHOT.jar
23,496 drools-jsr94-4.0.3.jar
23,581 drools-jsr94-4.0.3.SNAPSHOT.jar
I removed above mentioned 4.0.3 from project ear file. ie the ear file has only
SNAPSHOT.jar versions.
The drl file compiles ok on local windows desktop. However on linux server ( where I am
testing multithreading), I am getting following compilation error. This exception is not
thrown if I rollback to 4.0.3 jar files. [But 4.0.3 had the multithreading issue ]
org.mvel.CompileException: Failed to compile:
[Error: can not resolve identifier: name]
[Near: { ... nam ... } ]
at
org.mvel.MVELInterpretedRuntime.parseAndExecuteInterpreted(MVELInterpretedRuntime.java:193)
at org.mvel.MVELInterpretedRuntime.parse(MVELInterpretedRuntime.java:58)
at org.mvel.TemplateInterpreter.execute(TemplateInterpreter.java:410)
at org.mvel.TemplateInterpreter.execute(TemplateInterpreter.java:345)
at org.mvel.TemplateInterpreter.eval(TemplateInterpreter.java:109)
at org.mvel.TemplateInterpreter.evalToString(TemplateInterpreter.java:74)
at
org.drools.rule.builder.dialect.java.JavaFunctionBuilder.build(JavaFunctionBuilder.java:96)
at org.drools.rule.builder.dialect.java.JavaDialect.addFunction(JavaDialect.java:436)
at org.drools.compiler.PackageBuilder.addFunction(PackageBuilder.java:406)
at org.drools.compiler.PackageBuilder.addPackage(PackageBuilder.java:289)
at org.drools.compiler.PackageBuilder.addPackageFromDrl(PackageBuilder.java:167)
Any clues ?
Let me know if you have checked in a fix for this. I will recompile and retest.
Thanks a lot !
Rules behave incorrectly (randomly) in multi-threaded environment
-----------------------------------------------------------------
Key: JBRULES-1392
URL: http://jira.jboss.com/jira/browse/JBRULES-1392
Project: JBoss Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Reteoo
Affects Versions: 4.0.3
Reporter: Brian Stiles
Assigned To: Edson Tirelli
Priority: Blocker
Fix For: 5.0.0-M1, 4.0.5
Attachments: DroolsMVELFactoryProject.zip
Rules behave seemingly indeterminately when sessions are created from the same RuleBase
and executed in multiple threads. The problem is a bit difficult to reproduce. The
following code demonstrates the behavior in my environment (single processor PowerBook),
but not on every try. I've had up to 5 consecutive executions not exhibit the problem
before the failure was exhibited, so you may need to run the class a number of times to
see the problem. Also, I periodically get OutOfMemoryErrors when using the default heap
size (64m). I've had better success with -Xmx256m. That, by the way, is suspiciously
coincidental to the random nature of the incorrect rule firing problem.
I've experienced this behavior in my application, and it manifests by rules firing
from time to time that shouldn't have fired. I can't see a pattern to the rules
that fire inappropriately, and there absolutely were not facts asserted that would support
the firing of the rule.
Synchronizing the calls to insert, fireAllRules, and dispose on the session object seems
to get rid of the problem, giving further evidence to the guess that it's a
multithreading bug.
Please, please, please find a solution to this problem. This will be a serious
scalability problem for my application. I'm more than happy to help however I can.
I've stepped through Drools code before and found solutions, but I really don't
know where to go with this one.
Following is the code (self-contained class with main method) that I've used to
demonstrate the problem.
Thank you!
--
package sample;
import java.io.StringReader;
import java.util.ArrayList;
import org.drools.RuleBase;
import org.drools.RuleBaseConfiguration;
import org.drools.RuleBaseFactory;
import org.drools.StatefulSession;
import org.drools.compiler.PackageBuilder;
import org.drools.compiler.PackageBuilderConfiguration;
public class MultithreadedRuleBaseProblem {
public static void main(String[] args) throws Exception {
final PackageBuilderConfiguration packageBuilderConfiguration =
new PackageBuilderConfiguration();
final PackageBuilder packageBuilder = new
PackageBuilder(packageBuilderConfiguration);
packageBuilder.addPackageFromDrl(new StringReader("\n"
+ "package sample\n"
+ "\n"
+ "import java.lang.Integer;\n"
+ "global java.util.ArrayList shouldFireList;\n"
+ "global java.util.ArrayList shouldNotFireList;\n"
+ "\n"
+ "rule should_fire\n"
+ " when\n"
+ " $e : Integer(intValue == -1)\n"
+ " $f : Integer(intValue > $e)\n"
+ " then \n"
+ " shouldFireList.add($f);\n"
+ "end \n"
+ "\n"
+ "rule should_not_fire\n"
+ " when\n"
+ " $f : String()\n"
+ " then \n"
+ " shouldNotFireList.add($f);\n"
+ "end \n"));
final RuleBaseConfiguration ruleBaseConfiguration = new RuleBaseConfiguration();
final RuleBase ruleBase = RuleBaseFactory.newRuleBase(ruleBaseConfiguration);
ruleBase.addPackage(packageBuilder.getPackage());
final Exception[] exception = {
null
};
final Thread t[] = new Thread[50];
for (int i = 0; i < t.length; i++) {
final int count = i;
t[i] = new Thread(new Runnable() {
public void run() {
try {
System.out.println("Start " + count);
final int iterations = count * 15 + 3000;
final ArrayList shouldFireList = new ArrayList();
final ArrayList shouldNotFireList = new ArrayList();
final StatefulSession session2 = ruleBase.newStatefulSession();
session2.setGlobal("shouldFireList", shouldFireList);
session2.setGlobal("shouldNotFireList",
shouldNotFireList);
session2.insert(new Integer(- 1));
for (int k = 0; k < iterations; k++) {
session2.insert(new Integer(k));
}
session2.insert("foo");
System.out.println("Fire " + count);
session2.fireAllRules();
session2.dispose();
if (shouldFireList.size() != iterations) {
System.out.println("Thread "
+ count
+ " shouldFireList.size(): expected "
+ iterations
+ " was "
+ shouldFireList.size()
+ "\n!!!!! Thread "
+ count
+ " rule didn't fire as many times as it
should have!!!!!!!!!!!!!!!!!!");
}
} catch (Exception e) {
e.printStackTrace();
exception[0] = e;
}
System.out.println("Thread " + count + " done");
}
});
t[i].start();
}
for (int i = 0; i < t.length; i++) {
t[i].join();
}
System.out.println("done");
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6187
days inactive
6248
days old
22 comments
5 participants
participants (5)
-
Brian Stiles (JIRA) -
Edson Tirelli (JIRA)
-
Fernando Meyer (JIRA)
-
Jan Boboli (JIRA)
-
Navaljit Bhasin (JIRA)