[ http://jira.jboss.com/jira/browse/JBAS-5626?page=comments#action_12416957 ] Jeff Zhang commented on JBAS-5626: ---------------------------------- fix ClasspathUnitTestCase.testLibServlet by commit -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5626?page=comments#action_12417876 ] Anil Saldhana commented on JBAS-5626: ------------------------------------- JBAS-5645 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5626?page=comments#action_12418678 ] Dimitris Andreadis commented on JBAS-5626: ------------------------------------------ This usually has to do with a previous failing test not cleaning up properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5626?page=comments#action_12418998 ] Jeff Zhang commented on JBAS-5626: ---------------------------------- it seems be fixed on latest hudson tests: http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... [junit] Running org.jboss.test.web.test.UserInRoleUnitTestCase [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 2.097 sec -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-5626?page=com.atlassian.jira.plug... ] Jeff Zhang commented on JBAS-5626: ---------------------------------- Look inside today CookieUnitTestCase: The failed reason is the cookie include "commented" attribute, (see the comment in CookieUnitTestCase "//RFC2109:Note that there is no Comment attribute"). The strange is I tested both on tomcat 6 and tomcat 5.5, deploy jbosstest-cookie.war, the "commented" attributes are all set .But the test can be passed on Jboss Beta4 and RC1 EncAnnotationsUnitTestCase: The test failed after Aug.14. The exception track: 14:34:22,853 ERROR [[ENCServlet]] Allocate exception for servlet ENCServlet javax.naming.NameNotFoundException: jboss not bound at org.jnp.server.NamingServer.getBinding(NamingServer.java:564) at org.jnp.server.NamingServer.getBinding(NamingServer.java:572) at org.jnp.server.NamingServer.getObject(NamingServer.java:578) at org.jnp.server.NamingServer.lookup(NamingServer.java:317) at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:669) at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:629) at javax.naming.InitialContext.lookup(InitialContext.java:351) at org.jnp.interfaces.NamingContext.resolveLink(NamingContext.java:1251) at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:760) at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:629) at org.jboss.ejb3.JndiUtil.lookup(JndiUtil.java:44) at org.jboss.injection.JndiPropertyInjector.lookup(JndiPropertyInjector.java:75) at org.jboss.injection.JndiPropertyInjector.inject(JndiPropertyInjector.java:99) at org.jboss.web.tomcat.service.TomcatInjectionContainer.processInjectors(TomcatInjectionContainer.java:354) at org.jboss.web.tomcat.service.TomcatInjectionContainer.newInstance(TomcatInjectionContainer.java:239) at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1006) at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:777) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:129) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:189) at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:90) at org.jboss.web.tomcat.security.SecurityContextEstablishmentValve.invoke(SecurityContextEstablishmentValve.java:96) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.jboss.web.tomcat.service.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:157) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:325) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:828) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:601) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447) at java.lang.Thread.run(Thread.java:595) It seems some code changed (in org.jboss.web.tomcat.service) caused failing. I will continue looking them. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-5626?page=com.atlassian.jira.plug... ] Dimitris Andreadis commented on JBAS-5626: ------------------------------------------ Yes please, after watching the game with Lithuania :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-5626?page=com.atlassian.jira.plug... ] Jeff Zhang commented on JBAS-5626: ---------------------------------- last fix was fail since servlet 2.5 Cookie.java disallow "comment" attribute: public Cookie(String name, String value) { if (!isToken(name) || name.equalsIgnoreCase("Comment") // rfc2019 ... || name.startsWith("$") ) { String errMsg = lStrings.getString("err.cookie_name_is_token"); Object[] errArgs = new Object[1]; errArgs[0] = name; errMsg = MessageFormat.format(errMsg, errArgs); throw new IllegalArgumentException(errMsg); } ... } So I disable "comment" attribute in the cookie for test passing, I will read the servlet 2.5 spec and RFC2109 if got time and re-fix this issue again -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira