8:26 a.m.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:28 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Jeremy Whiting updated AS7-3276:
--------------------------------
Attachment: npe-valve-logging-patch.diff
a diff of the changes.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:18 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Anil Saldhana commented on AS7-3276:
------------------------------------
Jeremy, put in a pull request to AS7, with the changes.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:22 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Jeremy Whiting commented on AS7-3276:
-------------------------------------
Anil, Ok I will do that.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:24 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Remy Maucherat commented on AS7-3276:
-------------------------------------
Casting a null object does not cause a NPE. The NPE will only occur if there's no
session.
Since right above, there's session = manager.findSession(hsession.getId()), a if
(session != null) should be enough.
I'd suggest removing the big try/catch(throwable) and logging a debug info. That's
not funny.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:07 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Jeremy Whiting updated AS7-3276:
--------------------------------
Steps to Reproduce:
Attach a debugger to the AS7. Wait for the server to start. Add an exception breakpoint
for java.lang.NullPointerException
Use a browser to request a resource in a deployed web application. The debugger will trap
on the NPE in the valve.
was:
Attach a debugger to the AS7. Wait for the server to start. Add an exception breakpoint
for java.lang.NullPointerException
Hit the default web address to see the index page. The debugger will trap on the NPE in
the valve.
http://localhost:8080/
Forum Reference: https://community.jboss.org/thread/38213?tstart=0 (was:
https://community.jboss.org/thread/38213?tstart=0)
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:02 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Jeremy Whiting commented on AS7-3276:
-------------------------------------
Yes I see what you mean. I will add only a null check for the session.
Shouldn't the catch block be logging an warn instead of debug or info ?
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:23 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Remy Maucherat commented on AS7-3276:
-------------------------------------
I don't know what is the best strategy for this particular exception handling, but
logging debug is not good when you get an unexpected throwable. Normally, if you get that,
the exception falls through, the request will fail, everything is recycled, and the user
gets disconnected.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:12 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Jeremy Whiting updated AS7-3276:
--------------------------------
Git Pull Request: https://github.com/jbossas/jboss-as/pull/1088
Forum Reference: https://community.jboss.org/thread/38213?tstart=0 (was:
https://community.jboss.org/thread/38213?tstart=0)
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:20 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Jeremy Whiting commented on AS7-3276:
-------------------------------------
A pull request has been created. I have omitted to change the level of the logging. To
avoid having users seeing warn messages that can be confusing as to severity of the
message. Instead I added a TODO to highlight it needing a decision later.
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 a.m.
[
https://issues.jboss.org/browse/AS7-3276?page=com.atlassian.jira.plugin.s...
]
Remy Maucherat resolved AS7-3276.
---------------------------------
Fix Version/s: 7.1.0.Final
Resolution: Done
NPE thrown in SecurityContextAssociationValve.
----------------------------------------------
Key: AS7-3276
URL: https://issues.jboss.org/browse/AS7-3276
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.0.CR1b
Environment: On any platform running Java.
OpenJDK 6.
Reporter: Jeremy Whiting
Assignee: Remy Maucherat
Labels: patch
Fix For: 7.1.0.Final
Attachments: npe-valve-logging-patch.diff
With a debugger attached to AS7 I am seeing a NullPointerException thrown in a JBoss
implementation of a Valve. This happens on every web request that does not have a
principle in the session. The exception type has never appeared in logs because it is
caught and a generic message is displayed.
This affects the performance.
Also the class uses the debugf logging method in the catch block. But does not pass in a
format. A format is expected as the first parameter to the debugf method.
Included with this JIRA is a patch to change the code so that null references are
detected. The second change changes the logging method call to instead use debug. Whether
it should be a error message rather than a debug is a different matter and this JIRA does
not tackle the question.
Regards,
Jeremy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4665
days inactive
4685
days old
10 comments
5 participants
participants (5)
-
Anil Saldhana (JIRA) -
Jeremy Whiting (Created) (JIRA)
-
Jeremy Whiting (JIRA)
-
Jeremy Whiting (Updated) (JIRA)
-
Remy Maucherat (JIRA)