[ https://issues.jboss.org/browse/AS7-1473?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse commented on AS7-1473: --------------------------------------- Additional information captured for the accidental redeploy. The testFilesystemDeployment test reaches the stage where undeploy is called, a temporary System.out records: - {noformat} Fri Aug 05 12:17:08 BST 2011 Deleted .deployed {noformat} This message is only logged if the call to delete returns true. The following lines are then logged: - {noformat} 12:17:08,102 TRACE [org.jboss.as.deployment] (DeploymentScanner-threads - 1) Scan complete 12:17:09,102 TRACE [org.jboss.as.deployment] (DeploymentScanner-threads - 2) Scanning directory /home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/deployments for deployment content changes 12:17:09,102 TRACE [org.jboss.as.controller] (DeploymentScanner-threads - 2) Executing "read-children-names" undefined 12:17:09,104 TRACE [org.jboss.as.controller] (DeploymentScanner-threads - 2) Prepared response is { "outcome" => undefined, "result" => [ "arquillian-service", "please-the-arquillian-gods.jar", "test-deployment.sar" ] } 12:17:09,114 DEBUG [org.jboss.as.deployment] (DeploymentScanner-threads - 2) Deployment scan of [/home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/deployments] found update action [{ "operation" => "full-replace-deployment", "address" => undefined, "name" => "test-deployment.sar", "content" => [{ "path" => "/home/darranl/src/jbossas7/jboss-as/testsuite/smoke/target/deployments/test-deployment.sar", "archive" => true }] }] 12:17:09,114 TRACE [org.jboss.as.controller] (DeploymentScanner-threads - 1) Executing "composite" undefined {noformat} So for some reason it appears that the deletion of the .deployed is mistakenly taken as a redeployment instead of an undeployment. The testExplodedFilesystemDeployment test is then the test that routinely fails as it's first deploy step triggers an undeployment which it mistakenly takes for the first deployment being complete and then fails as the deployment is not yet ready. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1473?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse updated AS7-1473: ---------------------------------- Attachment: org.jboss.as.test.surefire.servermodule.ServerInModuleDeploymentTestCase-output.txt Adding full output from failed run. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1473?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse commented on AS7-1473: --------------------------------------- The unexpected redeploy instead of undeploy actually occurs because the cached timestamp for the deployment is 0L - i.e. whatever file the timestamp was read from it did not exist at the time of the reading. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1473?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse commented on AS7-1473: --------------------------------------- Trying to run the test in a loop is now returning the following error: - {noquote} 12:42:06,930 ERROR [org.jboss.as.controller] (pool-2-thread-5) Operation ("add") failed - address: ([ ("subsystem" => "deployment-scanner"), ("scanner" => "zips") ]): org.jboss.msc.service.DuplicateServiceException: Service jboss.server.deployment.scanner.zips.path is already registered at org.jboss.msc.service.ServiceRegistrationImpl.setInstance(ServiceRegistrationImpl.java:154) at org.jboss.msc.service.ServiceControllerImpl.startInstallation(ServiceControllerImpl.java:226) at org.jboss.msc.service.ServiceContainerImpl.install(ServiceContainerImpl.java:560) at org.jboss.msc.service.ServiceTargetImpl.install(ServiceTargetImpl.java:201) {noquote} For some reason the removal of the service does not seem complete so the subsequent test fails. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1473?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse updated AS7-1473: ---------------------------------- Summary: Fix errors causing intermittent failures of ServerInModuleDeploymentTestCase (was: Deleting .deployed occasionaly file is deployed again immediately after undeployment.) Description: After some in-depth investigation a number of issues have been identified as causing the intermittent failures to the ServerInModuleDeploymentTestCase test case. 1 - The in-memory cached modified time for a deployment can be corrupted if the .deployed marker is deleted after it is written but before the modified time is cached. 2 - Multiple calls after a deployment can cause a .deployed marker to be written, however external processes waiting for the presence of this file so that it can be deleted can delete it after the first of these calls but before the subsequent call. The end result is that the process thinks it has deleted the file but in some circumstances it is just written again! 3 - The test was written before zipped archives were automatically deployed but not updated - the test case should test the correct behaviour for automatic zip deployment and deployment based on marker files. In addition to this modifications to the test revealed that once a deployment scanner has been removed there is an error if there is an attempt to add a new deployment scanner using a name used previously. was: Currently investigating the ServerInModuleDeploymentTestCase intermittent failures and this seems to be the common cause of the failure. The testFilesystemDeployment test undeploys the deployment at the end but for some reason it is deployed again, testExplodedFilesystemDeployment then fails as when it attempts to deploy it actually triggers a redeployment but is only expecting a single JMX notification. Complexity: High -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-1473?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse resolved AS7-1473. ----------------------------------- Resolution: Done -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira