10:48 a.m.
Sanne Grinovero created JGRP-1418:
-------------------------------------
Summary: Avoid outoboxing on org.jgroups.stack.AckSenderWindow.get(long)
Key: JGRP-1418
URL: https://issues.jboss.org/browse/JGRP-1418
Project: JGroups
Issue Type: Enhancement
Reporter: Sanne Grinovero
Assignee: Bela Ban
In certain scenarios the org.jgroups.stack.AckSenderWindow.get(long) method is invoked
frequently, and each long is converted in a Long, becoming an allocation hotspot.
I'm wondering if the ConcurrentNavigableMap used in AckSenderWindow could be converted
in a more primitive-friendly collection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:50 a.m.
[
https://issues.jboss.org/browse/JGRP-1418?page=com.atlassian.jira.plugin....
]
Sanne Grinovero commented on JGRP-1418:
---------------------------------------
Ah, maybe this is unnecessary after moving to UNICAST2 ?
Avoid outoboxing on org.jgroups.stack.AckSenderWindow.get(long)
---------------------------------------------------------------
Key: JGRP-1418
URL: https://issues.jboss.org/browse/JGRP-1418
Project: JGroups
Issue Type: Enhancement
Reporter: Sanne Grinovero
Assignee: Bela Ban
In certain scenarios the org.jgroups.stack.AckSenderWindow.get(long) method is invoked
frequently, and each long is converted in a Long, becoming an allocation hotspot.
I'm wondering if the ConcurrentNavigableMap used in AckSenderWindow could be
converted in a more primitive-friendly collection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:03 a.m.
[
https://issues.jboss.org/browse/JGRP-1418?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1418:
---------------------------
Fix Version/s: 3.1
I'll take a look. Optimized structures will be tackled in
https://issues.jboss.org/browse/JGRP-1394.
I'm fairly certain I can make retransmission in UNICAST and UNICAST2 similar to
NAKACK2, so we wouldn't need ARW and ASW anymore...
Avoid outoboxing on org.jgroups.stack.AckSenderWindow.get(long)
---------------------------------------------------------------
Key: JGRP-1418
URL: https://issues.jboss.org/browse/JGRP-1418
Project: JGroups
Issue Type: Enhancement
Reporter: Sanne Grinovero
Assignee: Bela Ban
Fix For: 3.1
In certain scenarios the org.jgroups.stack.AckSenderWindow.get(long) method is invoked
frequently, and each long is converted in a Long, becoming an allocation hotspot.
I'm wondering if the ConcurrentNavigableMap used in AckSenderWindow could be
converted in a more primitive-friendly collection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:44 a.m.
[
https://issues.jboss.org/browse/JGRP-1418?page=com.atlassian.jira.plugin....
]
Bela Ban resolved JGRP-1418.
----------------------------
Resolution: Out of Date
JGRP-1419 will replace all NakreceiverWindows, AckSenderWindows and AckReceiverWindows
with Table<Message>, so this issue is moot
Avoid outoboxing on org.jgroups.stack.AckSenderWindow.get(long)
---------------------------------------------------------------
Key: JGRP-1418
URL: https://issues.jboss.org/browse/JGRP-1418
Project: JGroups
Issue Type: Enhancement
Reporter: Sanne Grinovero
Assignee: Bela Ban
Fix For: 3.1
In certain scenarios the org.jgroups.stack.AckSenderWindow.get(long) method is invoked
frequently, and each long is converted in a Long, becoming an allocation hotspot.
I'm wondering if the ConcurrentNavigableMap used in AckSenderWindow could be
converted in a more primitive-friendly collection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:11 p.m.
[
https://issues.jboss.org/browse/JGRP-1418?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1418:
--------------------------------
Replaced AckSenderWindow (sender) and NakReceiverWindow (receiver) in UNICAST2 with
Table<Message>, this obsoleted this issue. Will also replace AckSenderWindow in
UNICAST with Table<Message>, then we can remove AckSenderWindow altogether !
Avoid outoboxing on org.jgroups.stack.AckSenderWindow.get(long)
---------------------------------------------------------------
Key: JGRP-1418
URL: https://issues.jboss.org/browse/JGRP-1418
Project: JGroups
Issue Type: Enhancement
Reporter: Sanne Grinovero
Assignee: Bela Ban
Fix For: 3.1
In certain scenarios the org.jgroups.stack.AckSenderWindow.get(long) method is invoked
frequently, and each long is converted in a Long, becoming an allocation hotspot.
I'm wondering if the ConcurrentNavigableMap used in AckSenderWindow could be
converted in a more primitive-friendly collection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4638
days inactive
4643
days old
4 comments
2 participants
participants (2)
-
Bela Ban (JIRA) -
Sanne Grinovero (JIRA)