[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Emanuel Muckenhuber updated JBAS-6330: -------------------------------------- Fix Version/s: JBossAS-5.1.0.CR1 (was: JBossAS-5.1.0.Beta1) Assignee: Emanuel Muckenhuber (was: Scott M Stark) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Jason T. Greene updated JBAS-6330: ---------------------------------- Priority: Blocker (was: Major) Make the sub-task priority match the root -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin reassigned JBAS-6330: --------------------------------- Assignee: Ales Justin (was: Emanuel Muckenhuber) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Max Rydahl Andersen commented on JBAS-6330: ------------------------------------------- Any nightly builds of 5_x I can use ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Rob Stryker commented on JBAS-6330: ----------------------------------- Great news: The API works. Deployment properly added. This was just basically a smoke test. I have no unit tests yet to verify that it all works, but I'll get some together early next week. I'd also like to request some method to list all the folders currently being scanned. Whether it's a property or a jmx method is fine. This would be for my unit tests, to verify things were added properly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin commented on JBAS-6330: ----------------------------------- What exactly was this list? String, array, ... What did it show? Folders to scan, actual deployments, ... This is probably the old interface: - http://anonsvn.jboss.org/repos/jbossas/branches/Branch_5_x/system-jmx/src... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin commented on JBAS-6330: ----------------------------------- Apart from what you already listed, I've added this. (Note: current impl only checks hasURL on newly added urls - see ProfileServiceDeploymentRepositoryAdapter for more details) /** * Do this repository contain a url. * * @param url the url * @return true if the url is contained * @throws MalformedURLException for any error * @throws URISyntaxException for any error */ boolean hasURL(String url) throws MalformedURLException, URISyntaxException; /** * Do this repository contain a url. * * @param url the url * @return true if the url is contained * @throws URISyntaxException for any error */ boolean hasURL(URL url) throws URISyntaxException; /** * List deployed urls. * * @return the list of deployed urls */ URL[] listDeployedURLs(); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Rob Stryker commented on JBAS-6330: ----------------------------------- Several Problems: 1) When my tools execute the following on a method that returns URL, result = connection.invoke(objectName, methodName, new Object[0],new String[0]); The result is the following exception: java.io.IOException: unknown protocol: vfszip 2) Execute the following: a) add a url (string) such as /home/rob/tmp/something b) add the same url (string) again. c) remove that url d) execute hasURL I would imagine this should return false, as you've removed it, but it seems the underlying impl adds it twice. I'm not sure on what *should* happen here... but I'd imagine for most uses you'd only want to add it once or remove it once. This seems wrong. 3) This no longer seems to work actually. Adding an .xml datasource file to one of the new scanned folders (such as above), the following exception occurs over and over and over: 15:29:36,611 WARN [HDScanner] Scan failed java.lang.IllegalArgumentException: Checker must be set at org.jboss.system.server.profileservice.repository.MutableDeploymentRepository.getChecker(MutableDeploymentRepository.java:78) at org.jboss.system.server.profileservice.repository.MutableDeploymentRepository.getModifiedDeployments(MutableDeploymentRepository.java:213) at org.jboss.system.tools.ProfileServiceDeploymentRepositoryAdapter$DeploymentScannerProfile.getModifiedDeployments(ProfileServiceDeploymentRepositoryAdapter.java:241) at org.jboss.system.server.profileservice.hotdeploy.HDScanner.scan(HDScanner.java:309) at org.jboss.system.server.profileservice.hotdeploy.HDScanner.run(HDScanner.java:229) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:417) at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:280) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:135) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:65) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(ScheduledThreadPoolExecutor.java:142) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:166) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675) at java.lang.Thread.run(Thread.java:595) I feel this means it doesn't actually work. 4) This message continues to be spit out even after removing the URL from the list of scannable folders. It does not stop ever. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin commented on JBAS-6330: ----------------------------------- 1) Requires you to have VFS in cp. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin commented on JBAS-6330: ----------------------------------- This should now be fixed in 5_x branch. Rob, can you try it? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Dimitris Andreadis updated JBAS-6330: ------------------------------------- Comment: was deleted -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin commented on JBAS-6330: ----------------------------------- Why not? We might eventually at one point release 5.0.2? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Rob Stryker commented on JBAS-6330: ----------------------------------- All seems to work. As per 4.2, removeURL should also undeploy whatever modules it finds there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin commented on JBAS-6330: ----------------------------------- 1) Will do, in 5.x branch. 2) t's called start and stop, the same way it used to be. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Rob Stryker commented on JBAS-6330: ----------------------------------- +1 works -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Ales Justin commented on JBAS-6330: ----------------------------------- In 5.0.x I currently have some support , but not all. The PS code in 5.0.x is different than in 5.1.x, so unless there is 5.0.2, I won't bother moving the whole logic. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Rob Stryker updated JBAS-6330: ------------------------------ Attachment: JBAS-6330.patch This patch is for unit tests. It has found a bug in listDeployedURLs I am not sure that the unit test works 100% even after listDeployedURLs is fixed so the unit test may need some tweaking. Another issue is that the full test takes 40 seconds to run. This seems a little long for me, but the nature of deployment scanning takes a while. Is there a way to force a scan so that maybe it can go faster? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Rob Stryker updated JBAS-6330: ------------------------------ Attachment: JBAS-6330.patch.2 better unit test. Nothing needs to be changed on the server side... but I did need to increase the delay on the client side. I have a general feeling 5 seconds is too much but what can I do to lower it? If I lower it it fails. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-6330?page=com.atlassian.jira.plug... ] Jason T. Greene resolved JBAS-6330. ----------------------------------- Resolution: Done Per early discussion with Rob and Max, we provide everything needed for 5.1.0.GA. So I am resolving this task. Any new bugs that come up can be created as separate issues. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira