[ https://issues.jboss.org/browse/AS7-5707?page=com.atlassian.jira.plugin.s... ] Thomas Diesler edited comment on AS7-5707 at 10/9/12 4:26 AM: -------------------------------------------------------------- The most promising approach to support deferred sub deployments was this one {code} // Defer the {@link Phase.FIRST_MODULE_USE} phase List<String> deferredModules = DeploymentUtils.getDeferredModules(deploymentUnit); if (deferredModules.size() > 0) { if (nextPhase == Phase.FIRST_MODULE_USE) { if (deferredModules.contains(name)) { DEPLOYMENT_LOGGER.infoDeferredModulePhase(name); phaseServiceBuilder.setInitialMode(Mode.NEVER); } else { DEPLOYMENT_LOGGER.infoDeferredModulePhase(name); phaseServiceBuilder.setInitialMode(Mode.PASSIVE); } if (parent != null) { ServiceName parentPhaseServiceName = Services.deploymentUnitName(parent.getName(), nextPhase); ServiceController<?> parentPhaseService = container.getRequiredService(parentPhaseServiceName); parentPhaseService.setMode(Mode.PASSIVE); } } } {code} It is however flawed in (at least) two ways. #1 There is no guarantee that a sibling bundle that is not deferred will have the next phase service setup after the deferred bundle has marked the top level DU. As a result the sibling's FIRST_MODULE_USE phase will fail because of the the missing dependency on the EAR's FIRST_MODULE_USE phase #2 Setting the mode of the EAR's FIRST_MODULE_USE phase to PASSIVE works during normal operation but not at boot time. The BootstrapListener expects an active service. This may be overcome by adding support for START_REQUESTED_to_DOWN was (Author: thomas.diesler): The most promising approach to support deferred sub deployments was this one {code} // Defer the {@link Phase.FIRST_MODULE_USE} phase List<String> deferredModules = DeploymentUtils.getDeferredModules(deploymentUnit); if (deferredModules.size() > 0) { if (nextPhase == Phase.FIRST_MODULE_USE) { if (deferredModules.contains(name)) { DEPLOYMENT_LOGGER.infoDeferredModulePhase(name); phaseServiceBuilder.setInitialMode(Mode.NEVER); } else { DEPLOYMENT_LOGGER.infoDeferredModulePhase(name); phaseServiceBuilder.setInitialMode(Mode.PASSIVE); } if (parent != null) { ServiceName parentPhaseServiceName = Services.deploymentUnitName(parent.getName(), nextPhase); ServiceController<?> parentPhaseService = container.getRequiredService(parentPhaseServiceName); parentPhaseService.setMode(Mode.PASSIVE); } } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5707?page=com.atlassian.jira.plugin.s... ] Thomas Diesler updated AS7-5707: -------------------------------- Fix Version/s: 7.2.0.Alpha1 (was: 7.2.0.CR1) Git Pull Request: https://github.com/jbossas/jboss-as/pull/3225 (was: https://github.com/jbossas/jboss-as/pull/3225) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5707?page=com.atlassian.jira.plugin.s... ] Thomas Diesler edited comment on AS7-5707 at 10/10/12 10:10 AM: ---------------------------------------------------------------- {code} // Defer the {@link Phase.FIRST_MODULE_USE} phase if (nextPhase == Phase.FIRST_MODULE_USE) { // Always make the EAR LAZY if it could contain deferrable sub-deployments if (subDeployments.size() > 0 && mayContainDeferrables) { DEPLOYMENT_LOGGER.infoDeferModulePhase(name, Mode.LAZY); phaseServiceBuilder.setInitialMode(Mode.LAZY); } List<String> deferredModules = DeploymentUtils.getDeferredModules(deploymentUnit); if (deferredModules.size() > 0) { if (deferredModules.contains(name)) { // Make the deferred module NEVER DEPLOYMENT_LOGGER.infoDeferModulePhase(name, Mode.NEVER); phaseServiceBuilder.setInitialMode(Mode.NEVER); } else { // Make the non-deferred sibling PASSIVE DEPLOYMENT_LOGGER.infoDeferModulePhase(name, Mode.PASSIVE); phaseServiceBuilder.setInitialMode(Mode.PASSIVE); } } } {code} {code} Running org.jboss.as.test.integration.osgi.deployment.DeferredResolveTestCase Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.987 sec {code} was (Author: thomas.diesler): {code} // Defer the {@link Phase.FIRST_MODULE_USE} phase if (nextPhase == Phase.FIRST_MODULE_USE) { // Always make the EAR LAZY if it could contain deferrable sub-deployments if (subDeployments.size() > 0 && mayContainDeferrables) { DEPLOYMENT_LOGGER.infoDeferModulePhase(name, Mode.LAZY); phaseServiceBuilder.setInitialMode(Mode.LAZY); } List<String> deferredModules = DeploymentUtils.getDeferredModules(deploymentUnit); if (deferredModules.size() > 0) { if (deferredModules.contains(name)) { // Make the deferred module NEVER DEPLOYMENT_LOGGER.infoDeferModulePhase(name, Mode.NEVER); phaseServiceBuilder.setInitialMode(Mode.NEVER); } else { // Make the non-deferred sibling PASSIVE DEPLOYMENT_LOGGER.infoDeferModulePhase(name, Mode.PASSIVE); phaseServiceBuilder.setInitialMode(Mode.PASSIVE); } } } {code} {code} Running org.jboss.as.test.integration.osgi.deployment.DeferredResolveTestCase Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.987 sec {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira