5:23 p.m.
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Bela Ban
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:17 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=all ]
Bela Ban updated JGRP-444:
--------------------------
Fix Version/s: 2.5
Assignee: Vladimir Blagojevic (was: Bela Ban)
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.5
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:41 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=comments#action_12357930 ]
Vladimir Blagojevic commented on JGRP-444:
------------------------------------------
Hi Michael,
Flush bypass was introduced for the sole reason to accomodate some functionality from
multiplexer. Do you have a concrete example explaining the need for introduction of flush
bypass in RequestCorrelator?
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.5
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:49 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=comments#action_12357992 ]
Michael Newcomb commented on JGRP-444:
--------------------------------------
We are using JGroups for a distributed map/grid. So, when members join/leave the group, I
want to redistribute their data to the rest of the grid. I need to restrict all access
during this time so I use a Channel.startFlush and Channel.stopFlush. When a member
leaves, they request a Channel.startFlush, push their local data to the rest of the grid
(with a flush bypass message), do a Channel.stopFlush, then leave the group.
Is Channel.startFlush and Channel.stopFlush more of an internal api?
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.5
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=comments#action_12358476 ]
Vladimir Blagojevic commented on JGRP-444:
------------------------------------------
We do not want to spread around dependency of FlushHeader.BYPASS_FLUSH into other building
blocks. We made an exception for Multiplexer.
A workaround would be to send your own custom event down the stack after startFlush.
Custom event can be handled by your own protocol below FLUSH.
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.5
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=comments#action_12358521 ]
Michael Newcomb commented on JGRP-444:
--------------------------------------
Since the flush concept (if not the specific FlushHeader.BYPASS_FLUSH) is already in core
classes, perhaps moving the BYPASS_FLUSH header outside of FLUSH or adding a
'byassFlush' boolean on some of the blocks?
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.5
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:39 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=all ]
Vladimir Blagojevic updated JGRP-444:
-------------------------------------
Fix Version/s: 2.6
(was: 2.5)
Revisit for 2.6
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.6
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:21 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=comments#action_12375694 ]
Vladimir Blagojevic commented on JGRP-444:
------------------------------------------
Michael,
Can you use block() callback for this purpose? block() callback is invoked on each channel
participating in flush and from block you can send a message that will be received by each
channel.
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.6
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:23 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=all ]
Vladimir Blagojevic updated JGRP-444:
-------------------------------------
Fix Version/s: 2.7
(was: 2.6)
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.7
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=comments#action_12375757 ]
Michael Newcomb commented on JGRP-444:
--------------------------------------
Well, the member leaving is the one who wants to push his data out and he is no longer a
member if/when he leaves. So, he needs to push his data back out to the grid before he
actually leaves. That's why the leaving member, starts a flush, pushes his data (and
tells everyone to no longer send him data), stops the flush and then leaves.
The leaving node needs to be sure the data is received so, a request/response is used and
the message is sent through a MessageDispatcher. However, the channel will hold the
message because a flush is in progress. I can get around that by adding the FLUSH_BYPASS
to the message but when the RequestCorrelator gets the request and sends the response,
each of the channels hold the message because a flush is in progress.
So, RequestCorrelator would need to respect messages that are FLUHS_BYPASSABLE...
I may not be understanding your suggestion about using block()...
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.7
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:12 a.m.
New subject: [JBoss JIRA] Resolved: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
[ http://jira.jboss.com/jira/browse/JGRP-444?page=all ]
Vladimir Blagojevic resolved JGRP-444.
--------------------------------------
Resolution: Won't Fix
RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
-----------------------------------------------------------------
Key: JGRP-444
URL: http://jira.jboss.com/jira/browse/JGRP-444
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: 2.5 alpha 2
Reporter: Michael Newcomb
Assigned To: Vladimir Blagojevic
Fix For: 2.7
private void handleRequest(Message req, Header hdr)
{
...
rsp=req.makeReply();
if(rsp_buf != null)
rsp.setBuffer(rsp_buf);
rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
rsp.putHeader(name, rsp_hdr);
// *************** patch *****************
// can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package
protection, so just check for FLUSH header
//
if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
{
rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
new
org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
}
// *************** patch *****************
if(log.isTraceEnabled())
log.trace(new StringBuffer("sending rsp for
").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
...
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6144
days inactive
6506
days old
10 comments
3 participants
participants (3)
-
Bela Ban (JIRA) -
Michael Newcomb (JIRA)
-
Vladimir Blagojevic (JIRA)