[JBoss JIRA] Created: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[JBoss JIRA] Created:...

[JBoss JIRA] Assigned: (JBPM-616)...

Oleg Nitz (JIRA)

Tuesday, 4 September 2007 Tue, 4 Sep '07

10:45 a.m.

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public (Everyone can see) Components: JCA service Affects Versions: JBossAS-4.2.1.GA, JBossAS-4.0.4.GA Reporter: Oleg Nitz If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Oleg Nitz (JIRA)

Tuesday, 4 September Tue, 4 Sep

11:20 a.m.

New subject: [JBoss JIRA] Closed: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=all ] Oleg Nitz closed JBAS-4667. --------------------------- Resolution: Deferred After some experiments I not sure that I am right and this is a real problem which causes incorrect behaviour. I am still thinking that the logic is incorrect, but possibly this doesn't affect anything. Since I wouldn't like to waste the time of JBoss developers, I've decided to close the bug for now.

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Oleg Nitz (JIRA)

Wednesday, 5 September Wed, 5 Sep

7:18 a.m.

New subject: [JBoss JIRA] Reopened: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=all ] Oleg Nitz reopened JBAS-4667: ----------------------------- I confirm that the proposed change makes JBoss AS not to produce the wrong warnings.

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Adrian Brock (JIRA)

9:17 a.m.

New subject: [JBoss JIRA] Commented: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=comments#action_12375380 ] Adrian Brock commented on JBAS-4667: ------------------------------------ The patch looks correct to me, but I don't really understand how it can happen in reality. The method is only invoked in two places. 1) At the end of an EJB invocation in a transaction to defer connection close checking to the end of the transaction, i.e. add all the unclosed handles to a transaction synchronization to be checked after the commit. This is for the anti-pattern of holding handles throughout a transaction. Using transaction affinity on the connection factory (<track-connection-by-tx/> in JBoss) and closing handles before exiting ejb methods is the way you should do it, not thread locals or caching in the hibernate session, etc.. 2) The later closing of the deferred connections before the commit occurs I don't see how this could relate to prepare? I can see how it might relate to a transaction that got into a rollback only state between ejb methods with the connection handle cached across those invocations?

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Adrian Brock (JIRA)

9:19 a.m.

New subject: [JBoss JIRA] Updated: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=all ] Adrian Brock updated JBAS-4667: ------------------------------- Fix Version/s: JBossAS-5.0.0.Beta3 JBossAS-4.2.2.GA Assignee: Adrian Brock

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Oleg Nitz (JIRA)

9:47 a.m.

New subject: [JBoss JIRA] Commented: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=comments#action_12375395 ] Oleg Nitz commented on JBAS-4667: --------------------------------- I wrote a JCA connector for CastorJDO. My ManagedConnection implementation provides LocalTransaction implementation where LocalTransaction.begin() calls begin() on Castor's Database object and LocalTransaction.commit() calls Database.commit() and then sends ConnectionEvent.CONNECTION_CLOSED to ConnectionEventListener. At this point the transaction is in STATUS_PREPARING state and CachedConnectionManager.unregisterConnection() does nothing as I described above.

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Oleg Nitz (JIRA)

9:55 a.m.

New subject: [JBoss JIRA] Commented: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=comments#action_12375400 ] Oleg Nitz commented on JBAS-4667: --------------------------------- And the wrong warning that I mentioned is "Closing a connection for you. Please close them yourself: ", it is logged in CachedConnectionManager.closeConnection()

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Adrian Brock (JIRA)

10:11 a.m.

New subject: [JBoss JIRA] Commented: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=comments#action_12375405 ] Adrian Brock commented on JBAS-4667: ------------------------------------ Ok. But that sounds like an example of "bad" caching, the connection handle usage isn't tied to the EJB invocations so the appserver is going to get confused in some circumstances. Anyway, I just reproduced the problem with an SFSB // Cache the connection in the SFSB state private Connection c; public void open() throws RemoteException { try { InitialContext ctx = new InitialContext(); DataSource ds = (DataSource) ctx.lookup("java:/DefaultDS"); c = ds.getConnection(); } catch (Exception e) { throw new RemoteException("Error", e); } } public void close() throws RemoteException { try { if (c != null) c.close(); } catch (Exception e) { throw new RemoteException("Error", e); } } Then the client starts a user transaction and sets rollback only between the invocations UserTransaction ut = (UserTransaction) ctx.lookup("UserTransaction"); ut.begin(); try { StatefulSessionHome home = (StatefulSessionHome) ctx.lookup("StatefulSessionBean"); StatefulSession session = home.create(); try { session.open(); ut.setRollbackOnly(); session.close(); } finally { session.remove(); } } finally { ut.rollback(); }

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Oleg Nitz (JIRA)

10:19 a.m.

New subject: [JBoss JIRA] Commented: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=comments#action_12375406 ] Oleg Nitz commented on JBAS-4667: --------------------------------- You are wrong, there is no connection caching in my case, everything happens during one EJB invocation. Anyway, I am glad that you have reproduced the problem :)

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.0.4.GA, JBossAS-4.2.1.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Adrian Brock (JIRA)

Thursday, 6 September Thu, 6 Sep

6:46 a.m.

New subject: [JBoss JIRA] Commented: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=comments#action_12375636 ] Adrian Brock commented on JBAS-4667: ------------------------------------ I'm not wrong, but its not really an issue for this bug report. ;-) I've applied the patch but it is waiting for the subtask fix to the transaction local in 4.2.x

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.2.1.GA, JBossAS-4.0.4.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Adrian Brock (JIRA)

6:48 a.m.

New subject: [JBoss JIRA] Updated: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=all ] Adrian Brock updated JBAS-4667: ------------------------------- Attachment: testbmtsfsb.zip

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.2.1.GA, JBossAS-4.0.4.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA Attachments: testbmtsfsb.zip If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

Dimitris Andreadis (JIRA)

Monday, 1 October Mon, 1 Oct

6:24 a.m.

New subject: [JBoss JIRA] Closed: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()

[ http://jira.jboss.com/jira/browse/JBAS-4667?page=all ] Dimitris Andreadis closed JBAS-4667. ------------------------------------ Resolution: Done Closing this task for 4.2.x. Created separate issues to track the changes in JBoss trunk. Essentially we are waiting there for the next jbossts upgrade.

...

Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization() -------------------------------------------------------------------------- Key: JBAS-4667 URL: http://jira.jboss.com/jira/browse/JBAS-4667 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: JCA service Affects Versions: JBossAS-4.2.1.GA, JBossAS-4.0.4.GA Reporter: Oleg Nitz Assigned To: Adrian Brock Fix For: JBossAS-5.0.0.Beta3, JBossAS-4.2.2.GA Attachments: testbmtsfsb.zip If the tx is not active (for example it has STATUS_PREPARING), then the method always returns null, even if the associated CloseConnectionSynchronization exists. This results in wrong warnings about non-closed connections, since when the close() is called for a connector, in CachedConnectionManager.unregisterConnection() a null value is returned from getCloseConnectionSynchronization() and the connector remains in the list of non-closed resources for the transaction. I think this bug was introduced here: http://jira.jboss.com/jira/browse/JBAS-31#action_12310798 I propose the following solution: --- CachedConnectionManager.java.orig 2005-11-22 02:10:41.000000000 +0200 +++ CachedConnectionManager.java 2007-09-04 18:42:48.000000000 +0300 @@ -544,13 +544,13 @@ try { Transaction tx = tm.getTransaction(); - if (TxUtils.isActive(tx)) + if (tx != null) { TransactionSynchronizer.lock(tx); try { CloseConnectionSynchronization cas = (CloseConnectionSynchronization) TransactionSynchronizer.getCCMSynchronization(tx); - if (cas == null && createIfNotFound) + if (cas == null && createIfNotFound && TxUtils.isActive(tx)) { cas = new CloseConnectionSynchronization(); TransactionSynchronizer.registerCCMSynchronization(tx, cas);

6314

days inactive

6341

days old

jboss-jira@lists.jboss.org

Manage subscription

11 comments

3 participants

tags (0)

participants (3)

Adrian Brock (JIRA)
Dimitris Andreadis (JIRA)
Oleg Nitz (JIRA)

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[JBoss JIRA] Created: (JBAS-4667) Wrong logic in CachedConnectionManager.getCloseConnectionSynchronization()