[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Johan Kustermans updated JBAS-7775: ----------------------------------- Description: We have a JSF 2.0 composite component in WEBROOT/resources and at the same time a jar in WEB-INF/lib that has resources under the META-INF/resources directory. Then a nullpointer is thrown with the following stacktrace if the composite component is looked up for rendering in another xhtml page 2010-02-28 19:21:32,839 SEVERE [javax.enterprise.resource.webcontainer.jsf.application] (http-localhost%2F127.0.0.1-8080-1) Error Rendering View[/homeLucene.xhtml]: java.lang.NullPointerException at org.apache.naming.resources.ProxyDirContext.listBindings(ProxyDirContext.java:714) at org.apache.catalina.core.ApplicationContext.listCollectionPaths(ApplicationContext.java:1397) at org.apache.catalina.core.ApplicationContext.getResourcePathsInternal(ApplicationContext.java:645) at org.apache.catalina.core.ApplicationContext.getResourcePaths(ApplicationContext.java:628) at org.apache.catalina.core.ApplicationContextFacade.getResourcePaths(ApplicationContextFacade.java:199) at com.sun.faces.context.ExternalContextImpl.getResourcePaths(ExternalContextImpl.java:480) at com.sun.faces.application.resource.WebappResourceHelper.findResource(WebappResourceHelper.java:191) at com.sun.faces.application.resource.ResourceManager.findResource(ResourceManager.java:384) at com.sun.faces.application.resource.ResourceManager.doLookup(ResourceManager.java:234) at com.sun.faces.application.resource.ResourceManager.findResource(ResourceManager.java:181) at com.sun.faces.application.resource.ResourceHandlerImpl.createResource(ResourceHandlerImpl.java:140) at com.sun.faces.application.resource.ResourceHandlerImpl.createResource(ResourceHandlerImpl.java:120) at com.sun.faces.renderkit.html_basic.StylesheetRenderer.encodeEnd(StylesheetRenderer.java:91) at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:878) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1620) at org.primefaces.renderkit.HeadRenderer.encodeBegin(HeadRenderer.java:42) at javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:823) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1611) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1616) at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:380) at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:126) at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:273) at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:127) at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101) at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:313) The error is thrown in the listbindings-method of the ProxyDirContext at the line while (overlay.hasMore()) { Binding pair = overlay.next(); ... } because overlay = null. This part of the code is reached in this case because the presence of the kind of jar mentioned in the beginning of this issue description implies that the overlays member field of the ProxyDirContext is not-null (and not empty). The composite component does, of course, not exist in the jar resulting in a null overlay. A simple check on overlay != null before executing the while loop seems sufficient to resolve the issue. was: We have a JSF 2.0 composite component in WEBROOT/resources and at the same time a jar in WEB-INF/lib that has resources under the META-INF/resources directory. Then a nullpointer is thrown with the following stacktrace 2010-02-28 19:21:32,839 SEVERE [javax.enterprise.resource.webcontainer.jsf.application] (http-localhost%2F127.0.0.1-8080-1) Error Rendering View[/homeLucene.xhtml]: java.lang.NullPointerException at org.apache.naming.resources.ProxyDirContext.listBindings(ProxyDirContext.java:714) at org.apache.catalina.core.ApplicationContext.listCollectionPaths(ApplicationContext.java:1397) at org.apache.catalina.core.ApplicationContext.getResourcePathsInternal(ApplicationContext.java:645) at org.apache.catalina.core.ApplicationContext.getResourcePaths(ApplicationContext.java:628) at org.apache.catalina.core.ApplicationContextFacade.getResourcePaths(ApplicationContextFacade.java:199) at com.sun.faces.context.ExternalContextImpl.getResourcePaths(ExternalContextImpl.java:480) at com.sun.faces.application.resource.WebappResourceHelper.findResource(WebappResourceHelper.java:191) at com.sun.faces.application.resource.ResourceManager.findResource(ResourceManager.java:384) at com.sun.faces.application.resource.ResourceManager.doLookup(ResourceManager.java:234) at com.sun.faces.application.resource.ResourceManager.findResource(ResourceManager.java:181) at com.sun.faces.application.resource.ResourceHandlerImpl.createResource(ResourceHandlerImpl.java:140) at com.sun.faces.application.resource.ResourceHandlerImpl.createResource(ResourceHandlerImpl.java:120) at com.sun.faces.renderkit.html_basic.StylesheetRenderer.encodeEnd(StylesheetRenderer.java:91) at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:878) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1620) at org.primefaces.renderkit.HeadRenderer.encodeBegin(HeadRenderer.java:42) at javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:823) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1611) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1616) at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:380) at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:126) at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:273) at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:127) at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101) at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:313) The error is thrown in the listbindings-method of the ProxyDirContext at the line while (overlay.hasMore()) { Binding pair = overlay.next(); ... } because overlay = null. This part of the code is reached in this case because the presence of the kind of jar mentioned in the beginning of this issue description implies that the overlays member field of the ProxyDirContext is not-null. A simple check on overlay != null before executing the while loop seems sufficient to resolve the issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Shelly McGowan reassigned JBAS-7775: ------------------------------------ Assignee: Stan Silvert Stan, we're seeing a similar problem with the admin-console tests. can you comment on this behavior? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Shelly McGowan updated JBAS-7775: --------------------------------- Try this: Check out embjopr/trunk: svn co https://svn.jboss.org/repos/embjopr/trunk/ embjopr cd embjopr mvn install -Dmaven.test.skip=true cd jsfunit mvn -Pjboss6x -Dtest=org.jboss.jopr.jsfunit.HelloJoprTest The error shown above will be seen in the cargo.log. Note too that jsfunit/pom.xml was just updated to 1.2.0.Final. The creation of the jboss6x profile is also new. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Stan Silvert commented on JBAS-7775: ------------------------------------ Thanks Nick. That should be very helpful. I'll give it a shot. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Prabhat Jha commented on JBAS-7775: ----------------------------------- Stan, Can it be fixed for M3? I think M4 might be too late for upcoming Richfaces 4.0. Alpha2 release and we wont want to delay the release as it's been a while since we did Alpha1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Remy Maucherat commented on JBAS-7775: -------------------------------------- I read this issue, and I am very worried because this means some hacking has been going on. I am not adding a if (overlay != null) check, because it looks like you added a null overlay. I will now be throwing an IAE if you try to add a null overlay, since it is not a valid argument value for the ProxyDirContext.addOverlay method. That is something that cannot happen in the regular web code, as JBossContextConfig does: ... FileDirContext dirContext = new FileDirContext(); try { dirContext.setDocBase(overlay.getPhysicalFile().getAbsolutePath()); resources.addOverlay(dirContext); } catch (IOException e) { ... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Stan Silvert commented on JBAS-7775: ------------------------------------ Also reported by this user: http://community.jboss.org/message/539764#539764 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7775?page=com.atlassian.jira.plug... ] Stan Silvert commented on JBAS-7775: ------------------------------------ Have you verified that this is still a problem in M4? Remy thinks it might be fixed. I'm getting close to checking in JSFDeployer. I just need to do lots of tests. After that I can look at it again if needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Andreas Eigenmann commented on JBAS-7775: ----------------------------------------- This bug should be "Critical/Blocker". This is preventing deployment of any application which uses a JSF component library and the JSF 2.0 ressource management -> near all JSF 2.0 applications. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Stan Silvert commented on JBAS-7775: ------------------------------------ I still can't reproduce this in trunk. The WAR attached to RF-8598 will reproduce in M2. However, when I run it in trunk I get the error from JBAS-8024. Presumably, it is hitting that one before I can get to the NPE. Shelly, are you currently seeing the error from this jira or the one from JBAS-8024? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Stan Silvert commented on JBAS-7775: ------------------------------------ Shelly, I tried your instructions above for reproducing with the admin console. It looks like cargo isn't working with AS trunk (which is usually the case as it always must lag behind). So I deployed to AS manually and I got the error from JBAS-8024. If you have an application that reproduces the NPE then please post it or send me a copy. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Stan Silvert commented on JBAS-7775: ------------------------------------ So it looks like Remy is correct that this may already be fixed. Unfortunately, we will have to wait for JBAS-8024 to be sure. Anyone disagree? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Stan Silvert reassigned JBAS-7775: ---------------------------------- Assignee: Remy Maucherat (was: Stan Silvert) Remy, can you take a closer look at this? Now that JBAS-8024 is fixed, the NPE is shown once again. I've attached a WAR that reproduces the problem in trunk. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Stan Silvert commented on JBAS-7775: ------------------------------------ Can someone else watching this jira try it out and report back? With the latest SVN update of trunk I no longer see the ZipException. But Remy still does. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Stan Silvert reassigned JBAS-7775: ---------------------------------- Assignee: Remy Maucherat (was: Stan Silvert) Thanks Pavol. Remy, can you give this another try now that your build is fixed? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-7775?page=com.atlassian.jira.plugin.sy... ] Remy Maucherat resolved JBAS-7775. ---------------------------------- Resolution: Done Web build is now integrated. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira