Deployment tests need completing -------------------------------- Key: JBMICROCONT-185 URL: http://jira.jboss.com/jira/browse/JBMICROCONT-185 Project: JBoss MicroContainer Issue Type: Task Components: Deployment Reporter: Adrian Brock Fix For: JBossMC_2_0_0_CR1 There are a number of TODOs in the deployer tests. Additionally, some areas could do with some more testing. Existing TODOs listed here, but really need subtasks MockEAR tests // TODO: need to scan for annotationss if (scan) { throw new RuntimeException("Scanning not implemented: "+file.getName()); } EARStructure test - this looks broken to me? public void testNotAnEAR() throws Throwable { // TODO ??? This gets recognised by the jar deployer assertNotValid("/structure/ear", "notanear"); } HACK to make tests work with Maven? - AbstractStructureTest protected VirtualFile getVirtualFile(String root, String path) throws Exception { // TODO THIS IS HACK TO MAKE THE TEST WORK IN MAVEN ??? try { URL.setURLStreamHandlerFactory(new URLStreamHandlerFactory() { public URLStreamHandler createURLStreamHandler(String protocol) { if ("vfsfile".equals(protocol)) return new Handler(); return null; } }); } catch (Error ignored) { } URL url = getResource(root); Field field = URL.class.getDeclaredField("factory"); field.setAccessible(true); return VFS.getVirtualFile(url, path); } VFSStructureBuilderTest - needs proper testing that the correct classpath was obtained protected void checkClassPath(VFSDeploymentContext context, ContextInfo contextInfo) throws Exception { List<ClassPathEntry> classPathEntries = contextInfo.getClassPath(); List<VirtualFile> classPath = context.getClassPath(); if (classPathEntries == null) assertNull(classPath); else { // TODO test it got the correct classpath } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira