5:55 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578638#578638
--------------------------------------------------------------
I've found out that if I specify an ear file name as domain name
in jboss-classloading-domain.xml then I see two classloaders in JMX view:
domain:
"jboss.j2ee:extension=LoaderRepository,service=EARDeployment,url='myapp.ear'"
- the default one created by ear deployer, with parent policy:
"AFTER_BUT_JAVA_BEFORE" and parent domain "DefaultDomain"
domain: "myapp.ear" - created from jboss-classloading-domain.xml, with parent
policy: "(before=EXCLUDE [org.hibernate.validator] after=)" and no parent domain
(null).
So it looks like I'll have to either add jboss-classloading.xml to change the domain
name to the same valuse which is in jboss-classloading-domain.xml or modify
jboss-classloading-domain.xml to use the default one.
I quickly tried both but it broke the app - it couldn't load
javax.servlet.http.HttpServlet (using negated recursive package filter for
org.hibernate.validator as before-filter). With some other filter it couldn't start
for other reasons so I'll try figure out a bit more about what actually happens..
Ah, another thing I missed -- EARClassLoaderDeployer. ;-(
Same issue as WebCLDeployer, it also sets some defaults, if no CLMetaData exists.
Let me check what gets used if you don't define any parent-domain in
jb-cl-domain.xml.
Also I noticed that war classloaders don't show up any parent
domain (null).
How do you see this?
Didn't we fix this with explicit jb-cl.xml in each of the wars? (until WebCLDeployer
is fixed)
So do you think that NothingClassFilter combined with
RecursivePackageFilter (the same way as NegatingClassFilter) would do the desired
blocking?
If you use NothingFilter then there is nothing to combine. ;-)
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578638#578638]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
6:03 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578643#578643
--------------------------------------------------------------
Let me check what gets used if you don't define any parent-domain
in jb-cl-domain.xml.
Yup, you need to explicitly define the parent -- otherwise
it's null.
Hence the "couldn't load javax.servlet.http.HttpServlet" error --
DefaultDomain is not the parent as we would expect.
Do you think we should by default have DefaultDomain as a parent, if not explicitly
defined?
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578643#578643]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
6:11 a.m.
Petr H [http://community.jboss.org/people/hostalp] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578646#578646
--------------------------------------------------------------
Yup, you need to explicitly define the parent -- otherwise it's
null.
Hence the "couldn't load javax.servlet.http.HttpServlet" error --
DefaultDomain is not the parent as we would expect.
Do you think we should by default have DefaultDomain as a parent, if not explicitly
defined?
Yeah that makes sense. But strange that it happens even when I specify
parent domain via jboss-classloading.xml. Perhaps jboss-classloading-domain.xml overrides
that.
Yes I think DefaultDomain as parent by default (like elsewhere) would be acceptable here.
And by the way, how one specifies parent in jboss-classloading-domain.xml? I didn't
study the related source. Is there any attribute like 'parent' or so?
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578646#578646]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
6:33 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578657#578657
--------------------------------------------------------------
Yeah that makes sense. But strange that it happens even when I
specify parent domain via jboss-classloading.xml. Perhaps jboss-classloading-domain.xml
overrides that.
Yes.
As it's the jb-cl-domain.xml that defines the full domain.
jb-cl.xml just uses that domain, hence it cannot change its parent.
And by the way, how one specifies parent in
jboss-classloading-domain.xml? I didn't study the related source. Is there any
attribute like 'parent' or so?
@XmlAttribute
public void setParentDomain(String parentDomain)
{
this.parentDomain = parentDomain;
}
There is an attribute parent-domain on the top jb-cl-domain.xml element.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578657#578657]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
7:45 a.m.
Petr H [http://community.jboss.org/people/hostalp] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578681#578681
--------------------------------------------------------------
Alright, made some progress. When specifying after and before filters it seems to have
effect, however I've found one issue when trying to setup a configuration simulating
default classloading behavior for ear deployments.
For ear deployments default is parent-first="false" ie. parent-policy
"AFTER_BUT_JAVA_BEFORE".
When setting up jboss-classloading-domain.xml this changes to
parent-first="true" ie. parent-policy "BEFORE"
So what I tried was to modify jboss-classloading.xml to simulate the default behavior
based on ParentPolicy class:
/** Java and Javax classes before, everything else after */
public static final ParentPolicy AFTER_BUT_JAVA_BEFORE = new
ParentPolicy(ClassFilterUtils.JAVA_ONLY, ClassFilterUtils.EVERYTHING,
"AFTER_BUT_JAVA_BEFORE");
To start from the beginning, I've setup:
<?xml version="1.0" encoding="UTF-8"?>
<classloading-domain xmlns="urn:jboss:classloading-domain:1.0"
name="jboss.j2ee:extension=LoaderRepository,service=EARDeployment,url='myapp.ear'"
parent-domain="DefaultDomain">
<parent-policy>
<before-filter>
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.plugins.filter.JavaOnlyClassFilter" />
</before-filter>
<after-filter>
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.plugins.filter.EverythingClassFilter" />
</after-filter>
</parent-policy>
</classloading-domain>
However both JavaOnlyClassFilter and EverythingClassFilter have private constructor so
I'm getting:
java.lang.RuntimeException: Error constructing javabean
Caused by: java.lang.IllegalAccessException: Class
org.jboss.reflect.plugins.introspection.ReflectionUtils can not access a member of class
org.jboss.classloader.plugins.filter.JavaOnlyClassFilter with modifiers
"private"
And by the way - specifying multiple beans within one filter will work?
like for example:
<before-filter>
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.plugins.filter.JavaOnlyClassFilter" />
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.plugins.filter.NegatingClassFilter">
<constructor>
<parameter>
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.spi.filter.RecursivePackageClassFilter">
<constructor>
<parameter>org.hibernate</parameter>
</constructor>
</javabean>
</parameter>
</constructor>
</javabean>
</before-filter>
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578681#578681]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
7:49 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578684#578684
--------------------------------------------------------------
And by the way - specifying multiple beans within one filter will
work?like for example:
<before-filter>
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.plugins.filter.JavaOnlyClassFilter" />
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.plugins.filter.NegatingClassFilter">
<constructor>
<parameter>
<javabean xmlns="urn:jboss:javabean:2.0"
class="org.jboss.classloader.spi.filter.RecursivePackageClassFilter">
<constructor>
<parameter>org.hibernate</parameter>
</constructor>
</javabean>
</parameter>
</constructor>
</javabean>
</before-filter>
No.
What exactly are you trying to configure here?
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578684#578684]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
7:58 a.m.
Petr H [http://community.jboss.org/people/hostalp] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578690#578690
--------------------------------------------------------------
I'm trying to setup the parent-first="false" ie. parent-policy
"AFTER_BUT_JAVA_BEFORE" behavior and then add some package filters to it.
With plain ear deployed it's "AFTER_BUT_JAVA_BEFORE" by default, but when I
add any java-classloading-domain.xml file (even the minimal one without any custom
filters) the behavior switches to parent-first="true" ie. parent-policy
"BEFORE" and then any potentionally added custom filters are combined with that
(which is OK but I want to get the aame to work for "AFTER_BUT_JAVA_BEFORE").
I tried stuff like <parent-policy name="AFTER_BUT_JAVA_BEFORE"> which
switches it to the desired state but then added filters have no effect.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578690#578690]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
8:13 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578698#578698
--------------------------------------------------------------
I see.
You should then configure / combine your own filters --
via before-filter and after-filter elements; e.g. CombiningClassFilter.
It's a bit more work, but check the source on how we define those JAVA* filters.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578698#578698]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
8:35 a.m.
Petr H [http://community.jboss.org/people/hostalp] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578709#578709
--------------------------------------------------------------
But that departs more and more from the intended ease of use I fear :(
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578709#578709]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
8:44 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578715#578715
--------------------------------------------------------------
But that departs more and more from the intended ease of use I fear
:(
Those are fine-grained details, and as such there is no way we can provide them
all.
But this is OSS, and the ease of use was already done by providing very flexible
http://java.dzone.com/articles/jboss-microcontainer-virtual-deployment-fr... VDF and
CL layers.
Hence you're welcome to contribute. ;-)
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578715#578715]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
9:48 a.m.
Petr H [http://community.jboss.org/people/hostalp] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578742#578742
--------------------------------------------------------------
We'll try something here, but what upsets me is that just adding the
jboss-classloading-domain.xml (or jboss-classloading.xml) automatically changes the
classloader defaults even though I don't attempt to change them in the config, and
especially the parent-first is interesting this case.
Why is it so? Does it come from EarClassLoaderDeployer/WarClassLoaderDeployer ? Quick look
at them shows that perhaps it does. Shouldn't that be fixed too to prevent that from
changing depending on jboss-classloading-domain.xml presence?.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578742#578742]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
11:05 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578772#578772
--------------------------------------------------------------
We'll try something here, but what upsets me is that just adding
the jboss-classloading-domain.xml (or jboss-classloading.xml) automatically changes the
classloader defaults even though I don't attempt to change them in the config, and
especially the parent-first is interesting this case.
OK, apart from the bugz in EAR
and WAR CL deployers, other things are obvious.
You're defining your own domain, hence its configuration applies.
Why is it so? Does it come from
EarClassLoaderDeployer/WarClassLoaderDeployer ? Quick look at them shows that perhaps it
does.
Yes.
The parent-first comes form classLoadingMetaData.setJ2seClassLoadingCompliance(false);
Shouldn't that be fixed too to prevent that from changing
depending on jboss-classloading-domain.xml presence?.
You are controlling this by
the before-filter config.
If it's AFTER_BUT_JAVA_ONLY then it's the same as what you get
withparent-first=false.
jb-cl-domain.xml is by default java-se compliant, meaning parent-first=true.
It could be debated what should be the default, but I think this is more natural.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578772#578772]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
6:10 a.m.
Ales Justin [http://community.jboss.org/people/alesj] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578645#578645
--------------------------------------------------------------
Ah, another thing I missed -- EARClassLoaderDeployer. ;-(
*
https://issues.jboss.org/browse/JBAS-8784 https://issues.jboss.org/browse/JBAS-8784
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578645#578645]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
6:17 a.m.
Petr H [http://community.jboss.org/people/hostalp] created the discussion
"Re: How to stop my WAR loading JBoss's provided 3rd party classes?"
To view the discussion, visit: http://community.jboss.org/message/578649#578649
--------------------------------------------------------------
> Also I noticed that war classloaders don't show up any
parent domain (null).
How do you see this?
Didn't we fix this with explicit jb-cl.xml in each of the wars? (until WebCLDeployer
is fixed)
I looked into jmx-console for jboss.classloader objects at entries for
each of the wars. They don't show any parent there even with everything regarding
classloading left untouched. But even though they don't show up any parents here they
actually seem like they may have the parent setup from ear level. At least based on my
brief tests with intentional screwing up something.
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/578649#578649]
Start a new discussion in JBoss Microcontainer at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&...]
4932
days inactive
4932
days old
13 comments
2 participants
participants (2)
-
Ales Justin -
Petr H