JBoss Tools SVN: r42187 - branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US.
by jbosstools-commits＠lists.jboss.org
Author: irooskov(a)redhat.com
Date: 2012-06-24 18:24:13 -0400 (Sun, 24 Jun 2012)
New Revision: 42187
Modified:
branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Beginners_Guide.xml
branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Book_Info.xml
branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Workshops.xml
Log:
updated from trunk
Modified: branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Beginners_Guide.xml
===================================================================
--- branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Beginners_Guide.xml 2012-06-22 23:23:03 UTC (rev 42186)
+++ branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Beginners_Guide.xml 2012-06-24 22:24:13 UTC (rev 42187)
@@ -7,7 +7,7 @@
<xi:include href="Introduction.xml" xmlns:xi="http://www.w3.org/2001/XInclude" />
<xi:include href="The_interface.xml" xmlns:xi="http://www.w3.org/2001/XInclude" />
<xi:include href="Java_Web_(EE)_and_Standard_Edition_(SE).xml" xmlns:xi="http://www.w3.org/2001/XInclude" />
- <xi:include href="Service-Oriented_Architecture_Development.xml" xmlns:xi="http://www.w3.org/2001/XInclude" />
+ <!-- <xi:include href="Service-Oriented_Architecture_Development.xml" xmlns:xi="http://www.w3.org/2001/XInclude" /> -->
<xi:include href="Workshops.xml" xmlns:xi="http://www.w3.org/2001/XInclude" />
<xi:include href="Where_to_go_from_here.xml" xmlns:xi="http://www.w3.org/2001/XInclude" />
<xi:include href="Feedback.xml" xmlns:xi="http://www.w3.org/2001/XInclude" />
Modified: branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Book_Info.xml
===================================================================
--- branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Book_Info.xml 2012-06-22 23:23:03 UTC (rev 42186)
+++ branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Book_Info.xml 2012-06-24 22:24:13 UTC (rev 42187)
@@ -13,7 +13,7 @@
<edition>5.0.0</edition>
- <pubsnumber>1</pubsnumber>
+ <pubsnumber>2</pubsnumber>
<abstract>
<para>
Modified: branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Workshops.xml
===================================================================
--- branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Workshops.xml 2012-06-22 23:23:03 UTC (rev 42186)
+++ branches/jbosstools-3.3.x/documentation/guides/Beginners_Guide/en-US/Workshops.xml 2012-06-24 22:24:13 UTC (rev 42187)
@@ -17,12 +17,12 @@
<itemizedlist>
<listitem>
<para>
- <application>JBoss Developer Studio 4.0</application>
+ <application>JBoss Developer Studio 5.0</application>
</para>
</listitem>
<listitem>
<para>
- <application>JBoss Enterprise Application Platform 5</application> or <application>JBoss Service Orientated Architecture Platform 5</application>
+ <application>JBoss Enterprise Application Platform 6</application> or <application>JBoss Service Orientated Architecture Platform 6</application>
</para>
</listitem>
<listitem>
@@ -376,7 +376,7 @@
<section id="sect-Beginners_Guide-Workshops-Seam">
<title>Seam</title>
<para>
- The <application>JBoss Enterprise Application Platform </application> book titled the <emphasis>Seam Reference Guide</emphasis> contains an example of how to setup Seam for use with <application>JBoss Developer Studio</application>. This workshop can be found here: <ulink url="http://docs.redhat.com/docs/en-US/JBoss_Enterprise_Application_Platform/5...">Getting Started with Seam, using JBoss Tools</ulink>.
+ The <application>JBoss Enterprise Application Platform </application> book titled the <emphasis>Seam Reference Guide</emphasis> contains an example of how to setup Seam for use with <application>JBoss Developer Studio</application>. <!--This workshop can be found here: <ulink url="http://docs.redhat.com/docs/en-US/JBoss_Enterprise_Application_Platform/5...">Getting Started with Seam, using JBoss Tools</ulink>. -->
</para>
</section>
</chapter>
12 years, 6 months
JBoss Tools SVN: r42186 - trunk/jst/plugins/org.jboss.tools.jst.web/src/org/jboss/tools/jst/web/project/handlers.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-06-22 19:23:03 -0400 (Fri, 22 Jun 2012)
New Revision: 42186
Modified:
trunk/jst/plugins/org.jboss.tools.jst.web/src/org/jboss/tools/jst/web/project/handlers/AddProjectTemplateSupport.java
Log:
JBIDE-12247
https://issues.jboss.org/browse/JBIDE-12247
Modified: trunk/jst/plugins/org.jboss.tools.jst.web/src/org/jboss/tools/jst/web/project/handlers/AddProjectTemplateSupport.java
===================================================================
--- trunk/jst/plugins/org.jboss.tools.jst.web/src/org/jboss/tools/jst/web/project/handlers/AddProjectTemplateSupport.java 2012-06-22 23:21:45 UTC (rev 42185)
+++ trunk/jst/plugins/org.jboss.tools.jst.web/src/org/jboss/tools/jst/web/project/handlers/AddProjectTemplateSupport.java 2012-06-22 23:23:03 UTC (rev 42186)
@@ -19,6 +19,9 @@
import org.jboss.tools.common.meta.action.impl.*;
import org.jboss.tools.common.model.XModel;
import org.jboss.tools.common.model.XModelException;
+import org.jboss.tools.common.model.XModelObject;
+import org.jboss.tools.common.model.filesystems.FileSystemsHelper;
+import org.jboss.tools.common.model.filesystems.impl.FileSystemsLoader;
import org.jboss.tools.common.model.options.PreferenceModelUtilities;
import org.jboss.tools.common.model.plugin.ModelPlugin;
import org.jboss.tools.common.model.project.IModelNature;
@@ -168,6 +171,13 @@
velocityStep.createPreprocessingFile(target);
propertiesStep.createPropertiesFile(target);
+ File settings = new File(target, IModelNature.PROJECT_FILE);
+ if(!settings.isFile()) {
+ settings.getParentFile().mkdirs();
+ XModelObject fs = FileSystemsHelper.getFileSystems(model);
+ new FileSystemsLoader().saveTo(settings, fs);
+ }
+
getProperties().setProperty("name", name); //$NON-NLS-1$
}
12 years, 6 months
JBoss Tools SVN: r42185 - in trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model: project and 1 other directory.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-06-22 19:21:45 -0400 (Fri, 22 Jun 2012)
New Revision: 42185
Modified:
trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileSystemsLoader.java
trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/project/ClassPathUpdate.java
Log:
JBIDE-12247
https://issues.jboss.org/browse/JBIDE-12247
Modified: trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileSystemsLoader.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileSystemsLoader.java 2012-06-22 22:21:40 UTC (rev 42184)
+++ trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileSystemsLoader.java 2012-06-22 23:21:45 UTC (rev 42185)
@@ -130,6 +130,20 @@
protected String fileName(XModelObject object) {
return "workspace.pex"; //$NON-NLS-1$
}
+
+ public void saveTo(File f, XModelObject object) {
+ XModelObject o = object.copy(1);
+ XModelObject[] cs = o.getChildren();
+ for (XModelObject c: cs) {
+ if(c.getModelEntity().getName().equals("FileSystemJar")) { //$NON-NLS-1$
+ o.removeChild(c);
+ }
+ if(!c.getAttributeValue(XModelObjectConstants.ATTR_NAME_LOCATION).startsWith("%")) { //$NON-NLS-1$
+ o.removeChild(c);
+ }
+ }
+ util().save(f, o);
+ }
private boolean saveEclipse(XModelObject object) {
String f = getEclipseFileName(object, false);
@@ -264,6 +278,9 @@
}
public boolean saveChildren(Element element, XModelObject o) {
+ if("FileSystemJar".equals(o.getModelEntity().getName())) { //$NON-NLS-1$
+ return true;
+ }
boolean b = super.saveChildren(element, o);
if(b && isFileSystems(element.getNodeName())) {
saveWorkspaceHomeAttr(element, o);
Modified: trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/project/ClassPathUpdate.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/project/ClassPathUpdate.java 2012-06-22 22:21:40 UTC (rev 42184)
+++ trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/project/ClassPathUpdate.java 2012-06-22 23:21:45 UTC (rev 42185)
@@ -137,7 +137,17 @@
}
}
}
-
+ children = FileSystemsHelper.getFileSystems(model).getChildren("FileSystemFolder");
+ for (XModelObject c: children) {
+ String n = c.getAttributeValue(XModelObjectConstants.ATTR_NAME);
+ if("src".equals(n) || n.startsWith("src-")) {
+ String osPath = XModelObjectUtil.getExpandedValue(c, XModelObjectConstants.ATTR_NAME_LOCATION, null);
+ if (osPath != null && !"".equals(osPath) && !set.contains(osPath)) { //$NON-NLS-1$
+ srcPaths.add(osPath);
+ set.add(osPath);
+ }
+ }
+ }
Iterator iterator = srcPaths.iterator();
while (iterator.hasNext()) {
IClasspathEntry entry = createNewClasspathEntry(iterator.next().toString(), IClasspathEntry.CPE_SOURCE);
12 years, 6 months
JBoss Tools SVN: r42184 - trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/definition.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-06-22 18:21:40 -0400 (Fri, 22 Jun 2012)
New Revision: 42184
Modified:
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/definition/DefinitionContext.java
Log:
JBIDE-12246
https://issues.jboss.org/browse/JBIDE-12246
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/definition/DefinitionContext.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/definition/DefinitionContext.java 2012-06-22 22:02:24 UTC (rev 42183)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/definition/DefinitionContext.java 2012-06-22 22:21:40 UTC (rev 42184)
@@ -394,6 +394,10 @@
project.getDelegate().update(true);
workingCopy = null;
+
+ if(!project.getProject().isAccessible()) {
+ clean();
+ }
}
public void dropWorkingCopy() {
12 years, 6 months
JBoss Tools SVN: r42183 - trunk/cdi/plugins/org.jboss.tools.cdi.seam.solder.core/src/org/jboss/tools/cdi/seam/solder/core.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-06-22 18:02:24 -0400 (Fri, 22 Jun 2012)
New Revision: 42183
Modified:
trunk/cdi/plugins/org.jboss.tools.cdi.seam.solder.core/src/org/jboss/tools/cdi/seam/solder/core/CDISeamSolderDefaultBeanExtension.java
Log:
JBIDE-12246
https://issues.jboss.org/browse/JBIDE-12246
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.seam.solder.core/src/org/jboss/tools/cdi/seam/solder/core/CDISeamSolderDefaultBeanExtension.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.seam.solder.core/src/org/jboss/tools/cdi/seam/solder/core/CDISeamSolderDefaultBeanExtension.java 2012-06-22 21:49:26 UTC (rev 42182)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.seam.solder.core/src/org/jboss/tools/cdi/seam/solder/core/CDISeamSolderDefaultBeanExtension.java 2012-06-22 22:02:24 UTC (rev 42183)
@@ -181,6 +181,7 @@
public void validateResource(IFile file, CDICoreValidator validator) {
String defaultBeanAnnotationTypeName = getVersion().getDefaultBeanAnnotationTypeName();
ICDIProject cdiProject = CDICorePlugin.getCDIProject(file.getProject(), true);
+ if(cdiProject == null) return;
Set<IBean> bs = cdiProject.getBeans(file.getFullPath());
for (IBean bean: bs) {
if(isBeanDefault(bean)) {
12 years, 6 months
JBoss Tools SVN: r42182 - trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/wizard.
by jbosstools-commits＠lists.jboss.org
Author: akazakov
Date: 2012-06-22 17:49:26 -0400 (Fri, 22 Jun 2012)
New Revision: 42182
Modified:
trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/wizard/SeamProjectWizard.java
Log:
https://issues.jboss.org/browse/JBIDE-12184 EJB and EAR projects are not generated when proper option is checked
Modified: trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/wizard/SeamProjectWizard.java
===================================================================
--- trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/wizard/SeamProjectWizard.java 2012-06-22 21:35:57 UTC (rev 42181)
+++ trunk/seam/plugins/org.jboss.tools.seam.ui/src/org/jboss/tools/seam/ui/wizard/SeamProjectWizard.java 2012-06-22 21:49:26 UTC (rev 42182)
@@ -245,25 +245,27 @@
for (Action action : actions) {
if(ISeamFacetDataModelProperties.SEAM_FACET_ID.equals(action.getProjectFacetVersion().getProjectFacet().getId())) {
IDataModel model = (IDataModel)action.getConfig();
- Object targetServer = this.model.getProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_SERVER);
- if(targetServer!=null) {
- model.setProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_SERVER, targetServer);
- }
- Object targetRuntime = this.model.getProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_RUNTIME);
- if(targetRuntime!=null) {
- Object targetRuntimeName = targetRuntime;
- if(targetRuntime instanceof IRuntime) {
- targetRuntimeName = ((IRuntime)targetRuntime).getName();
+ if(model!=null) {
+ Object targetServer = this.model.getProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_SERVER);
+ if(targetServer!=null) {
+ model.setProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_SERVER, targetServer);
}
- model.setProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_RUNTIME, targetRuntimeName);
+ Object targetRuntime = this.model.getProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_RUNTIME);
+ if(targetRuntime!=null) {
+ Object targetRuntimeName = targetRuntime;
+ if(targetRuntime instanceof IRuntime) {
+ targetRuntimeName = ((IRuntime)targetRuntime).getName();
+ }
+ model.setProperty(ISeamFacetDataModelProperties.JBOSS_AS_TARGET_RUNTIME, targetRuntimeName);
+ }
+ final DataModelSynchHelper synchHelper = firstPage.initializeSynchHelper(model);
+ Display.getDefault().syncExec(new Runnable() {
+ public void run() {
+ synchHelper.synchCombo(matchedServerTargetCombo, ISeamFacetDataModelProperties.JBOSS_AS_TARGET_SERVER, dependentServerControls);
+ synchHelper.synchCombo(serverRuntimeTargetCombo, ISeamFacetDataModelProperties.JBOSS_AS_TARGET_RUNTIME, null);
+ }
+ });
}
- final DataModelSynchHelper synchHelper = firstPage.initializeSynchHelper(model);
- Display.getDefault().syncExec(new Runnable() {
- public void run() {
- synchHelper.synchCombo(matchedServerTargetCombo, ISeamFacetDataModelProperties.JBOSS_AS_TARGET_SERVER, dependentServerControls);
- synchHelper.synchCombo(serverRuntimeTargetCombo, ISeamFacetDataModelProperties.JBOSS_AS_TARGET_RUNTIME, null);
- }
- });
}
}
}
12 years, 6 months
JBoss Tools SVN: r42181 - trunk/common/plugins/org.jboss.tools.common.ui/src/org/jboss/tools/common/ui/marker.
by jbosstools-commits＠lists.jboss.org
Author: dazarov
Date: 2012-06-22 17:35:57 -0400 (Fri, 22 Jun 2012)
New Revision: 42181
Modified:
trunk/common/plugins/org.jboss.tools.common.ui/src/org/jboss/tools/common/ui/marker/ConfigureProblemSeverityResolutionGenerator.java
Log:
Make Quick fix for problem markers "Unknown tag" work on temporary WTP annotations https://issues.jboss.org/browse/JBIDE-10958
Modified: trunk/common/plugins/org.jboss.tools.common.ui/src/org/jboss/tools/common/ui/marker/ConfigureProblemSeverityResolutionGenerator.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.ui/src/org/jboss/tools/common/ui/marker/ConfigureProblemSeverityResolutionGenerator.java 2012-06-22 21:19:02 UTC (rev 42180)
+++ trunk/common/plugins/org.jboss.tools.common.ui/src/org/jboss/tools/common/ui/marker/ConfigureProblemSeverityResolutionGenerator.java 2012-06-22 21:35:57 UTC (rev 42181)
@@ -12,7 +12,6 @@
import java.util.ArrayList;
import java.util.List;
-import java.util.Map;
import org.eclipse.core.resources.IFile;
import org.eclipse.core.resources.IMarker;
@@ -35,6 +34,7 @@
/**
* @author Daniel Azarov
*/
+@SuppressWarnings("restriction")
public class ConfigureProblemSeverityResolutionGenerator implements
IMarkerResolutionGenerator2, IQuickFixGenerator {
@@ -115,13 +115,19 @@
}
private String getPreferenceKey(TemporaryAnnotation annotation){
- String attribute = (String)annotation.getAttributes().get(ValidationErrorManager.PREFERENCE_KEY_ATTRIBUTE_NAME);
- return attribute;
+ if(annotation.getAttributes() != null){
+ String attribute = (String)annotation.getAttributes().get(ValidationErrorManager.PREFERENCE_KEY_ATTRIBUTE_NAME);
+ return attribute;
+ }
+ return null;
}
private String getPreferencePageId(TemporaryAnnotation annotation){
- String attribute = (String)annotation.getAttributes().get(ValidationErrorManager.PREFERENCE_PAGE_ID_NAME);
- return attribute;
+ if(annotation.getAttributes() != null){
+ String attribute = (String)annotation.getAttributes().get(ValidationErrorManager.PREFERENCE_PAGE_ID_NAME);
+ return attribute;
+ }
+ return null;
}
@Override
12 years, 6 months
JBoss Tools SVN: r42180 - trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-06-22 17:19:02 -0400 (Fri, 22 Jun 2012)
New Revision: 42180
Modified:
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java
Log:
JBIDE-12246
https://issues.jboss.org/browse/JBIDE-12246
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java 2012-06-22 19:22:33 UTC (rev 42179)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java 2012-06-22 21:19:02 UTC (rev 42180)
@@ -1327,7 +1327,7 @@
for (String builtin: BuiltInBeanFactory.BUILT_IN) {
IType type = n.getType(builtin);
- if(type != null && !newClassBeans.containsKey(type)) {
+ if(type != null && type.exists() && !newClassBeans.containsKey(type)) {
TypeDefinition t = new TypeDefinition();
t.setType(type, n.getDefinitions(), TypeDefinition.FLAG_NO_ANNOTATIONS);
t.setBeanConstructor(true);
12 years, 6 months
JBoss Tools SVN: r42179 - trunk/struts/plugins/org.jboss.tools.struts.ui.
by jbosstools-commits＠lists.jboss.org
Author: akazakov
Date: 2012-06-22 15:22:33 -0400 (Fri, 22 Jun 2012)
New Revision: 42179
Modified:
trunk/struts/plugins/org.jboss.tools.struts.ui/build.properties
Log:
https://issues.jboss.org/browse/JBIDE-12096 Struts feature is missing image in description
Modified: trunk/struts/plugins/org.jboss.tools.struts.ui/build.properties
===================================================================
--- trunk/struts/plugins/org.jboss.tools.struts.ui/build.properties 2012-06-22 18:48:58 UTC (rev 42178)
+++ trunk/struts/plugins/org.jboss.tools.struts.ui/build.properties 2012-06-22 19:22:33 UTC (rev 42179)
@@ -8,7 +8,8 @@
.,\
about.ini,\
about.mappings,\
- about.properties
+ about.properties,\
+ jboss_about.png
src.includes = src/,\
resources/,\
plugin.xml,\
@@ -23,4 +24,5 @@
.project,\
.options.template,\
.cvsignore,\
- .classpath
+ .classpath,\
+ jboss_about.png
12 years, 6 months
JBoss Tools SVN: r42178 - trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/java.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-06-22 14:48:58 -0400 (Fri, 22 Jun 2012)
New Revision: 42178
Modified:
trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/java/JavaDirtyRegionProcessor.java
Log:
JBIDE-10611
https://issues.jboss.org/browse/JBIDE-10611
Modified: trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/java/JavaDirtyRegionProcessor.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/java/JavaDirtyRegionProcessor.java 2012-06-22 18:42:38 UTC (rev 42177)
+++ trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/java/JavaDirtyRegionProcessor.java 2012-06-22 18:48:58 UTC (rev 42178)
@@ -60,8 +60,12 @@
final class JavaDirtyRegionProcessor extends
DirtyRegionProcessor {
- // TODO Slava what is that?
- static final Position ALWAYS_CLEARED = new Position(100000);
+ /**
+ * This constant is put as value to JavaELProblemReporter.fAnnotations(Annotation, Position)
+ * to indicate that in JavaELProblemReporter.clearAnnotations(int start, int end)
+ * that annotation should be removed without regard to its position.
+ */
+ static final Position ALWAYS_CLEARED = new Position(Integer.MAX_VALUE);
private ITextEditor fEditor;
private IDocument fDocument;
@@ -154,6 +158,13 @@
}
}
+ /**
+ * This method removes from annotation model each annotation stored
+ * in JavaELProblemReporter.fAnnotations(Annotation, Position) that
+ * 1) either has position inside [start,end] region;
+ * 2) or is associated with special Position instance ALWAYS_CLEARED
+ * that indicates it should be removed without regard to its actual position.
+ */
public void clearAnnotations(int start, int end) {
if (fAnnotations.isEmpty()) {
return;
@@ -169,7 +180,16 @@
}
}
}
-
+
+ /**
+ * Adds annotation to the annotation model, and stores it in fAnnotations with either actual position
+ * or special constant ALWAYS_CLEARED (when cleanAllAnnotations = true) that indicates that
+ * the annotation should be removed without regard to the modified region.
+ *
+ * @param annotation
+ * @param position
+ * @param cleanAllAnnotations
+ */
public void addAnnotation(Annotation annotation, Position position, boolean cleanAllAnnotations) {
if (isCancelled()) {
return;
12 years, 6 months