Author: rob.stryker(a)jboss.com Date: 2009-06-07 23:33:39 -0400 (Sun, 07 Jun 2009) New Revision: 15762 Added: trunk/jmx/plugins/org.jboss.tools.jmx.core/.settings/ trunk/jmx/plugins/org.jboss.tools.jmx.core/.settings/org.eclipse.jdt.core.prefs Modified: trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.java trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.properties trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/tree/NodeUtils.java trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/util/FileUtil.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/.settings/org.eclipse.jdt.core.prefs trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.properties trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/StringUtils.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/adapters/JMXAdapterFactory.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/CollectionControlFactory.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/MapControlFactory.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TabularDataControlFactory.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TextControlFactory.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/dialogs/OpenMBeanSelectionDialog.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/MBeanEditorInput.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/NotificationsPage.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/OperationDetails.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/EmbedableLabelProvider.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/JMXNavigator.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerContentProvider.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerLabelProvider.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/QueryContribution.java trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/UpdateSelectionJob.java Log: NLS completion, all for Sean Added: trunk/jmx/plugins/org.jboss.tools.jmx.core/.settings/org.eclipse.jdt.core.prefs =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.core/.settings/org.eclipse.jdt.core.prefs (rev 0) +++ trunk/jmx/plugins/org.jboss.tools.jmx.core/.settings/org.eclipse.jdt.core.prefs 2009-06-08 03:33:39 UTC (rev 15762) @@ -0,0 +1,64 @@ +#Mon Jun 08 11:20:36 PDT 2009 +eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning +org.eclipse.jdt.core.compiler.problem.autoboxing=ignore +org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning +org.eclipse.jdt.core.compiler.problem.deadCode=warning +org.eclipse.jdt.core.compiler.problem.deprecation=warning +org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled +org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled +org.eclipse.jdt.core.compiler.problem.discouragedReference=warning +org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore +org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore +org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled +org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore +org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning +org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning +org.eclipse.jdt.core.compiler.problem.forbiddenReference=error +org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning +org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning +org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore +org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore +org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore +org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning +org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore +org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore +org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning +org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore +org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning +org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=error +org.eclipse.jdt.core.compiler.problem.nullReference=warning +org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning +org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore +org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore +org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore +org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning +org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore +org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=ignore +org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled +org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning +org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled +org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore +org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning +org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning +org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore +org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore +org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled +org.eclipse.jdt.core.compiler.problem.unusedImport=warning +org.eclipse.jdt.core.compiler.problem.unusedLabel=warning +org.eclipse.jdt.core.compiler.problem.unusedLocal=warning +org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled +org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning +org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning +org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning Modified: trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -20,6 +20,10 @@ public static String DefaultConnection_ErrorRemoving; public static String DefaultConnection_ErrorLoading; public static String DefaultConnection_ErrorRunningJMXCode; + public static String ProblemWritingToFile; + public static String LoadMBeans; + public static String InspectMBeans; + static { NLS.initializeMessages("org.jboss.tools.jmx.core.JMXCoreMessages", //$NON-NLS-1$ JMXCoreMessages.class); Modified: trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.properties =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.properties 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/JMXCoreMessages.properties 2009-06-08 03:33:39 UTC (rev 15762) @@ -8,3 +8,6 @@ DefaultConnection_ErrorAdding=Error adding connection. DefaultConnection_ErrorRemoving=Error removing connection. DefaultConnection_ErrorRunningJMXCode=Error executing JMX request. +ProblemWritingToFile=Problem writing to file {0} +LoadMBeans=Load MBeans +InspectMBeans=Inspect MBeans \ No newline at end of file Modified: trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/tree/NodeUtils.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/tree/NodeUtils.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/tree/NodeUtils.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -18,6 +18,7 @@ import org.eclipse.core.runtime.SubProgressMonitor; import org.jboss.tools.jmx.core.IConnectionWrapper; import org.jboss.tools.jmx.core.IJMXRunnable; +import org.jboss.tools.jmx.core.JMXCoreMessages; import org.jboss.tools.jmx.core.JMXException; public class NodeUtils { @@ -49,11 +50,11 @@ final Root[] _root = new Root[1]; connectionWrapper.run(new IJMXRunnable() { public void run(MBeanServerConnection connection) throws Exception { - monitor.beginTask("Load MBeans", 1000); + monitor.beginTask(JMXCoreMessages.LoadMBeans, 1000); Set beanInfo = connection.queryNames(new ObjectName("*:*"), null); //$NON-NLS-1$ monitor.worked(100); SubProgressMonitor subMon = new SubProgressMonitor(monitor, 900); - subMon.beginTask("Inspect MBeans", beanInfo.size() * 100); + subMon.beginTask(JMXCoreMessages.InspectMBeans, beanInfo.size() * 100); _root[0] = NodeBuilder.createRoot(connectionWrapper); Iterator iter = beanInfo.iterator(); while (iter.hasNext()) { Modified: trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/util/FileUtil.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/util/FileUtil.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.core/src/org/jboss/tools/jmx/core/util/FileUtil.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -41,7 +41,9 @@ import java.util.zip.ZipEntry; import java.util.zip.ZipFile; +import org.eclipse.osgi.util.NLS; import org.jboss.tools.jmx.core.JMXActivator; +import org.jboss.tools.jmx.core.JMXCoreMessages; public final class FileUtil { @@ -49,9 +51,9 @@ public FileUtil() {} public static String readFile(File f) { - if(!f.isFile()) return ""; + if(!f.isFile()) return ""; //$NON-NLS-1$ ReadBytes bs = readBytes(f); - if(bs == null) return ""; + if(bs == null) return ""; //$NON-NLS-1$ String encoding = getEncoding(bs.bs); if(encoding == null) return new String(bs.bs, 0, bs.length); try { @@ -143,7 +145,7 @@ } public static String readStream(InputStream is) { - StringBuffer sb = new StringBuffer(""); + StringBuffer sb = new StringBuffer(""); //$NON-NLS-1$ try { byte[] b = new byte[4096]; while(true) { @@ -161,8 +163,8 @@ public static boolean writeFile(File f, String value) { if(value == null) return false; String encoding = getEncoding(value); - if(value.startsWith("<?xml")) { - String s = validateEncoding(encoding, "UTF-8"); + if(value.startsWith("<?xml")) { //$NON-NLS-1$ + String s = validateEncoding(encoding, "UTF-8"); //$NON-NLS-1$ if(encoding == null) { encoding = s; } else if(s == null || !s.equals(encoding)) { @@ -179,9 +181,9 @@ if(f.isFile() && !isSameFile(f)) f.delete(); if(!f.exists()) f.createNewFile(); } catch (IOException e) { - JMXActivator.log("Problem writing to file " + f, e); + JMXActivator.log(NLS.bind(JMXCoreMessages.ProblemWritingToFile, f), e); } catch (SecurityException e) { - JMXActivator.log("Problem writing to file " + f, e); + JMXActivator.log(NLS.bind(JMXCoreMessages.ProblemWritingToFile, f), e); } PrintWriter pw = new PrintWriter(new FileWriter(f)); pw.print(value); @@ -413,10 +415,10 @@ public static void add(File f, String name, JarOutputStream jos) throws IOException { String en = name; - if(f.isDirectory()) en += "/"; - JarEntry entry = (en.endsWith("/")) ? null : new JarEntry(en); + if(f.isDirectory()) en += "/"; //$NON-NLS-1$ + JarEntry entry = (en.endsWith("/")) ? null : new JarEntry(en); //$NON-NLS-1$ if(f.isDirectory()) { - if("/".equals(en)) en = ""; + if("/".equals(en)) en = ""; //$NON-NLS-1$ //$NON-NLS-2$ File[] fs = f.listFiles(); if(fs != null) for (int i = 0; i < fs.length; i++) add(fs[i], en + fs[i].getName(), jos); @@ -487,7 +489,7 @@ if(url == null) return null; String resultUrl = url.replace('\\', '/'); /// if(!url.startsWith("file:/")) return url; - if(!resultUrl.startsWith("file:")) return resultUrl; + if(!resultUrl.startsWith("file:")) return resultUrl; //$NON-NLS-1$ int iLast = resultUrl.lastIndexOf(':'), iFirst = resultUrl.indexOf(':'); return (iLast == iFirst) ? resultUrl.substring(5) : resultUrl.substring(iLast - 1); } @@ -501,19 +503,19 @@ int i = 0; while(i < r.length && i < p.length && r[i].equalsIgnoreCase(p[i])) ++i; StringBuffer sb = new StringBuffer(); - for (int k = i; k < r.length; k++) sb.append("/.."); - for (int k = i; k < p.length; k++) sb.append("/").append(p[k]); + for (int k = i; k < r.length; k++) sb.append("/.."); //$NON-NLS-1$ + for (int k = i; k < p.length; k++) sb.append("/").append(p[k]); //$NON-NLS-1$ return sb.toString(); } private static String[] tokenizePath(String path) { String tokenizedPath = path.replace('\\', '/'); - StringTokenizer st = new StringTokenizer(tokenizedPath, "/"); + StringTokenizer st = new StringTokenizer(tokenizedPath, "/"); //$NON-NLS-1$ ArrayList l = new ArrayList(); while(st.hasMoreTokens()) { String t = st.nextToken(); - if(t.length() == 0 || t.equals(".")) continue; - if(t.equals("..")) { + if(t.length() == 0 || t.equals(".")) continue; //$NON-NLS-1$ + if(t.equals("..")) { //$NON-NLS-1$ if(l.size() > 0) l.remove(l.size() - 1); continue; } @@ -525,20 +527,20 @@ public static String encode(String text, String encoding) { if(true) return text; try { - byte[] bs = text.getBytes(System.getProperty("file.encoding")); + byte[] bs = text.getBytes(System.getProperty("file.encoding")); //$NON-NLS-1$ ByteArrayInputStream is = new ByteArrayInputStream(bs); InputStreamReader r = new InputStreamReader(is, encoding); char[] cs = new char[bs.length]; int l = r.read(cs, 0, cs.length); return new String(cs, 0, l); } catch (IOException e) { - if("UTF-8".equals(encoding)) return text; - return encode(text, "UTF-8"); + if("UTF-8".equals(encoding)) return text; //$NON-NLS-1$ + return encode(text, "UTF-8"); //$NON-NLS-1$ } } public static String encodeDefault(String text) { - return encode(text, System.getProperties().getProperty("file.encoding")); + return encode(text, System.getProperties().getProperty("file.encoding")); //$NON-NLS-1$ } /* @@ -592,10 +594,10 @@ public static String getEncoding(String s) { if(s == null) return null; - if(s.startsWith("<?xml")) { - int i = s.indexOf("encoding="); + if(s.startsWith("<?xml")) { //$NON-NLS-1$ + int i = s.indexOf("encoding="); //$NON-NLS-1$ if(i < 0) return null; - i += "encoding=".length() + 1; + i += "encoding=".length() + 1; //$NON-NLS-1$ int j = s.indexOf('\"', i); if(j < 0) return null; return s.substring(i, j); @@ -611,7 +613,7 @@ if(validEncodings.contains(encoding)) return encoding; if(invalidEncodings.contains(encoding)) return defaultEncoding; try { - if(defaultEncoding.equals("UTF-16")) { + if(defaultEncoding.equals("UTF-16")) { //$NON-NLS-1$ new String(XML_16, 0, XML_16.length, encoding); } else { new String(XML_8, 0, XML_8.length, encoding); @@ -631,15 +633,15 @@ if(bs.length < 20) return null; if(startsWith(bs, XML_8)) { int i = getIndex(bs, (byte)'?', 5); - if(i < 0) return "UTF-8"; + if(i < 0) return "UTF-8";//$NON-NLS-1$ String encoding = getEncoding(new String(bs, 0, i)); - return validateEncoding(encoding, "UTF-8"); + return validateEncoding(encoding, "UTF-8");//$NON-NLS-1$ } else if(startsWith(bs, XML_16)) { int i = getIndex(bs, (byte)'?', XML_16.length); - if(i < 0) return "UTF-16"; + if(i < 0) return "UTF-16";//$NON-NLS-1$ try { - String encoding = getEncoding(new String(bs, 0, i, "UTF-16")); - return validateEncoding(encoding, "UTF-16"); + String encoding = getEncoding(new String(bs, 0, i, "UTF-16"));//$NON-NLS-1$ + return validateEncoding(encoding, "UTF-16");//$NON-NLS-1$ } catch (UnsupportedEncodingException e) { return null; } Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/.settings/org.eclipse.jdt.core.prefs =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/.settings/org.eclipse.jdt.core.prefs 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/.settings/org.eclipse.jdt.core.prefs 2009-06-08 03:33:39 UTC (rev 15762) @@ -1,4 +1,4 @@ -#Wed Feb 14 16:03:30 CET 2007 +#Mon Jun 08 11:25:11 PDT 2009 eclipse.preferences.version=1 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5 @@ -7,6 +7,68 @@ org.eclipse.jdt.core.compiler.debug.lineNumber=generate org.eclipse.jdt.core.compiler.debug.localVariable=generate org.eclipse.jdt.core.compiler.debug.sourceFile=generate +org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning org.eclipse.jdt.core.compiler.problem.assertIdentifier=error +org.eclipse.jdt.core.compiler.problem.autoboxing=ignore +org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning +org.eclipse.jdt.core.compiler.problem.deadCode=warning +org.eclipse.jdt.core.compiler.problem.deprecation=warning +org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled +org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled +org.eclipse.jdt.core.compiler.problem.discouragedReference=warning +org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore org.eclipse.jdt.core.compiler.problem.enumIdentifier=error +org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore +org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled +org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore +org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning +org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning +org.eclipse.jdt.core.compiler.problem.forbiddenReference=error +org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning +org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning +org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore +org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore +org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore +org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning +org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore +org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore +org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning +org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore +org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning +org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=error +org.eclipse.jdt.core.compiler.problem.nullReference=warning +org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning +org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore +org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore +org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore +org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning +org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore +org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=ignore +org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled +org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning +org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled +org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore +org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning +org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning +org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore +org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning +org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore +org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore +org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled +org.eclipse.jdt.core.compiler.problem.unusedImport=warning +org.eclipse.jdt.core.compiler.problem.unusedLabel=warning +org.eclipse.jdt.core.compiler.problem.unusedLocal=warning +org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore +org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled +org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled +org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning +org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning +org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning org.eclipse.jdt.core.compiler.source=1.5 Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -29,8 +29,6 @@ public static String DefaultConnectionWizardPage_Name_In_Use; public static String DeleteConnection; - - public static String AttributeControlFactory_updateButtonTitle; public static String AttributeDetails_title; public static String AttributeDetailsSection_errorTitle; @@ -85,8 +83,11 @@ public static String vertical; public static String writable; public static String writeOnly; + public static String TypeInAFilter; + public static String LoadingJMXNodes; + public static String Loading; + public static String UpdatingSelectionJob; - static { NLS.initializeMessages("org.jboss.tools.jmx.ui.Messages", //$NON-NLS-1$ Messages.class); Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.properties =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.properties 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/Messages.properties 2009-06-08 03:33:39 UTC (rev 15762) @@ -72,4 +72,8 @@ vertical=vertical writable=Writable writeOnly=Write-Only -DeleteConnection=Delete Connection \ No newline at end of file +DeleteConnection=Delete Connection +TypeInAFilter=Type in a filter +LoadingJMXNodes=Loading JMX Nodes +Loading=Loading... +UpdatingSelectionJob=Updating selection job \ No newline at end of file Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/StringUtils.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/StringUtils.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/StringUtils.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -69,7 +69,7 @@ * this function is be called recursively to display multi-dimensional * arrays, e.g. int[][] */ - @SuppressWarnings("unchecked") //$NON-NLS-1$ + @SuppressWarnings("unchecked") public static String toString(String type, boolean detailed) { Assert.isNotNull(type); Assert.isLegal(type.length() > 0); Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/adapters/JMXAdapterFactory.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/adapters/JMXAdapterFactory.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/adapters/JMXAdapterFactory.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -20,7 +20,7 @@ /** * @see org.eclipse.core.runtime.IAdapterFactory#getAdapterList() */ - @SuppressWarnings("unchecked") //$NON-NLS-1$ + @SuppressWarnings("unchecked") public Class[] getAdapterList() { return new Class[] { IPropertySource.class }; } @@ -29,7 +29,7 @@ * @see org.eclipse.core.runtime.IAdapterFactory#getAdapter(java.lang.Object, * java.lang.Class) */ - @SuppressWarnings("unchecked") //$NON-NLS-1$ + @SuppressWarnings("unchecked") public Object getAdapter(Object adaptableObject, Class adapterType) { if (adapterType == IPropertySource.class) { return adaptToPropertySource(adaptableObject); Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/CollectionControlFactory.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/CollectionControlFactory.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/CollectionControlFactory.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -24,7 +24,7 @@ public class CollectionControlFactory extends AbstractTabularControlFactory { @Override - @SuppressWarnings("unchecked") //$NON-NLS-1$ + @SuppressWarnings("unchecked") protected void fillTable(final Table table, final Object value) { TableColumn columnName = new TableColumn(table, SWT.NONE); columnName.setText(Messages.name); Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/MapControlFactory.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/MapControlFactory.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/MapControlFactory.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -24,7 +24,7 @@ public class MapControlFactory extends AbstractTabularControlFactory { @Override - @SuppressWarnings("unchecked") //$NON-NLS-1$ + @SuppressWarnings("unchecked") protected void fillTable(final Table table, final Object value) { TableColumn keyColumn = new TableColumn(table, SWT.NONE); keyColumn.setText(Messages.key); Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TabularDataControlFactory.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TabularDataControlFactory.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TabularDataControlFactory.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -26,7 +26,7 @@ public class TabularDataControlFactory extends AbstractTabularControlFactory { @Override - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") protected void fillTable(final Table table, final Object value) { TabularData data = (TabularData) value; Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TextControlFactory.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TextControlFactory.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/controls/TextControlFactory.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -116,7 +116,7 @@ if (toolkit != null) { text = toolkit.createText(parent, "", style); //$NON-NLS-1$ } else { - text = new Text(parent, style); //$NON-NLS-1$ + text = new Text(parent, style); } return text; } Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/dialogs/OpenMBeanSelectionDialog.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/dialogs/OpenMBeanSelectionDialog.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/dialogs/OpenMBeanSelectionDialog.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -60,7 +60,7 @@ return result; } - @SuppressWarnings("unchecked") //$NON-NLS-1$ + @SuppressWarnings("unchecked") @Override protected Control createDialogArea(Composite parent) { Composite area = (Composite) super.createDialogArea(parent); @@ -94,7 +94,7 @@ } @Override - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") protected void computeResult() { IStructuredSelection selection = (IStructuredSelection) viewer .getSelection(); @@ -114,13 +114,13 @@ class ContentProvider implements IStructuredContentProvider, ITreeContentProvider { - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") private List mbeans; ContentProvider() { } - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") public void inputChanged(Viewer v, Object oldInput, Object newInput) { this.mbeans = (List) newInput; } @@ -128,7 +128,7 @@ public void dispose() { } - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") public Object[] getElements(Object parent) { if (mbeans != null) { return mbeans @@ -141,7 +141,7 @@ return null; } - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") public Object[] getChildren(Object parent) { return new Object[0]; } Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/MBeanEditorInput.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/MBeanEditorInput.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/MBeanEditorInput.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -42,7 +42,7 @@ return wrapper.getObjectName().getCanonicalName(); } - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") public Object getAdapter(Class adapter) { return null; } Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/NotificationsPage.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/NotificationsPage.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/NotificationsPage.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -82,7 +82,7 @@ private NotificationListener listener; - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") private List notifications = new ArrayList(); private TableViewer viewer; @@ -157,7 +157,7 @@ viewer.setLabelProvider(new NotificationLabelProvider()); viewer.setContentProvider(new IStructuredContentProvider() { - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") public Object[] getElements(Object inputElement) { return (Notification[]) notifications .toArray(new Notification[notifications.size()]); @@ -173,7 +173,7 @@ }); viewer.setInput(notifications); listener = new NotificationListener() { - @SuppressWarnings("unchecked")//$NON-NLS-1$ + @SuppressWarnings("unchecked") public void handleNotification(final Notification notification, Object handback) { // add notification at the head so that the more recent Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/OperationDetails.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/OperationDetails.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/editors/OperationDetails.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -248,7 +248,7 @@ }}); } } catch (Exception e) { - String message = e.getClass().getName() + ": " + e.getLocalizedMessage(); + String message = e.getClass().getName() + ": " + e.getLocalizedMessage(); //$NON-NLS-1$ JMXUIActivator.log(IStatus.ERROR, e.getClass().getName(), e); // if the exception has a cause, it is likely more interesting // since it may be the exception thrown by the mbean @@ -256,7 +256,7 @@ // rather than the exception thrown by the mbean server // connection if (e.getCause() != null) { - message = e.getCause().getClass().getName() + ": " + e.getCause().getLocalizedMessage(); + message = e.getCause().getClass().getName() + ": " + e.getCause().getLocalizedMessage(); //$NON-NLS-1$ } final String message2 = message; Display.getDefault().asyncExec(new Runnable() { public void run() { Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/EmbedableLabelProvider.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/EmbedableLabelProvider.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/EmbedableLabelProvider.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -16,7 +16,7 @@ public String getText(Object element) { if( element instanceof IConnectionWrapper ) { - return "JMX"; + return "JMX"; //$NON-NLS-1$ } return delegate.getText(element); } Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/JMXNavigator.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/JMXNavigator.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/JMXNavigator.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -23,6 +23,7 @@ import org.eclipse.ui.internal.navigator.NavigatorContentService; import org.eclipse.ui.navigator.CommonNavigator; import org.eclipse.ui.navigator.LinkHelperService; +import org.jboss.tools.jmx.ui.Messages; import org.jboss.tools.jmx.ui.internal.actions.NewConnectionAction; /** @@ -60,8 +61,8 @@ fd.bottom = new FormAttachment(100,0); getCommonViewer().getTree().setLayoutData(fd); - filterText.setToolTipText("Type in a filter"); - filterText.setText("Type in a filter"); + filterText.setToolTipText(Messages.TypeInAFilter); + filterText.setText(Messages.TypeInAFilter); Display.getDefault().asyncExec(new Runnable() { public void run() { Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerContentProvider.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerContentProvider.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerContentProvider.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -30,6 +30,7 @@ import org.jboss.tools.jmx.core.tree.Node; import org.jboss.tools.jmx.core.tree.ObjectNameNode; import org.jboss.tools.jmx.core.tree.Root; +import org.jboss.tools.jmx.ui.Messages; /** * Content provider for the view @@ -99,7 +100,7 @@ return getChildren(w.getRoot()); // Must load the model - Job job = new Job("Loading JMX Nodes") { + Job job = new Job(Messages.LoadingJMXNodes) { protected IStatus run(IProgressMonitor monitor) { try { w.loadRoot(monitor); Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerLabelProvider.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerLabelProvider.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/MBeanExplorerLabelProvider.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -28,6 +28,7 @@ import org.jboss.tools.jmx.core.tree.DomainNode; import org.jboss.tools.jmx.core.tree.ObjectNameNode; import org.jboss.tools.jmx.core.tree.PropertyNode; +import org.jboss.tools.jmx.ui.Messages; import org.jboss.tools.jmx.ui.UIExtensionManager; import org.jboss.tools.jmx.ui.UIExtensionManager.ConnectionProviderUI; import org.jboss.tools.jmx.ui.internal.JMXImages; @@ -68,7 +69,7 @@ } if( obj instanceof DelayProxy ) { - return "Loading..."; + return Messages.Loading; } if (obj instanceof DomainNode) { Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/QueryContribution.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/QueryContribution.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/QueryContribution.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -68,12 +68,12 @@ protected void addListener() { navigator.getFilterText().addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { - boolean searchNew = matches == null || filterText == null || filterText.equals("") + boolean searchNew = matches == null || filterText == null || filterText.equals("") //$NON-NLS-1$ || !navigator.getFilterText().getText().startsWith(filterText); RefineThread thread = new RefineThread(searchNew, navigator.getFilterText().getText(), matches, shouldShow); - if( !navigator.getFilterText().getText().equals("")) { + if( !navigator.getFilterText().getText().equals("")) { //$NON-NLS-1$ if( refineThread != null ) refineThread.cancel(); refineThread = thread; Modified: trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/UpdateSelectionJob.java =================================================================== --- trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/UpdateSelectionJob.java 2009-06-07 13:56:54 UTC (rev 15761) +++ trunk/jmx/plugins/org.jboss.tools.jmx.ui/src/org/jboss/tools/jmx/ui/internal/views/navigator/UpdateSelectionJob.java 2009-06-08 03:33:39 UTC (rev 15762) @@ -27,11 +27,11 @@ import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.PlatformUI; -import org.eclipse.ui.internal.navigator.NavigatorContentService; import org.eclipse.ui.internal.navigator.NavigatorPlugin; import org.eclipse.ui.navigator.CommonNavigator; import org.eclipse.ui.navigator.LinkHelperService; import org.eclipse.ui.progress.UIJob; +import org.jboss.tools.jmx.ui.Messages; public class UpdateSelectionJob extends UIJob { @@ -53,7 +53,7 @@ private CommonNavigator commonNavigator; private LinkHelperService linkService; public UpdateSelectionJob(CommonNavigator commonNavigator) { - super("Updating Selection Job"); // TODO + super(Messages.UpdatingSelectionJob); // TODO this.commonNavigator = commonNavigator; if( commonNavigator instanceof JMXNavigator ) { linkService = ((JMXNavigator)commonNavigator).getLinkHelperService();