Author: adietish Date: 2012-10-23 10:39:24 -0400 (Tue, 23 Oct 2012) New Revision: 44611 Modified: branches/jbosstools-4.0.0.Beta1/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/connection/Connection.java Log: [JBIDE-12923] fixed parsing of connection-url when loading it from preferences. URI gets confused by empty host name (returns null username), URL allows empty host name. Modified: branches/jbosstools-4.0.0.Beta1/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/connection/Connection.java =================================================================== --- branches/jbosstools-4.0.0.Beta1/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/connection/Connection.java 2012-10-23 14:32:27 UTC (rev 44610) +++ branches/jbosstools-4.0.0.Beta1/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/connection/Connection.java 2012-10-23 14:39:24 UTC (rev 44611) @@ -78,7 +78,7 @@ UrlPortions portions = UrlUtils.toPortions(url); this.username = portions.getUsername(); Assert.isLegal( - StringUtils.isEmpty(username), + !StringUtils.isEmpty(username), NLS.bind("There is no no username for connection to url {0}", url.toString())); this.password = portions.getPassword(); setHost(portions.getHost());