Viacheslav Kabanovich wrote:
Hi, Vitali,
> I want to enhance this editor ("Hibernate Configuration 3.0 XML
Editor")
> to make it more useful and I want to integrate it into Hibernate Tools.
> For this it is necessary to separate org.jboss.tools.hibernate.xml
> and org.jboss.tools.hibernate.xml.ui, make it detached from XModel...
In my opinion that just means implementing new editor from scratch. In
doing so, you will develop components that you may wish to put to
common. We have many xml editors, there ui has a lot in common, so why
not share new approaches between them? And that is exactly what XModel
framework does. Plugins .hibernate.xml and .hibernate.xml.ui include
just few lines of code customizing components developed in common. Why
'integrating editor into Hibernate Tools' should mean separating it
from common?
The problem is that common isn't just common. It includes ton's of jsf,
xhtml, jsp and even struts references. That is what we need separated
before I'm ok having Hibernate tools feature depend on it.
i.e. if I *only* install Hibernate tools feature it should *not* result
in other additional editors such as jsf, jsp, xhtml etc. to be installed.
That were the case last time I tried it - if that has changed we should
look at it again.
/max