11:33 p.m.
Dmitry,
please be careful. That's second time in two days I have to fix build
compilations errors.
[java] [javac] 32. ERROR in
/home/hudson/jbosstools-build/eclipse/plugins/org.hibernate.eclipse.console.test/src/org/hibernate/eclipse/console/test/mappingproject/OpenMappingFileTest.java
(at line 31)
[java] [javac] final ConsoleConfiguration consCFG =
knownConfigurations.find(CreateConsoleConfigTest.ConsoleCFGName);
[java] [javac]
^^^^^^^^^^^^^^^^^^^^^^^
[java] [javac] CreateConsoleConfigTest cannot be resolved
[java] [javac] ----------
[java] [javac] ----------
[java] [javac] 33. ERROR in
/home/hudson/jbosstools-build/eclipse/plugins/org.hibernate.eclipse.console.test/src/org/hibernate/eclipse/console/test/mappingproject/OpenSourceFileTest.java
(at line 34)
[java] [javac] final ConsoleConfiguration consCFG =
knownConfigurations.find(CreateConsoleConfigTest.ConsoleCFGName);
[java] [javac]
^^^^^^^^^^^^^^^^^^^^^^^
[java] [javac] CreateConsoleConfigTest cannot be resolved
[java] [javac] ----------
[java] [javac] ----------
[java] [javac] 34. ERROR in
/home/hudson/jbosstools-build/eclipse/plugins/org.hibernate.eclipse.console.test/src/org/hibernate/eclipse/console/test/mappingproject/ProjectUtil.java
(at line 101)
[java] [javac] createConsoleConfiguration(null, null,
ConsoleCFGName, ConsoleConfigurationPreferences.ConfigurationMode.CORE,
[java] [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^
[java] [javac] The method createConsoleConfiguration(Shell,
EclipseConsoleConfiguration, String,
ConsoleConfigurationPreferences.ConfigurationMode, String, boolean,
String, IPath, IPath, IPath[], IPath[], String, String,
IProgressMonitor) from the type ConsoleConfigurationCreationWizard is
not visible
[java] [javac] ----------
[java] [javac] 34 problems (3 errors, 31 warnings)
I've commented CreateConsoleConfigTest usage in test classes and change
access level to public for createConsoleConfiguration method. Please fix
it ASAP.
Thanks
Denis
8:46 a.m.
I've found that 2 hibernate plugins (org.hibernate.eclipse.console and
org.hibernate.eclipse.mapper) compiled with jdk 1.4 level and others
with level 1.5.
Can I change their compilation level to 1.5?
--
Best regards,
Dmitry Geraskov
8:58 a.m.
Max Rydahl Andersen wrote:
>I've found that 2 hibernate plugins
(org.hibernate.eclipse.console and
>org.hibernate.eclipse.mapper) compiled with jdk 1.4 level and others
>with level 1.5.
>Can I change their compilation level to 1.5?
>
>
No; we don't use jdk 5 on the hibernate plugins just yet. Is it needed?
-max
No, but after Denises letter I decided completely synchronize with svn
and foud that I used SringBuilder (from jdk 1.5 ) in
OpenSource/MappingActions but jdk level in svn is 1.4.
Why we haven't compilation error there?
I'll change StringBuilder to StringBuffer.
--
Best regards,
Dmitry Geraskov
dgeraskov(a)exadel.com
Senior Developer
Exadel Inc
9:01 a.m.
Dmitry Geraskov wrote:
Max Rydahl Andersen wrote:
>> I've found that 2 hibernate plugins (org.hibernate.eclipse.console and
>> org.hibernate.eclipse.mapper) compiled with jdk 1.4 level and others
>> with level 1.5.
>> Can I change their compilation level to 1.5?
>>
>
>
> No; we don't use jdk 5 on the hibernate plugins just yet. Is it needed?
>
> -max
>
>
No, but after Denises letter I decided completely synchronize with svn
and foud that I used SringBuilder (from jdk 1.5 ) in
OpenSource/MappingActions but jdk level in svn is 1.4.
Why we haven't compilation error there?
I'll change StringBuilder to StringBuffer.
Also I found that MTreeViewer uses jdk 1.5 syntax.
--
Best regards,
Dmitry Geraskov
dgeraskov(a)exadel.com
Senior Developer
Exadel Inc
9:21 a.m.
>>> I've found that 2 hibernate plugins
(org.hibernate.eclipse.console and
>>> org.hibernate.eclipse.mapper) compiled with jdk 1.4 level and others
>>> with level 1.5.
>>> Can I change their compilation level to 1.5?
>>>
>>
>>
>> No; we don't use jdk 5 on the hibernate plugins just yet. Is it needed?
>>
>> -max
>>
>>
> No, but after Denises letter I decided completely synchronize with svn
> and foud that I used SringBuilder (from jdk 1.5 ) in
> OpenSource/MappingActions but jdk level in svn is 1.4.
> Why we haven't compilation error there?
> I'll change StringBuilder to StringBuffer.
>
Also I found that MTreeViewer uses jdk 1.5 syntax.
Weird that you don't get compile errors if the level is set to 1.4.
Let me just check a few things and maybe upgrading the plugins to 1.5 is ok. But
do please change it to be compilable for now.
-max
9:25 a.m.
Max Rydahl Andersen wrote:
>>>>I've found that 2 hibernate plugins
(org.hibernate.eclipse.console and
>>>>org.hibernate.eclipse.mapper) compiled with jdk 1.4 level and others
>>>>with level 1.5.
>>>>Can I change their compilation level to 1.5?
>>>>
>>>>
>>>>
>>>No; we don't use jdk 5 on the hibernate plugins just yet. Is it needed?
>>>
>>>-max
>>>
>>>
>>>
>>>
>>No, but after Denises letter I decided completely synchronize with svn
>>and foud that I used SringBuilder (from jdk 1.5 ) in
>>OpenSource/MappingActions but jdk level in svn is 1.4.
>>Why we haven't compilation error there?
>>I'll change StringBuilder to StringBuffer.
>>
>>
>>
>Also I found that MTreeViewer uses jdk 1.5 syntax.
>
>
Weird that you don't get compile errors if the level is set to 1.4.
Let me just check a few things and maybe upgrading the plugins to 1.5 is ok. But
do please change it to be compilable for now.
-max
No, I have (locally). But as Denis wrote me about compilation errors on
Hudson build in
org.hibernate.eclipse.console.test plugin I was surprised why we haven't errors in
org.hibernate.eclipse.console plugin earlier(on the build)? Or this build doesn't
build org.hibernate.eclipse.console plugin?
--
Best regards,
Dmitry Geraskov
dgeraskov(a)exadel.com
Senior Developer
Exadel Inc
12:49 p.m.
>
>Weird that you don't get compile errors if the level is set to 1.4.
>
>Let me just check a few things and maybe upgrading the plugins to 1.5 is ok. But
>do please change it to be compilable for now.
>
>-max
>
>
No, I have (locally). But as Denis wrote me about compilation errors on
Hudson build in
org.hibernate.eclipse.console.test plugin I was surprised why we haven't errors in
org.hibernate.eclipse.console plugin earlier(on the build)? Or this build doesn't
build org.hibernate.eclipse.console plugin?
I dont recall exactly, but I think maybe the build has its own java settings per
build....
we should fix that if that is the case.
Marshall ?
-max
3:32 a.m.
Max Rydahl Andersen wrote:
I dont recall exactly, but I think maybe the build has its own java
settings per build....
we should fix that if that is the case.
Marshall ?
Yes, each builder has it's own java compiler settings. Most of our
builders are using Java 1.5 compiler compliance now, including
hibernate-tools. Are we sure Dmitry's error wasn't Java 6 related?
--
Marshall Culpepper
Red Hat Developer Studio, JBoss Tools
marshall(a)jboss.org
8:39 a.m.
On Sat, 12 Jan 2008 03:32:26 +0100, Marshall Culpepper
<marshall.culpepper(a)redhat.com> wrote:
Max Rydahl Andersen wrote:
> I dont recall exactly, but I think maybe the build has its own java settings per
build....
> we should fix that if that is the case.
>
> Marshall ?
>
Yes, each builder has it's own java compiler settings. Most of our
builders are using Java 1.5 compiler compliance now, including
hibernate-tools. Are we sure Dmitry's error wasn't Java 6 related?
does not look like it since the issue seem to be him using StringBuilder instead of
StringBuffer.
btw. if a project has settings in .settings about compliation are they being honored?
/max
10:41 a.m.
Max Rydahl Andersen wrote:
On Sat, 12 Jan 2008 03:32:26 +0100, Marshall Culpepper
<marshall.culpepper(a)redhat.com> wrote:
>Max Rydahl Andersen wrote:
>
>
>>I dont recall exactly, but I think maybe the build has its own java settings per
build....
>>we should fix that if that is the case.
>>
>>Marshall ?
>>
>>
>>
>Yes, each builder has it's own java compiler settings. Most of our
>builders are using Java 1.5 compiler compliance now, including
>hibernate-tools. Are we sure Dmitry's error wasn't Java 6 related?
>
>
I thinks Marshall doesn't fully understand me. So I retell the
"story"
from the beginning.
Denis wrote me about compile errors on Hudson build. It happend because
I didn't commit all my classes. After that I fixed this errors and
decited to review all differences between my local workspace and svn.
And I found somthing interesting in one of plugins:
in svn the plugin has compliance level 1.4 and java classes which
demand 1.5. (Locally I had compliance level 1.5).
And we haven't build errors on our Hudson build or any other. When I
overrite my local file ".classpass" from svn I got jdk leved 1.4 and
compile errors. (Because I used StringBuilder from jdk 1.5).
Therefore I asked Max about why we didn't know about the problem in svn.
Afterward I corrected files to use java 1.4 and nobody have compile
errors. But the question remained.
Your answer make all clear. Builders use Java 1.5 and we haven't errors
there. (Even when it seems we should).
May be we need review this strategy or it is not worth the trouble? (For
ex. try to update our java 1.4 plugins to version 1.5 or make build
attentive to the each plugin jdk level)
does not look like it since the issue seem to be him using
StringBuilder instead of StringBuffer.
btw. if a project has settings in .settings about compliation are they being honored?
/max
--
Best regards,
Dmitry Geraskov
dgeraskov(a)exadel.com
Senior Developer
Exadel Inc
5949
days inactive
5951
days old
jbosstools-dev@lists.jboss.org
10 comments
4 participants
participants (4)
-
Denis Golovin -
Dmitry Geraskov -
Marshall Culpepper -
Max Rydahl Andersen