2:02 p.m.
Author: jbalunas(a)redhat.com
Date: 2010-05-13 15:02:35 -0400 (Thu, 13 May 2010)
New Revision: 17035
Added:
root/core/trunk/api/checkstyle-suppressions.xml
Modified:
root/core/trunk/api/pom.xml
root/core/trunk/impl/pom.xml
root/core/trunk/pom.xml
Log:
Updated to fix checkstyle so that it checks core api/impl
Added: root/core/trunk/api/checkstyle-suppressions.xml
===================================================================
--- root/core/trunk/api/checkstyle-suppressions.xml (rev 0)
+++ root/core/trunk/api/checkstyle-suppressions.xml 2010-05-13 19:02:35 UTC (rev 17035)
@@ -0,0 +1,28 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+ "-//Puppy Crawl//DTD Suppressions 1.0//EN"
+ "http://www.puppycrawl.com/dtds/suppressions_1_0.dtd">
+
+<suppressions>
+ <suppress checks="DoubleCheckedLocking"
files="MultipartRequestRegistry.java" />
+ <suppress checks="FallThrough" files="JSMin.java" />
+ <suppress checks="IllegalCatch" files="UISwitchablePanel.java"
/>
+ <suppress checks="ModifiedControlVariable"
files="MultipartRequest.java" />
+ <suppress checks="IllegalCatch" files="StagingServer.java"
/>
+ <suppress checks="IllegalCatch"
files="PartialViewContextImpl.java" />
+ <suppress checks="FallThrough" files="StagingServer.java"
/>
+ <suppress checks="ModifiedControlVariable" files="Cookie.java"
/>
+ <suppress checks="IllegalCatch" files="CacheManager.java"
/>
+ <suppress checks="MissingSwitchDefault"
files="JSONTokener.java" />
+ <suppress checks="IllegalCatch" files="AjaxViewRoot.java"
/>
+ <suppress checks="FallThrough" files="XMLTokener.java" />
+ <suppress checks="IllegalCatch"
files="ResourceHandlerImpl.java" />
+ <suppress checks="IllegalThrows"
files="AbstractThreadedTest.java" />
+ <suppress checks="ModifiedControlVariable"
files="URLCodec.java" />
+
+ <!-- TODO it is hot fix for building process, this files belong to the test-base
module,
+ and must be removed from here -->
+ <suppress checks="IllegalCatch"
files="AbstractThreadedTest.java" />
+ <suppress checks="IllegalCatch" files="StagingServer.java"
/>
+</suppressions>
Modified: root/core/trunk/api/pom.xml
===================================================================
--- root/core/trunk/api/pom.xml 2010-05-13 19:00:00 UTC (rev 17034)
+++ root/core/trunk/api/pom.xml 2010-05-13 19:02:35 UTC (rev 17035)
@@ -46,7 +46,7 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
-
+
<!-- Provided dependencies -->
<dependency>
<groupId>com.sun.faces</groupId>
@@ -86,4 +86,13 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <!-- Trigger checkstyle checking for this module -->
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ </plugin>
+ </plugins>
+ </build>
</project>
\ No newline at end of file
Modified: root/core/trunk/impl/pom.xml
===================================================================
--- root/core/trunk/impl/pom.xml 2010-05-13 19:00:00 UTC (rev 17034)
+++ root/core/trunk/impl/pom.xml 2010-05-13 19:02:35 UTC (rev 17035)
@@ -143,11 +143,26 @@
</resources>
<plugins>
+ <!-- Trigger checkstyle checking for this module -->
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ </plugin>
+
<!--
+ TODO should be in profile not here. The path in profile
+ is correct
+ -->
+ <plugin>
+ <!-- Configure js documentation plugin -->
+ <groupId>gr.abiss.mvn.plugins</groupId>
+ <artifactId>maven-jstools-plugin</artifactId>
+ </plugin>
+
+ <!--
TODO Centralize this because calendar and context menu
use this too
+ Note: This may be removed by redisgn
-->
- <!-- Note: This may be removed by redisgn -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>javacc-maven-plugin</artifactId>
@@ -161,16 +176,6 @@
</plugin>
<!--
- TODO should be in profile not here. The path in profile
- is correct
- -->
- <plugin>
- <!-- Configure js documentation plugin -->
- <groupId>gr.abiss.mvn.plugins</groupId>
- <artifactId>maven-jstools-plugin</artifactId>
- </plugin>
-
- <!--
The following 2 plugins are specific to impl, and
create, process, and document JavaScript resources NOTE:
these are legacy and they and the resources they
Modified: root/core/trunk/pom.xml
===================================================================
--- root/core/trunk/pom.xml 2010-05-13 19:00:00 UTC (rev 17034)
+++ root/core/trunk/pom.xml 2010-05-13 19:02:35 UTC (rev 17035)
@@ -43,17 +43,5 @@
<module>api</module>
<module>impl</module>
</modules>
-
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-checkstyle-plugin</artifactId>
- <configuration>
-
<configLocation>richfaces-checkstyle/richfaces-checkstyle.xml</configLocation>
-
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
- </configuration>
- </plugin>
- </plugins>
- </build>
</project>